You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Per diem - Merchant field opens and can be edited when submitting from self DM #80291
Version Number: 9.3.7-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#76595 Email or phone of affected tester (no customers):jsiodjosjdnisojso@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Workspace has per diem rates.
Go to staging.new.expensify.com
Go to workspace chat.
Create a per diem expense.
Open the per diem expense.
Go to self DM.
Open the unreported per diem expense.
Click Report > Remove from report/
Click on the report header > Submit it to someone.
Change the merchant > Next.
On confirm page, click Create expense.
Open the per diem expense.
Expected Result:
In Step 8, merchant field should not appear because merchant is fixed for per diem expense.
Actual Result:
In Step 8, merchant field opens and can be edited.
In Step 10, the new merchant is not reflected in the submitted per diem expense.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #76595 - "Update create transaction Manual flow to ask for merchant after asking for amount" by @nkdengineer (High confidence) Related Issues: Original feature request in #76050
Recommendation: REVERT
PR #76595 should be reverted. The PR adds a merchant step to the manual expense creation flow but fails to exclude per diem expenses, which have a fixed merchant that cannot be edited.
Labels: Kept DeployBlockerCash (App PR caused the issue), removed DeployBlocker (not a backend issue)
Detailed Analysis
Evidence
PR #76595 was merged on 2026-01-22 and is included in the current staging deploy (version 9.3.7-0). The issue was caught during regression testing and is reproducible on staging.
The PR modified the expense creation flow to add a merchant step after the amount step for manual expenses. The changes affected:
src/libs/IOUUtils.ts - Added shouldRequireMerchant() function
src/pages/iou/request/step/IOURequestStepAmount.tsx - Added navigation to merchant step
src/pages/iou/request/step/IOURequestStepParticipants.tsx - Added merchant step logic when moving from self DM
I verified that per diem expenses are affected by checking:
File: src/libs/ReportUtils.ts (lines 4736-4741)
Contains explicit logic preventing merchant editing for per diem expenses:
if((fieldToEdit===CONST.EDIT_REQUEST_FIELD.AMOUNT||fieldToEdit===CONST.EDIT_REQUEST_FIELD.CURRENCY||fieldToEdit===CONST.EDIT_REQUEST_FIELD.MERCHANT)&&isPerDiemRequest(transaction)){returnfalse;// Cannot edit merchant for per diem}
File: src/libs/actions/IOU/index.ts
Per diem merchant is computed automatically via computePerDiemExpenseMerchant() based on destination and dates
The merchant format is: "Destination, Start Date, End Date"
Root Cause
PR #76595 added logic to show the merchant step when creating/submitting manual expenses to workspaces. However, the shouldRequireMerchant() function (added in the PR) does not check if the transaction is a per diem request before requiring the merchant step.
Per diem expenses have these characteristics:
Merchant is automatically computed from destination and date range
Merchant field is read-only and cannot be edited (enforced by canEditFieldOfMoneyRequest)
Merchant should never be shown as an editable field
When submitting a per diem expense from self DM to a workspace (reproduction step 8), the new logic incorrectly navigates to the merchant editing screen. Because per diem merchants are read-only, any user input is ignored, causing confusion where:
User can type a new merchant (step 9)
The new merchant is not saved/reflected in the final expense (step 10)
The PR actually includes Test Case 7 which covers "Self DM Expense - Move to Workspace (Without Merchant)" but it only tested regular manual expenses, not per diem expenses. The test missed this edge case.
Activity
melvin-bot commentedon Jan 22, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #76595
melvin-bot commentedon Jan 22, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jan 22, 2026
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jan 22, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 22, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #76595 - "Update create transaction Manual flow to ask for merchant after asking for amount" by @nkdengineer (High confidence)
Related Issues: Original feature request in #76050
Recommendation: REVERT
PR #76595 should be reverted. The PR adds a merchant step to the manual expense creation flow but fails to exclude per diem expenses, which have a fixed merchant that cannot be edited.
Labels: Kept
DeployBlockerCash(App PR caused the issue), removedDeployBlocker(not a backend issue)Detailed Analysis
Evidence
PR #76595 was merged on 2026-01-22 and is included in the current staging deploy (version 9.3.7-0). The issue was caught during regression testing and is reproducible on staging.
The PR modified the expense creation flow to add a merchant step after the amount step for manual expenses. The changes affected:
src/libs/IOUUtils.ts- AddedshouldRequireMerchant()functionsrc/pages/iou/request/step/IOURequestStepAmount.tsx- Added navigation to merchant stepsrc/pages/iou/request/step/IOURequestStepParticipants.tsx- Added merchant step logic when moving from self DMsrc/pages/iou/request/step/IOURequestStepMerchant.tsx- Updated merchant step navigationVerification
I verified that per diem expenses are affected by checking:
File:
src/libs/ReportUtils.ts(lines 4736-4741)File:
src/libs/actions/IOU/index.tscomputePerDiemExpenseMerchant()based on destination and datesRoot Cause
PR #76595 added logic to show the merchant step when creating/submitting manual expenses to workspaces. However, the
shouldRequireMerchant()function (added in the PR) does not check if the transaction is a per diem request before requiring the merchant step.Per diem expenses have these characteristics:
canEditFieldOfMoneyRequest)When submitting a per diem expense from self DM to a workspace (reproduction step 8), the new logic incorrectly navigates to the merchant editing screen. Because per diem merchants are read-only, any user input is ignored, causing confusion where:
Test Case 7 in PR #76595
The PR actually includes Test Case 7 which covers "Self DM Expense - Move to Workspace (Without Merchant)" but it only tested regular manual expenses, not per diem expenses. The test missed this edge case.
cead22 commentedon Jan 23, 2026
We reverted the offending PR and CP'd it to staging. @mitarachim Can you please re-test and reopen this if the issue persists? Thanks