You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Add BA - Business Information step is skipped when connecting non-US BA #80385
Version Number: 9.3.7-3 Reproducible in staging?: Yes Reproducible in production?: Unable to validate in Prod - Provide reasoning. If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176691/test-cases/41236748 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: MacBook Air 15.7.3 Chrome App Component: Other
Action Performed:
Sign in to ND
Create a workspace, selecting AUD as a primary currency
Proceed through steps 1-2, entering random info, that does not trigger an error
On the confirmation screen at the end of step 2 click "Confirm"
Expected Result:
User is navigated to step 3 "What's the business name" page
Actual Result:
Step 3 "Business information" is skipped, user is navigated to the step 4 (sometimes even step 5)
changed the title [-]Add BA - Business Information step is skipped when connecting non-US BA[/-][+][$250] Add BA - Business Information step is skipped when connecting non-US BA[/+]on Jan 23, 2026
Please re-state the problem that we are trying to solve in this issue.
When creating a workspace with AUD currency (non-USD), after completing step 2 (Bank Info) and clicking "Confirm", step 3 (Business Information) is skipped and the user is navigated directly to step 4 or 5.
What is the root cause of that problem?
The issue is caused by a race condition with asynchronous Onyx state updates across multiple steps.
BankInfo calls onSubmit() to move to BusinessInfo (step 3)
BankInfo calls clearReimbursementAccountBankCreation() to reset isSuccess to null (async)
BusinessInfo mounts before the Onyx merge completes
BusinessInfo sees isSuccess === true (from step 2's success)
BusinessInfo immediately calls onSubmit(), skipping to step 4
The same cascade can occur for subsequent steps, causing step 4 and 5 to also be skipped.
What changes do you think we should make in order to solve the problem?
Add a step-specific flag check to ensure we only proceed when this step's API was called, not a previous step's. Each step already has a unique loading flag (e.g., isSavingCorpayOnboardingCompanyFields for BusinessInfo). We should track when this flag transitions from true to false with isSuccess === true.
In BusinessInfo.tsx:
+const prevIsSaving = usePrevious(reimbursementAccount?.isSavingCorpayOnboardingCompanyFields);
useEffect(() => {
- if (reimbursementAccount?.errors || reimbursementAccount?.isSavingCorpayOnboardingCompanyFields || !reimbursementAccount?.isSuccess) {+ // Only proceed if THIS step's API call completed successfully (not a previous step's)+ if (+ reimbursementAccount?.errors ||+ reimbursementAccount?.isSavingCorpayOnboardingCompanyFields ||+ !reimbursementAccount?.isSuccess ||+ !prevIsSaving // Ensure we were actually saving from this step+ ) {
return;
}
if (reimbursementAccount?.isSuccess) {
onSubmit();
clearReimbursementAccountSaveCorpayOnboardingCompanyDetails();
}
-}, [reimbursementAccount?.errors, reimbursementAccount?.isSavingCorpayOnboardingCompanyFields, reimbursementAccount?.isSuccess, onSubmit]);+}, [reimbursementAccount?.errors, reimbursementAccount?.isSavingCorpayOnboardingCompanyFields, reimbursementAccount?.isSuccess, onSubmit, prevIsSaving]);
What alternative solutions did you explore? (Optional)
Or we can add the Navigation.setNavigationActionToMicrotaskQueue to wrap onSubmit();
if (reimbursementAccount?.isSuccess) {
clearReimbursementAccountBankCreation();
Navigation.setNavigationActionToMicrotaskQueue(()=>{
onSubmit();
})
}
The PR description explicitly states: "Fixed an issue where for non USD BAs steps 3 and 4 were being skipped"
It modified both BankInfo.tsx and BusinessInfo.tsx — the exact files involved in this bug's race condition
The QA steps include: "Steps 3 and 4 should not be skipped"
Timeline matches: the PR merged on Feb 3, and by Feb 9-11 both DylanDylann and daledah confirmed the bug was no longer reproducible on main
The PR was linked to issue Expensify/App#79047 (a refactoring task), but the refactoring also resolved the step-skipping race condition described in this issue.
We provide useful information about popular choices, latest updates, and the McDonalds What’s New Menu to help you explore fresh flavors and exciting options. Whether you are looking for classic favorites or new menu items, our content makes it easier to find the best McDonald’s meals for every taste.
📣 @mcdonaldsmenus! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Activity
[-]Add BA - Business Information step is skipped when connecting non-US BA[/-][+][$250] Add BA - Business Information step is skipped when connecting non-US BA[/+]melvin-bot commentedon Jan 23, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022014772193439070623
melvin-bot commentedon Jan 23, 2026
Triggered auto assignment to @brianlee-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Jan 23, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (
External)daledah commentedon Jan 23, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When creating a workspace with AUD currency (non-USD), after completing step 2 (Bank Info) and clicking "Confirm", step 3 (Business Information) is skipped and the user is navigated directly to step 4 or 5.
What is the root cause of that problem?
The issue is caused by a race condition with asynchronous Onyx state updates across multiple steps.
In
BankInfo.tsx(step 2), when the API succeeds:App/src/pages/ReimbursementAccount/NonUSD/BankInfo/BankInfo.tsx
Lines 64 to 73 in c9e36d3
The
clearReimbursementAccountBankCreation()function usesOnyx.merge()which is asynchronous:App/src/libs/actions/BankAccounts.ts
Lines 981 to 983 in c9e36d3
When
BusinessInfo.tsx(step 3) mounts, it also has a similar useEffect:App/src/pages/ReimbursementAccount/NonUSD/BusinessInfo/BusinessInfo.tsx
Lines 112 to 126 in c9e36d3
The race condition:
isSuccessbecomestrueonSubmit()to move to BusinessInfo (step 3)clearReimbursementAccountBankCreation()to resetisSuccesstonull(async)isSuccess === true(from step 2's success)onSubmit(), skipping to step 4The same cascade can occur for subsequent steps, causing step 4 and 5 to also be skipped.
What changes do you think we should make in order to solve the problem?
Add a step-specific flag check to ensure we only proceed when this step's API was called, not a previous step's. Each step already has a unique loading flag (e.g.,
isSavingCorpayOnboardingCompanyFieldsfor BusinessInfo). We should track when this flag transitions fromtruetofalsewithisSuccess === true.In
BusinessInfo.tsx:What alternative solutions did you explore? (Optional)
Or we can add the
Navigation.setNavigationActionToMicrotaskQueueto wraponSubmit();DylanDylann commentedon Jan 26, 2026
I can't reproduce
Screen.Recording.2026-01-26.at.14.15.51.mov
@daledah can you reproduce this bug on now?
daledah commentedon Jan 26, 2026
@DylanDylann i can reproduce it with a new AUD workspace
bug.mov
DylanDylann commentedon Jan 26, 2026
Thanks @daledah, I can reproduce it now after installing the new node module
19 remaining items
daledah commentedon Feb 25, 2026
@neil-marcellini kindly reminder here
neil-marcellini commentedon Feb 27, 2026
cool thanks, closing.
daledah commentedon Mar 1, 2026
@neil-marcellini @brianlee-expensify please handle the payment here since i was assigned to this issue and created the open PR here
brianlee-expensify commentedon Mar 2, 2026
@neil-marcellini based on this SO (https://stackoverflowteams.com/c/expensify/questions/7582/7583#7583:~:text=100%25%20if%20the,reviewed%20the%20PR.) it seems like we would still pay the full $250 - just wanted to confirm if the following still need to be done?
CC @mallenexpensify (see slack thread here to help with final decision)
brianlee-expensify commentedon Mar 2, 2026
confirmed with Matt Allen that no need to fill out the BZ checklist and regression test steps
@MelvinBot can you identify the PR that solved the bug here?
MelvinBot commentedon Mar 2, 2026
The PR that fixed this bug is PR #80354 - feat: Refactor FullStep components by
MrMuzyk, merged on Feb 3, 2026.Evidence:
BankInfo.tsxandBusinessInfo.tsx— the exact files involved in this bug's race conditionDylanDylannanddaledahconfirmed the bug was no longer reproducible on mainThe PR was linked to issue Expensify/App#79047 (a refactoring task), but the refactoring also resolved the step-skipping race condition described in this issue.
brianlee-expensify commentedon Mar 2, 2026
Payment Summary
garrettmknight commentedon Mar 6, 2026
$250 approved for @daledah
JmillsExpensify commentedon Mar 10, 2026
$250 approved for @DylanDylann
mcdonaldsmenus commentedon Jun 17, 2026
We provide useful information about popular choices, latest updates, and the McDonalds What’s New Menu to help you explore fresh flavors and exciting options. Whether you are looking for classic favorites or new menu items, our content makes it easier to find the best McDonald’s meals for every taste.
melvin-bot commentedon Jun 17, 2026
📣 @mcdonaldsmenus! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format: