You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reports - Missing Group columns in Week filter #80818
Version Number: 9.3.11-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80684 Email or phone of affected tester (no customers):applausetester+khcategory20@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.1 / Chrome App Component: Search
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #80684 - "Add support for groupBy week in Search" by @cristipaval (High confidence) Related Issues: None
Recommendation: ROLL FORWARD
A quick fix is needed to add the missing WEEK cases in three places. Reverting would remove the entire Week grouping feature that was intentionally added. The fix is straightforward and isolated.
Labels: Keeping DeployBlockerCash (App PR caused the issue), removing DeployBlocker (not a backend bug)
📋 Detailed Analysis
Evidence
PR #80684 added comprehensive support for "Group by Week" functionality in the Search feature. The PR successfully implemented most of the infrastructure including:
CONST definitions for GROUP_WEEK columns
UI components (WeekListItemHeader)
SearchTableHeader support
Styling for GROUP_WEEK columns
Date utility functions
However, the PR missed adding WEEK support in three critical places that handle custom column selection:
Type Definition: SearchCustomColumnIds in src/components/Search/types.ts line 142 only includes MONTH but not WEEK
getCustomColumns(): Missing case for CONST.SEARCH.GROUP_BY.WEEK (line 3080 in SearchUIUtils.ts)
getCustomColumnDefault(): Missing case for CONST.SEARCH.GROUP_BY.WEEK (line 3113 in SearchUIUtils.ts)
Identifying that all other groupBy types (MONTH, TAG, MERCHANT, CATEGORY, etc.) have corresponding entries in SearchCustomColumnIds type and both helper functions
Confirming WEEK is conspicuously absent from these three locations
Root Cause
When a user selects "Group by: Week" and then clicks the "Columns" button to customize which columns to display, the code path fails because:
The SearchCustomColumnIds type doesn't include WEEK column types
The getCustomColumns(CONST.SEARCH.GROUP_BY.WEEK) function returns an empty array instead of the WEEK custom columns
The getCustomColumnDefault(CONST.SEARCH.GROUP_BY.WEEK) function returns an empty array instead of default WEEK columns
This results in no columns being available for selection, causing the UI to show missing/empty column options.
typeSearchCustomColumnIds=|ValueOf<typeofCONST.SEARCH.TYPE_CUSTOM_COLUMNS.EXPENSE>|ValueOf<typeofCONST.SEARCH.TYPE_CUSTOM_COLUMNS.EXPENSE_REPORT>|ValueOf<typeofCONST.SEARCH.GROUP_CUSTOM_COLUMNS.CARD>|ValueOf<typeofCONST.SEARCH.GROUP_CUSTOM_COLUMNS.FROM>|ValueOf<typeofCONST.SEARCH.GROUP_CUSTOM_COLUMNS.WITHDRAWAL_ID>|ValueOf<typeofCONST.SEARCH.GROUP_CUSTOM_COLUMNS.CATEGORY>|ValueOf<typeofCONST.SEARCH.GROUP_CUSTOM_COLUMNS.MERCHANT>|ValueOf<typeofCONST.SEARCH.GROUP_CUSTOM_COLUMNS.TAG>|ValueOf<typeofCONST.SEARCH.GROUP_CUSTOM_COLUMNS.MONTH>|ValueOf<typeofCONST.SEARCH.GROUP_CUSTOM_COLUMNS.WEEK>;// ADD THIS LINE
File 2: src/libs/SearchUIUtils.ts (line ~3079)
caseCONST.SEARCH.GROUP_BY.MONTH:
returnObject.values(CONST.SEARCH.GROUP_CUSTOM_COLUMNS.MONTH);caseCONST.SEARCH.GROUP_BY.WEEK: // ADD THIS CASEreturnObject.values(CONST.SEARCH.GROUP_CUSTOM_COLUMNS.WEEK);
default:
return[];
File 3: src/libs/SearchUIUtils.ts (line ~3112)
caseCONST.SEARCH.GROUP_BY.MONTH:
returnCONST.SEARCH.GROUP_DEFAULT_COLUMNS.MONTH;caseCONST.SEARCH.GROUP_BY.WEEK: // ADD THIS CASEreturnCONST.SEARCH.GROUP_DEFAULT_COLUMNS.WEEK;
default:
return[];
Activity
melvin-bot commentedon Jan 28, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80684
melvin-bot commentedon Jan 28, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jan 28, 2026
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jan 28, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 28, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #80684 - "Add support for groupBy week in Search" by @cristipaval (High confidence)
Related Issues: None
Recommendation: ROLL FORWARD
A quick fix is needed to add the missing WEEK cases in three places. Reverting would remove the entire Week grouping feature that was intentionally added. The fix is straightforward and isolated.
Labels: Keeping
DeployBlockerCash(App PR caused the issue), removingDeployBlocker(not a backend bug)📋 Detailed Analysis
Evidence
PR #80684 added comprehensive support for "Group by Week" functionality in the Search feature. The PR successfully implemented most of the infrastructure including:
However, the PR missed adding WEEK support in three critical places that handle custom column selection:
SearchCustomColumnIdsinsrc/components/Search/types.tsline 142 only includes MONTH but not WEEKCONST.SEARCH.GROUP_BY.WEEK(line 3080 in SearchUIUtils.ts)CONST.SEARCH.GROUP_BY.WEEK(line 3113 in SearchUIUtils.ts)Verification
I verified the root cause by:
Root Cause
When a user selects "Group by: Week" and then clicks the "Columns" button to customize which columns to display, the code path fails because:
This results in no columns being available for selection, causing the UI to show missing/empty column options.
Proposed Fix
Add three missing cases:
File 1: src/components/Search/types.ts (line ~142)
File 2: src/libs/SearchUIUtils.ts (line ~3079)
File 3: src/libs/SearchUIUtils.ts (line ~3112)
puneetlath commentedon Jan 28, 2026
Doesn't seem like it needs to block the deploy, but something we should address as follow-up.
cc @cristipaval @neil-marcellini @trjExpensify
trjExpensify commentedon Jan 28, 2026
Yeah, agreed it's not a deploy blocker, but let's address it!
melvin-bot commentedon Jan 31, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
trjExpensify commentedon Feb 5, 2026
Done!