You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reports-Search query does not update when click on week group header #80849
Version Number: 9.3.11-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80684 Email or phone of affected tester (no customers):ndk.2303+224@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Windows 11 Home/Chrome App Component: Search
Click on a week group header (e.g., "Jan 25 - Jan 31, 2026")
Expected Result:
Verify the search query updates to filter by that week's date range
Verify groupBy is removed from the query
Verify only transactions from that week are displayed as individual items (not grouped)
Actual Result:
The search query does not update, the group only collapses instead.
Failed Test 10 in PR
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #80684 - "Add support for groupBy week in Search" by @cristipaval (High confidence) Related Issues: This PR was already reverted in #80824
Recommendation: REVERT (Already Completed)
The causing PR #80684 has already been reverted in PR #80824 on 2026-01-29. The issue reported in this deploy blocker is the expected behavior - the PR implementation had a bug where clicking on week group headers only collapsed/expanded the group instead of filtering transactions by that week date range.
Labels: Removed DeployBlocker label (this is a Frontend bug). Kept DeployBlockerCash label because the App deploy is still blocked until the revert reaches staging.
Detailed Analysis
Evidence
PR #80684 added support for groupBy:week in Search, which was merged on 2026-01-28 at 22:20:07 UTC. The issue reported here describes a failure in Test 10 from that PR's test plan, which expected:
Click on a week group header (e.g., "Jan 25 - Jan 31, 2026")
The search query should update to filter by that week's date range
groupBy should be removed from the query
Only transactions from that week should be displayed as individual items (not grouped)
Actual behavior: The group only collapses instead of filtering.
The PR added code to handle isTransactionWeekGroupListItemType(item) in the onSelectRow handler that should update the query
However, the onPress handler in TransactionGroupListItem.tsx has conditional logic that prevents onSelectRow from being called for week groups with transactions
Root Cause
The bug is in the onPress callback in TransactionGroupListItem.tsx (lines 209-216):
For week grouping (which is NOT an expense report type):
When the group has transactions, onSelectRow is NOT called
Instead, it only calls handleToggle() which collapses/expands the group
The week-filtering logic added in the Search component's onSelectRow handler never executes
This means the feature implementation was incomplete - while the filtering logic was added to handle week groups, the UI interaction wasn't properly wired up to trigger it. The PR should have either:
Modified the onPress logic to handle week groups differently (always call onSelectRow)
Or added a separate click handler to the week header component itself
The revert in PR #80824 was the correct immediate action to unblock the deploy.
Activity
melvin-bot commentedon Jan 29, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80684
melvin-bot commentedon Jan 29, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Jan 29, 2026
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Jan 29, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Jan 29, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #80684 - "Add support for groupBy week in Search" by @cristipaval (High confidence)
Related Issues: This PR was already reverted in #80824
Recommendation: REVERT (Already Completed)
The causing PR #80684 has already been reverted in PR #80824 on 2026-01-29. The issue reported in this deploy blocker is the expected behavior - the PR implementation had a bug where clicking on week group headers only collapsed/expanded the group instead of filtering transactions by that week date range.
Labels: Removed
DeployBlockerlabel (this is a Frontend bug). KeptDeployBlockerCashlabel because the App deploy is still blocked until the revert reaches staging.Detailed Analysis
Evidence
PR #80684 added support for
groupBy:weekin Search, which was merged on 2026-01-28 at 22:20:07 UTC. The issue reported here describes a failure in Test 10 from that PR's test plan, which expected:groupByshould be removed from the queryActual behavior: The group only collapses instead of filtering.
Verification
I confirmed that:
src/components/Search/index.tsx) and added week grouping logicisTransactionWeekGroupListItemType(item)in theonSelectRowhandler that should update the queryonPresshandler inTransactionGroupListItem.tsxhas conditional logic that preventsonSelectRowfrom being called for week groups with transactionsRoot Cause
The bug is in the
onPresscallback inTransactionGroupListItem.tsx(lines 209-216):For week grouping (which is NOT an expense report type):
onSelectRowis NOT calledhandleToggle()which collapses/expands the grouponSelectRowhandler never executesThis means the feature implementation was incomplete - while the filtering logic was added to handle week groups, the UI interaction wasn't properly wired up to trigger it. The PR should have either:
onPresslogic to handle week groups differently (always callonSelectRow)The revert in PR #80824 was the correct immediate action to unblock the deploy.
lakchote commentedon Jan 29, 2026
I don't think this should be a blocker as it's not a core feature.
lakchote commentedon Jan 29, 2026
Solved in #80800 with ef97591
melvin-bot commentedon Jan 31, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.