You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense-Using merchant rule url is not shown as link in expense details #81145
Version Number: V9.3.11-17 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80915 Email or phone of affected tester (no customers):dreamnitethedragon@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Redminote 10S Android 13 App Component: Workspace Settings
Action Performed:
Launch app
Create a workspace
Open Account - Expense Rules
Enter a merchant
Enter a merchant and description as # google.com and save
Open workspace chat
Create a expense with merchant used in step 4
Open the expense and note description is not shown as link
Create a report
Add an expense with same description used in step 5 # google.com
Open the expense and note description shown as link
Expected Result:
Using merchant rule url must be shown as link in expense details.
Actual Result:
Using merchant rule url is not shown as link in expense details.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug (but NOT caused by PR #80915) Causing PR: No specific PR identified - this appears to be a pre-existing bug Confidence: High
Recommendation: NEEDS INVESTIGATION
This issue was discovered during regression testing of PR #80915, but that PR only added an "Expense Rules" menu item to the settings page and did not modify any code related to expense description rendering.
Root Cause Analysis
The bug appears to be a pre-existing issue where URLs in descriptions set by expense rules are not automatically converted to links in the expense details view.
Technical Details:
In MoneyRequestView.tsx (line 880), the description field uses shouldRenderAsHTML={true}
When shouldRenderAsHTML is true, the component treats the title as raw HTML content
However, plain text URLs (like "google.com" or "#google.com") stored in transaction descriptions are not being linkified
This is different from manually entered descriptions which appear to work correctly
No changes were made to description rendering, Parser logic, or transaction handling
The issue reproduces on both staging AND production (per the issue description)
This suggests the bug existed before this deploy cycle
Next Steps
The fix likely requires one of the following approaches:
Modify the description rendering logic to parse and linkify plain text URLs even when shouldRenderAsHTML is true
Investigate how expense rules store descriptions and ensure URLs are properly formatted/linkified when applied
Consider using shouldParseTitle instead of (or in addition to) shouldRenderAsHTML for the description field
Tagging: @situchan (PR #80915 author) - This bug was discovered during regression testing of your PR, but it is not caused by your changes. The issue appears to be pre-existing.
Labels: No label changes made - keeping both DeployBlockerCash labels since this is a legitimate bug that needs to be addressed, even though it's not a new regression.
This happens because when we create an expense manually, we store the description as markdown, i.e. comment: {comment: "<h1><a href=\"https://google.com\" target=\"_blank\" rel=\"noreferrer noopener\">google.com</a></h1>"}. But when the rule updates the description, it just updates it as text, i.e. comment: {comment: '# google.com'}.
Activity
melvin-bot commentedon Feb 2, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80915
melvin-bot commentedon Feb 2, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Feb 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 2, 2026
Investigation Summary
Classification: Frontend bug (but NOT caused by PR #80915)
Causing PR: No specific PR identified - this appears to be a pre-existing bug
Confidence: High
Recommendation: NEEDS INVESTIGATION
This issue was discovered during regression testing of PR #80915, but that PR only added an "Expense Rules" menu item to the settings page and did not modify any code related to expense description rendering.
Root Cause Analysis
The bug appears to be a pre-existing issue where URLs in descriptions set by expense rules are not automatically converted to links in the expense details view.
Technical Details:
MoneyRequestView.tsx(line 880), the description field usesshouldRenderAsHTML={true}shouldRenderAsHTMLis true, the component treats the title as raw HTML contentKey Evidence:
src/pages/settings/InitialSettingsPage.tsxto add a menu itemNext Steps
The fix likely requires one of the following approaches:
shouldRenderAsHTMLis trueshouldParseTitleinstead of (or in addition to)shouldRenderAsHTMLfor the description fieldTagging: @situchan (PR #80915 author) - This bug was discovered during regression testing of your PR, but it is not caused by your changes. The issue appears to be pre-existing.
Labels: No label changes made - keeping both
DeployBlockerCashlabels since this is a legitimate bug that needs to be addressed, even though it's not a new regression.luacmartins commentedon Feb 2, 2026
Looking into this
luacmartins commentedon Feb 2, 2026
This happens because when we create an expense manually, we store the description as markdown, i.e.
comment: {comment: "<h1><a href=\"https://google.com\" target=\"_blank\" rel=\"noreferrer noopener\">google.com</a></h1>"}. But when the rule updates the description, it just updates it as text, i.e.comment: {comment: '# google.com'}.Fix merchant rule description URLs not rendering as links
luacmartins commentedon Feb 2, 2026
I'm working on this
luacmartins commentedon Feb 2, 2026
PR in review
luacmartins commentedon Feb 3, 2026
PR merged. We can close this one.
melvin-bot commentedon Feb 12, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.