You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Home Page] - Discover section disappear after Employee open it #81173
Version Number: v9.3.11-17 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80807 Email or phone of affected tester (no customers):applausetester+vq+010205@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Windows 11 / Chrome App Component: Left Hand Navigation (LHN)
Action Performed:
Preconditions: Use the Expensifail account, and 1st device log in to a High Traffic Expensifail account, invite another user to be a member of the Workspace
Open the NewDot app on a 2nd device
Sign in with the member who was invited before
Click on the Home tab
Click on the Discover section
Close the 2nd tab
Switch to the Owner account on the 1st device
Repeat the same step from 3 to 5
Expected Result:
The Discover section remains on the Home tab like the Owner and Admin accounts
Actual Result:
The Discover section disappears on the Employee side after opening
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #80965 - "[Home Page] Remove Beta Gate for Release 1" by @WojtekBoman (High confidence) Related Issues: None found
Recommendation: REVERT
PR #80965 introduced a logic error in the DiscoverSection component that causes the section to disappear for Employee users when they open it.
Labels: This is a frontend bug caused by an App PR. The DeployBlockerCash label should be KEPT (App deploy is blocked). If DeployBlocker is present, it should be removed.
Detailed Analysis
Evidence
PR #80965 made changes to src/pages/home/DiscoverSection.tsx that introduced the bug:
Created a local hasSeenTourSelector (lines 23-29) that returns true when the onboarding NVP is empty or undefined:
functionhasSeenTourSelector(onboarding: OnyxValue<typeofONYXKEYS.NVP_ONBOARDING>): boolean|undefined{if(isEmptyObject(onboarding)){returntrue;// PROBLEM: Returns true for empty objects}return!!onboarding?.selfTourViewed;}
Changed the default value from false to true (line 47):
Returns null when hasSeenTour is true (lines 67-69):
if(hasSeenTour){returnnull;}
Root Cause
The local hasSeenTourSelector has inverted logic compared to the canonical selector in /src/selectors/Onboarding.ts. When an Employee user has not seen the tour:
Their onboarding NVP is empty or undefined
The local selector returns true (incorrectly indicating they HAVE seen the tour)
Combined with the default value of true, hasSeenTour becomes true
The component returns null, hiding the Discover section
The comment in the code even reveals the misunderstanding: "This selector returns true if the user has seen the tour, or if the onboarding NVP is not loaded yet. Thanks to this, discover section does not disappear when the onboarding NVP is loaded."
This logic is backwards - returning true for unloaded data causes the section to be hidden by default for users who should see it.
Verification
The canonical hasSeenTourSelector in /src/selectors/Onboarding.ts (lines 51-57) has the correct logic:
functionhasSeenTourSelector(onboarding: OnyxValue<typeofONYXKEYS.NVP_ONBOARDING>): boolean|undefined{if(isEmptyObject(onboarding)){returnfalse;// Correctly returns false for empty objects}return!!onboarding?.selfTourViewed;}
The fix would be to either:
Use the canonical selector from /src/selectors/Onboarding.ts instead of the local one
Change the local selector to return false for empty objects and use false as the default value
I think this does not have to be a blocker, but it should disappear in both cases. It can be a bit abrupt though, I wonder if we should leave some option to still see it just less profound @JmillsExpensify
Yeah, I'm actually of the opinion that we should just permanently show it for now. I think it's net good to have it around, especially with the upcoming training updates from Matt Moore.
changed the title [-]Home - Discover section disappear after Employee open it[/-][+][Home Page] - Discover section disappear after Employee open it[/+]on Feb 5, 2026
Activity
melvin-bot commentedon Feb 2, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80807
melvin-bot commentedon Feb 2, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 2, 2026
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 2, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 2, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #80965 - "[Home Page] Remove Beta Gate for Release 1" by @WojtekBoman (High confidence)
Related Issues: None found
Recommendation: REVERT
PR #80965 introduced a logic error in the
DiscoverSectioncomponent that causes the section to disappear for Employee users when they open it.Labels: This is a frontend bug caused by an App PR. The
DeployBlockerCashlabel should be KEPT (App deploy is blocked). IfDeployBlockeris present, it should be removed.Detailed Analysis
Evidence
PR #80965 made changes to
src/pages/home/DiscoverSection.tsxthat introduced the bug:hasSeenTourSelector(lines 23-29) that returnstruewhen the onboarding NVP is empty or undefined:falsetotrue(line 47):hasSeenTouris true (lines 67-69):Root Cause
The local
hasSeenTourSelectorhas inverted logic compared to the canonical selector in/src/selectors/Onboarding.ts. When an Employee user has not seen the tour:onboardingNVP is empty or undefinedtrue(incorrectly indicating they HAVE seen the tour)true,hasSeenTourbecomestruenull, hiding the Discover sectionThe comment in the code even reveals the misunderstanding: "This selector returns true if the user has seen the tour, or if the onboarding NVP is not loaded yet. Thanks to this, discover section does not disappear when the onboarding NVP is loaded."
This logic is backwards - returning
truefor unloaded data causes the section to be hidden by default for users who should see it.Verification
The canonical
hasSeenTourSelectorin/src/selectors/Onboarding.ts(lines 51-57) has the correct logic:The fix would be to either:
/src/selectors/Onboarding.tsinstead of the local onefalsefor empty objects and usefalseas the default value6 remaining items
mountiny commentedon Feb 2, 2026
I think this does not have to be a blocker, but it should disappear in both cases. It can be a bit abrupt though, I wonder if we should leave some option to still see it just less profound @JmillsExpensify
JmillsExpensify commentedon Feb 2, 2026
Yeah, I'm actually of the opinion that we should just permanently show it for now. I think it's net good to have it around, especially with the upcoming training updates from Matt Moore.
mountiny commentedon Feb 2, 2026
Cool ok that makes sense, I think that that should work well
JmillsExpensify commentedon Feb 2, 2026
Cool, and if people want to dismiss it eventually, that's cool. We need the ability to dismiss, just like we had in Classic.
WojtekBoman commentedon Feb 4, 2026
I'll take a look at it 👀
[-]Home - Discover section disappear after Employee open it[/-][+][Home Page] - Discover section disappear after Employee open it[/+]ZhenjaHorbach commentedon Feb 11, 2026
@mountiny
Let's close this issue!