You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-19] [$250] Reimbursable and Non-reimbursable total appear and disappear after changing reimbursable status #81939
Version Number: 9.3.16-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80079 Email or phone of affected tester (no customers):soidjniosjdosjosidj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
2.Go to workspace chat.
Create an expense in foreign currency.
Open the expense report.
Disable Reimbursable toggle.
Enable Reimbursable toggle.
Expected Result:
Either Reimbursable or Non-reimbursable total will appear in Total section.
Actual Result:
Reimbursable and Non-reimbursable total appear and disappear together after changing reimbursable status.
Please re-state the problem that we are trying to solve in this issue.
Actual Result:
Reimbursable and Non-reimbursable total appear and disappear together after changing reimbursable status.
What is the root cause of that problem?
The condition for displaying the reimbursable/non-reimbursable breakdown in the Total section uses && operator, which requires BOTH values to be non-zero.
What alternative solutions did you explore? (Optional)
N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Please re-state the problem that we are trying to solve in this issue.
When toggling the reimbursable status of an expense in a report, both the "Reimbursable" and "Non-reimbursable" total rows in the breakdown section appear and disappear together, rather than showing independently based on whether each type of expense exists.
What is the root cause of that problem?
In MoneyReportView.tsx, both breakdown rows use the identicalshow condition — !!nonReimbursableSpend — so they are always coupled:
Because both rows gate their visibility on nonReimbursableSpend, when you toggle a single expense to non-reimbursable, both rows appear simultaneously (including a "Reimbursable: $0.00" row). When you toggle it back to reimbursable, nonReimbursableSpend drops to 0 and both rows vanish simultaneously.
The same coupling exists in the newer MoneyRequestReportTransactionList.tsx, where both rows use the same shouldShowExpenseReportBreakDown condition:
Note: The shouldShowBreakdown variable itself is not the problem — it already correctly uses || to determine whether the breakdown section renders. The issue is specifically in the individual row visibility conditions within that section.
What changes do you think we should make in order to solve the problem?
Each row should independently control its own visibility based on whether its respective spend value is non-zero:
In MoneyReportView.tsx (line 235-236):
cardTransactions.outOfPocket (Reimbursable row): change show to !!reimbursableSpend
cardTransactions.companySpend (Non-reimbursable row): keep show as !!nonReimbursableSpend (already correct for this row)
In MoneyRequestReportTransactionList.tsx (line 702-703):
Apply the same pattern: outOfPocket should show when reimbursable spend exists, companySpend should show when non-reimbursable spend exists, rather than both using the same flag.
No changes needed to shouldShowBreakdown — it correctly triggers the breakdown section when there is non-reimbursable spend, billable amounts, or taxes.
What alternative solutions did you explore? (Optional)
Considered changing shouldShowBreakdown to trigger on !!reimbursableSpend || !!nonReimbursableSpend, but this would cause the breakdown to always appear whenever any expenses exist (since one of the two is always non-zero), showing redundant info like "Reimbursable: $50" alongside "Total: $50" when all expenses are reimbursable.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Lotta comments on the PR, what's status here @rojiphil ?
@mallenexpensify I think this is due payment now.
We had originally fixed this issue as per this PR. However since we wanted to align with OD completely as mentioned here, we implemented a follow-up PR here. This has been in production since 13 Mar.
Further, QA also clarified another issue, which is unrelated.
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
No offending PR as we decided to align ourselves completely with OD
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
daledah commentedon Feb 10, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Actual Result:
Reimbursable and Non-reimbursable total appear and disappear together after changing reimbursable status.
What is the root cause of that problem?
The condition for displaying the reimbursable/non-reimbursable breakdown in the Total section uses
&&operator, which requires BOTH values to be non-zero.App/src/components/ReportActionItem/MoneyReportView.tsx
Line 84 in 013badf
App/src/components/ReportActionItem/MoneyReportView.tsx
Lines 232 to 233 in 013badf
When there's only one expense and you toggle reimbursable:
reimbursableSpend > 0butnonReimbursableSpend = 0nonReimbursableSpend > 0butreimbursableSpend = 0Because of the
&&condition, both rows appear/disappear together instead of showing independently.What changes do you think we should make in order to solve the problem?
Change the condition to use
||instead of&&for the breakdown visibility, and show each row independently:And update the individual row conditions:
What alternative solutions did you explore? (Optional)
N/A
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Mar 3, 2026
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Mar 3, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When toggling the reimbursable status of an expense in a report, both the "Reimbursable" and "Non-reimbursable" total rows in the breakdown section appear and disappear together, rather than showing independently based on whether each type of expense exists.
What is the root cause of that problem?
In
MoneyReportView.tsx, both breakdown rows use the identicalshowcondition —!!nonReimbursableSpend— so they are always coupled:https://github.com/Expensify/App/blob/main/src/components/ReportActionItem/MoneyReportView.tsx#L235-L236
Because both rows gate their visibility on
nonReimbursableSpend, when you toggle a single expense to non-reimbursable, both rows appear simultaneously (including a "Reimbursable: $0.00" row). When you toggle it back to reimbursable,nonReimbursableSpenddrops to 0 and both rows vanish simultaneously.The same coupling exists in the newer
MoneyRequestReportTransactionList.tsx, where both rows use the sameshouldShowExpenseReportBreakDowncondition:https://github.com/Expensify/App/blob/main/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx#L702-L703
Note: The
shouldShowBreakdownvariable itself is not the problem — it already correctly uses||to determine whether the breakdown section renders. The issue is specifically in the individual row visibility conditions within that section.What changes do you think we should make in order to solve the problem?
Each row should independently control its own visibility based on whether its respective spend value is non-zero:
In
MoneyReportView.tsx(line 235-236):cardTransactions.outOfPocket(Reimbursable row): changeshowto!!reimbursableSpendcardTransactions.companySpend(Non-reimbursable row): keepshowas!!nonReimbursableSpend(already correct for this row)In
MoneyRequestReportTransactionList.tsx(line 702-703):outOfPocketshould show when reimbursable spend exists,companySpendshould show when non-reimbursable spend exists, rather than both using the same flag.No changes needed to
shouldShowBreakdown— it correctly triggers the breakdown section when there is non-reimbursable spend, billable amounts, or taxes.What alternative solutions did you explore? (Optional)
Considered changing
shouldShowBreakdownto trigger on!!reimbursableSpend || !!nonReimbursableSpend, but this would cause the breakdown to always appear whenever any expenses exist (since one of the two is always non-zero), showing redundant info like "Reimbursable: $50" alongside "Total: $50" when all expenses are reimbursable.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.31 remaining items
melvin-bot commentedon Mar 19, 2026
Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Mar 19, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Mar 20, 2026
Lotta comments on the PR, what's status here @rojiphil ?
#84792 (comment)
rojiphil commentedon Mar 21, 2026
@mallenexpensify I think this is due payment now.
We had originally fixed this issue as per this PR. However since we wanted to align with OD completely as mentioned here, we implemented a follow-up PR here. This has been in production since 13 Mar.
Further, QA also clarified another issue, which is unrelated.
rojiphil commentedon Mar 21, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
No offending PR as we decided to align ourselves completely with OD
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/615063
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-ef6f-a83f-d173-348cb4a39af4mallenexpensify commentedon Mar 23, 2026
Payment Summary
Contributor+: @rojiphil due $250 via NewDot
Thx @rojiphil, think we're all set. comment/reopen, if needed.
quinthar commentedon Apr 13, 2026
Approved $250 to @rojiphil