Skip to content

Expense - Non-reimbursable total is missing #81940

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.16-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod - Provide reasoning.
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80079
Email or phone of affected tester (no customers): soidjniosjdosjosidj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Taxes are enabled.
  • Rules are enabled.
  • Billable default is set to Billable in Rules settings.
  1. Go to staging.new.expensify.com
    2.Go to workspace chat.
  2. Create a billable, non-reimbursable expense with non-zero tax rate.
  3. Open the expense report.

Expected Result:

Total section will show Billable, Non-reimbursable and Tax total.

Actual Result:

Total section shows only Billable and Tax total.
Non-reimbursable total is missing.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 10, 2026
  2. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #80079

  3. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Feb 10, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Feb 10, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #80079 - "feat: Add Billable and Tax subtotals to the report view" by @nkdengineer (High confidence)
    Related Issues: #78927

    Recommendation: REVERT

    PR #80079 introduced a logic error in the conditional rendering of expense breakdowns. When an expense is non-reimbursable only (with billable and tax), the non-reimbursable total is incorrectly hidden.

    Labels: Keeping DeployBlockerCash (App deploy blocker). No label changes needed as this is correctly classified as a Frontend bug.

    📋 Detailed Analysis

    Evidence

    In src/components/ReportActionItem/MoneyReportView.tsx (lines 232-233), the PR changed the display logic for reimbursable and non-reimbursable breakdowns:

    {label: 'cardTransactions.outOfPocket', value: formattedOutOfPocketAmount, show: !!nonReimbursableSpend && !!reimbursableSpend},
    {label: 'cardTransactions.companySpend', value: formattedCompanySpendAmount, show: !!nonReimbursableSpend && !!reimbursableSpend},

    Root Cause

    The show condition requires both nonReimbursableSpend AND reimbursableSpend to be truthy for either line to display. This is incorrect logic.

    Reproduction scenario:

    1. Create a billable, non-reimbursable expense with tax
    2. In this case: nonReimbursableSpend > 0, but reimbursableSpend = 0
    3. The condition !!nonReimbursableSpend && !!reimbursableSpend evaluates to true && false = false
    4. Result: The "Non-reimbursable" line is hidden even though there is non-reimbursable spend

    Expected behavior:

    • "Reimbursable" should show when !!reimbursableSpend
    • "Non-reimbursable" should show when !!nonReimbursableSpend
    • Each should display independently

    Verification

    The same flawed logic appears in both files modified by the PR:

    • src/components/ReportActionItem/MoneyReportView.tsx (line 232-233)
    • src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx (line 631-632)

    The issue is reproducible on staging (v9.3.16-0) and matches the exact reproduction steps from the original issue.

  7. nkdengineer commented on Feb 10, 2026

    @nkdengineer
    Contributor

    @trjExpensify Is this expected? We only want to show the non-reimbursable total when we have both reimbursable and non-reimbursable transactions.

  8. mjasikowski commented on Feb 10, 2026

    @mjasikowski
    Contributor

    PR reverted, removed blocker label. Closing the issue.

  9. trjExpensify commented on Feb 10, 2026

    @trjExpensify
    Contributor

    @trjExpensify Is this expected? We only want to show the non-reimbursable total when we have both reimbursable and non-reimbursable transactions.

    I think this is saying the opposite, right? I believe the logic is if any of the expenses on the report are non-reimbursable, show the sub-total. So whether that's a mix of reimbursable/non-reimbursable or all non-reimbursable. Feel free to check Classic as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions