You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Non-reimbursable total is missing #81940
Version Number: 9.3.16-0 Reproducible in staging?: Yes Reproducible in production?: Unable to validate in Prod - Provide reasoning. If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80079 Email or phone of affected tester (no customers):soidjniosjdosjosidj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Taxes are enabled.
Rules are enabled.
Billable default is set to Billable in Rules settings.
Go to staging.new.expensify.com
2.Go to workspace chat.
Create a billable, non-reimbursable expense with non-zero tax rate.
Open the expense report.
Expected Result:
Total section will show Billable, Non-reimbursable and Tax total.
Actual Result:
Total section shows only Billable and Tax total.
Non-reimbursable total is missing.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #80079 - "feat: Add Billable and Tax subtotals to the report view" by @nkdengineer (High confidence) Related Issues: #78927
Recommendation: REVERT
PR #80079 introduced a logic error in the conditional rendering of expense breakdowns. When an expense is non-reimbursable only (with billable and tax), the non-reimbursable total is incorrectly hidden.
Labels: Keeping DeployBlockerCash (App deploy blocker). No label changes needed as this is correctly classified as a Frontend bug.
📋 Detailed Analysis
Evidence
In src/components/ReportActionItem/MoneyReportView.tsx (lines 232-233), the PR changed the display logic for reimbursable and non-reimbursable breakdowns:
@trjExpensify Is this expected? We only want to show the non-reimbursable total when we have both reimbursable and non-reimbursable transactions.
I think this is saying the opposite, right? I believe the logic is if any of the expenses on the report are non-reimbursable, show the sub-total. So whether that's a mix of reimbursable/non-reimbursable or all non-reimbursable. Feel free to check Classic as well!
Activity
melvin-bot commentedon Feb 10, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80079
melvin-bot commentedon Feb 10, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 10, 2026
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 10, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 10, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #80079 - "feat: Add Billable and Tax subtotals to the report view" by @nkdengineer (High confidence)
Related Issues: #78927
Recommendation: REVERT
PR #80079 introduced a logic error in the conditional rendering of expense breakdowns. When an expense is non-reimbursable only (with billable and tax), the non-reimbursable total is incorrectly hidden.
Labels: Keeping
DeployBlockerCash(App deploy blocker). No label changes needed as this is correctly classified as a Frontend bug.📋 Detailed Analysis
Evidence
In
src/components/ReportActionItem/MoneyReportView.tsx(lines 232-233), the PR changed the display logic for reimbursable and non-reimbursable breakdowns:Root Cause
The
showcondition requires bothnonReimbursableSpendANDreimbursableSpendto be truthy for either line to display. This is incorrect logic.Reproduction scenario:
nonReimbursableSpend> 0, butreimbursableSpend= 0!!nonReimbursableSpend && !!reimbursableSpendevaluates totrue && false=falseExpected behavior:
!!reimbursableSpend!!nonReimbursableSpendVerification
The same flawed logic appears in both files modified by the PR:
src/components/ReportActionItem/MoneyReportView.tsx(line 232-233)src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx(line 631-632)The issue is reproducible on staging (v9.3.16-0) and matches the exact reproduction steps from the original issue.
nkdengineer commentedon Feb 10, 2026
@trjExpensify Is this expected? We only want to show the non-reimbursable total when we have both reimbursable and non-reimbursable transactions.
mjasikowski commentedon Feb 10, 2026
PR reverted, removed blocker label. Closing the issue.
trjExpensify commentedon Feb 10, 2026
I think this is saying the opposite, right? I believe the logic is if any of the expenses on the report are non-reimbursable, show the sub-total. So whether that's a mix of reimbursable/non-reimbursable or all non-reimbursable. Feel free to check Classic as well!