Skip to content

[$250] Expense-Mark as paid button is not shown for the IOU receiver. #81955

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.3.16-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-4875/folder/13177029/41237791/1179843193
Email or phone of affected tester (no customers): dreamnitethedragon+1a@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: Money Requests

Action Performed:

  1. Launch app
  2. Send a 1:1 expense
  3. Open the app as receiver

Expected Result:

Mark as paid button must be shown for the receiver.

Actual Result:

Mark as paid button is not shown for the receiver.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7073297_1770712419995.Screenrecorder-2026-02-10-14-00-35-722.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @situchan
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022031910653359059569
  • Upwork Job ID: 2031910653359059569
  • Last Price Increase: 2026-03-12
  • Automatic offers:
    • situchan | Contributor | 110744254

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Feb 10, 2026
  2. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Feb 10, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Feb 10, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Backend bug / NEEDS INVESTIGATION
    Causing PR: Unable to identify from frontend changes (Medium confidence)
    Related Issues: None found

    Recommendation: NEEDS INVESTIGATION

    After reviewing the StagingDeployCash PRs and the codebase, I cannot find a clear frontend PR that would cause this issue. The Mark as paid button visibility is controlled by the canIOUBePaid function in src/libs/actions/IOU/index.ts, which checks whether the current user is the payer (manager) of the IOU report.

    Key finding: For a 1:1 IOU (person-to-person money request), the button should show for the RECEIVER (the person who needs to be paid back), determined by checking if iouReport.managerID === currentUserAccountID.

    Since this bug:

    1. Only occurs on staging (not production)
    2. Affects a core IOU feature that has no recent frontend changes
    3. The button visibility logic has not been modified in the staging deploy

    This suggests the issue is most likely:

    • A backend bug where the managerID field is not being set correctly on newly created IOU reports on staging
    • OR a data inconsistency on the staging environment

    Labels: Keeping BOTH DeployBlockerCash and DeployBlocker until the root cause is confirmed, as we cannot rule out either frontend or backend issues.


    Next steps needed:

    1. Backend team to verify managerID is being set correctly on IOU report creation
    2. QA to provide a specific test case report ID to investigate the actual data
    3. Check if this affects only new IOUs or also existing ones

    @mitarachim @jliexpensify @neil-marcellini - Could you please provide a specific IOU report ID from staging where the button is missing? This will help determine if the issue is with how the data is being set by the backend versus how the frontend is reading it.

  7. 13 remaining items

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 12, 2026
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 12, 2026
  10. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

  11. changed the title [-]Expense-Mark as paid button is not shown for the IOU receiver.[/-] [+][$250] Expense-Mark as paid button is not shown for the IOU receiver.[/+] on Mar 12, 2026
  12. melvin-bot commented on Mar 12, 2026

    @melvin-bot
  13. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 12, 2026
  14. melvin-bot commented on Mar 12, 2026

    @melvin-bot

    📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  15. jliexpensify commented on Mar 12, 2026

    @jliexpensify
    Contributor

    Sorry @suneox - just needed automation to create an Upworks job

  16. jliexpensify commented on Mar 12, 2026

    @jliexpensify
    Contributor

    Payment Summary

    Please accept: Upwork job

  17. situchan commented on Mar 30, 2026

    @situchan
    Contributor

    @jliexpensify I accepted offer

  18. jliexpensify commented on Mar 30, 2026

    @jliexpensify
    Contributor

    Paid and job closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions