Skip to content

[$250] Expense - Tax rate changes to default rate 0% after adding unreported expense to expense report #82051

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.16-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78358
Email or phone of affected tester (no customers): sjdoisjnodjsojdinsoi@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Enable Taxes in workspace settings > More features.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Create an expense with 5% tax rate.
  4. Go to workspace chat.
  5. Create an empty report.
  6. On the empty report, click Add expense > Add unreported expense.
  7. Select the self DM expense from Step 3 > Add to report.
  8. Open the expense report.

Expected Result:

Tax rate should remain unchanged - 5% rate.

Actual Result:

Tax rate changes to default rate 0% after adding unreported expense to expense report.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7073807_1770742277658.19.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @jayeshmangwani
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022021332581426929860
  • Upwork Job ID: 2021332581426929860
  • Last Price Increase: 2026-02-17

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 10, 2026
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 10, 2026
  3. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

  4. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. changed the title [-]Expense - Tax rate changes to default rate 0% after adding unreported expense to expense report[/-] [+][$250] Expense - Tax rate changes to default rate 0% after adding unreported expense to expense report[/+] on Feb 10, 2026
  6. melvin-bot commented on Feb 10, 2026

    @melvin-bot
  7. abbasifaizan70 commented on Feb 10, 2026

    @abbasifaizan70
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Tax Rate Should Remain 5% After Adding Unreported Expense to Expense Report


    What is the root cause of that problem?

    When the expense is moved from self DM to the workspace report, the transaction can contain a taxCode that does not exist in the destination policy tax list.

    In MoneyRequestView, the tax label is derived with getTaxName(policy, transaction, isExpenseUnreported).

    • For many expense reports, isExpenseUnreported is false.
    • This disables fallback to the transaction's stored taxValue.
    • When taxCode is not found in destination policy taxes, UI resolves tax display through destination defaults (often 0%) instead of preserving the original transaction tax value (5%).

    So the tax appears reset even though transaction-level tax data should be preserved.

    : convertToDisplayString(Math.abs(transactionTaxAmount ?? 0), transactionCurrency);
    const taxRatesDescription = taxRates?.name;
    const taxRateTitle = updatedTransaction ? getTaxName(policy, updatedTransaction, isExpenseUnreported) : getTaxName(policy, transaction, isExpenseUnreported);
    const actualTransactionDate = isFromMergeTransaction && updatedTransaction ? getFormattedCreated(updatedTransaction) : transactionDate;
    const fallbackTaxRateTitle = transaction?.taxValue;


    What changes do you think we should make in order to solve the problem?

    Proposed solution:
    Always allow getTaxName() fallback behavior in MoneyRequestView for this display path by passing true as the third argument.

    This ensures:

    • If taxCode exists in destination policy, we show that mapped tax normally.
    • If taxCode does not exist in destination policy (move from self DM case), we fall back to transaction taxValue (e.g. 5%) instead of showing the policy default (0%).

    This is a minimal and localized UI fix in one TypeScript file.


    Change - Preserve transaction tax value fallback in MoneyRequestView

    : convertToDisplayString(Math.abs(transactionTaxAmount ?? 0), transactionCurrency);
    const taxRatesDescription = taxRates?.name;
    const taxRateTitle = updatedTransaction ? getTaxName(policy, updatedTransaction, isExpenseUnreported) : getTaxName(policy, transaction, isExpenseUnreported);
    const actualTransactionDate = isFromMergeTransaction && updatedTransaction ? getFormattedCreated(updatedTransaction) : transactionDate;
    const fallbackTaxRateTitle = transaction?.taxValue;

    New code (TypeScript):

    const taxRatesDescription = taxRates?.name;
    const taxRateTitle = updatedTransaction ? getTaxName(policy, updatedTransaction, true) : getTaxName(policy, transaction, true);
    
    const actualTransactionDate = isFromMergeTransaction && updatedTransaction ? getFormattedCreated(updatedTransaction) : transactionDate;
    const fallbackTaxRateTitle = transaction?.taxValue;
  8. melvin-bot commented on Feb 10, 2026

    @melvin-bot

    📣 @TALHY50! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  9. github-actions commented on Feb 10, 2026

    @github-actions
    Contributor

    ⚠️ @TALHY50 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  10. TALHY50 commented on Feb 10, 2026

    @TALHY50

    🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

  11. 25 remaining items

  12. s77rt commented on Feb 26, 2026

    @s77rt
    Member

    I was not able to reproduce. Is this still reproducible?

    Screen.Recording.2026-02-26.at.10.04.09.PM.mov
  13. self-assigned this
    on Feb 26, 2026
  14. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 26, 2026
  15. jayeshmangwani commented on Feb 27, 2026

    @jayeshmangwani
    Contributor

    Yes, I’m able to reproduce this issue right now.
    @s77rt , could you please try to reproduce it with a new user? Create a new workspace, enable taxes, and then follow the steps above.

    new-user.mov
  16. s77rt commented on Mar 2, 2026

    @s77rt
    Member

    I was able to reproduce and I think this is expected, when moving an unreported transaction we apply the default tax, and the default reimbursable state to match policy. cc @laurenreidexpensify Can we close?

  17. zhangxue1985122219 commented on Mar 2, 2026

    @zhangxue1985122219

    Hi! I'm interested in working on this tax rate bug. I'm looking into the issue and plan to submit a PR shortly. Thanks!

  18. melvin-bot commented on Mar 2, 2026

    @melvin-bot

    📣 @zhangxue1985122219! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  19. zhangxue1985122219 commented on Mar 2, 2026

    @zhangxue1985122219

    Contributor details:

    Your Expensify account email: zhangxue1985122219@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~5175da01e2562d6b

    Hi! I'm ready to start working on this issue. I've reviewed the requirements and I'm confident I can deliver a clean, well-tested solution quickly.

    Looking forward to receiving the Upwork contract invitation. Thanks!

  20. zhangxue1985122219 commented on Mar 2, 2026

    @zhangxue1985122219

    Contributor details:

    Your Expensify account email: zhangxue1985122219@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~5175da01e2562d6b

    Hi! I'm ready to start working on this issue. I've reviewed the requirements and I'm confident I can deliver a clean, well-tested solution quickly.

    Looking forward to receiving the Upwork contract invitation. Thanks!

  21. zhangxue1985122219 commented on Mar 2, 2026

    @zhangxue1985122219

    Contributor details:

    Your Expensify account email: zhangxue1985122219@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~01c3dbb5ac9f904d88

    Hi! I'm ready to start working on this issue. I've reviewed the requirements and I'm confident I can deliver a clean, well-tested solution quickly.

    Looking forward to receiving the Upwork contract invitation. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions