You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Expense - Tax rate changes to default rate 0% after adding unreported expense to expense report #82051
Version Number: 9.3.16-4 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#78358 Email or phone of affected tester (no customers):sjdoisjnodjsojdinsoi@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Enable Taxes in workspace settings > More features.
Go to staging.new.expensify.com
Go to self DM.
Create an expense with 5% tax rate.
Go to workspace chat.
Create an empty report.
On the empty report, click Add expense > Add unreported expense.
Select the self DM expense from Step 3 > Add to report.
Open the expense report.
Expected Result:
Tax rate should remain unchanged - 5% rate.
Actual Result:
Tax rate changes to default rate 0% after adding unreported expense to expense report.
changed the title [-]Expense - Tax rate changes to default rate 0% after adding unreported expense to expense report[/-][+][$250] Expense - Tax rate changes to default rate 0% after adding unreported expense to expense report[/+]on Feb 10, 2026
Please re-state the problem that we are trying to solve in this issue.
Tax Rate Should Remain 5% After Adding Unreported Expense to Expense Report
What is the root cause of that problem?
When the expense is moved from self DM to the workspace report, the transaction can contain a taxCode that does not exist in the destination policy tax list.
In MoneyRequestView, the tax label is derived with getTaxName(policy, transaction, isExpenseUnreported).
For many expense reports, isExpenseUnreported is false.
This disables fallback to the transaction's stored taxValue.
When taxCode is not found in destination policy taxes, UI resolves tax display through destination defaults (often 0%) instead of preserving the original transaction tax value (5%).
So the tax appears reset even though transaction-level tax data should be preserved.
What changes do you think we should make in order to solve the problem?
Proposed solution:
Always allow getTaxName() fallback behavior in MoneyRequestView for this display path by passing true as the third argument.
This ensures:
If taxCode exists in destination policy, we show that mapped tax normally.
If taxCode does not exist in destination policy (move from self DM case), we fall back to transaction taxValue (e.g. 5%) instead of showing the policy default (0%).
This is a minimal and localized UI fix in one TypeScript file.
Change - Preserve transaction tax value fallback in MoneyRequestView
📣 @TALHY50! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
⚠️@TALHY50 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
Yes, I’m able to reproduce this issue right now. @s77rt , could you please try to reproduce it with a new user? Create a new workspace, enable taxes, and then follow the steps above.
I was able to reproduce and I think this is expected, when moving an unreported transaction we apply the default tax, and the default reimbursable state to match policy. cc @laurenreidexpensify Can we close?
📣 @zhangxue1985122219! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Activity
melvin-bot commentedon Feb 10, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (
External)melvin-bot commentedon Feb 10, 2026
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Expense - Tax rate changes to default rate 0% after adding unreported expense to expense report[/-][+][$250] Expense - Tax rate changes to default rate 0% after adding unreported expense to expense report[/+]melvin-bot commentedon Feb 10, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022021332581426929860
abbasifaizan70 commentedon Feb 10, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Tax Rate Should Remain 5% After Adding Unreported Expense to Expense Report
What is the root cause of that problem?
When the expense is moved from self DM to the workspace report, the transaction can contain a
taxCodethat does not exist in the destination policy tax list.In
MoneyRequestView, the tax label is derived withgetTaxName(policy, transaction, isExpenseUnreported).isExpenseUnreportedisfalse.taxValue.taxCodeis not found in destination policy taxes, UI resolves tax display through destination defaults (often0%) instead of preserving the original transaction tax value (5%).So the tax appears reset even though transaction-level tax data should be preserved.
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 311 to 318 in 292a97c
What changes do you think we should make in order to solve the problem?
Proposed solution:
Always allow
getTaxName()fallback behavior inMoneyRequestViewfor this display path by passingtrueas the third argument.This ensures:
taxCodeexists in destination policy, we show that mapped tax normally.taxCodedoes not exist in destination policy (move from self DM case), we fall back to transactiontaxValue(e.g.5%) instead of showing the policy default (0%).This is a minimal and localized UI fix in one TypeScript file.
Change - Preserve transaction tax value fallback in MoneyRequestView
App/src/components/ReportActionItem/MoneyRequestView.tsx
Lines 311 to 318 in 292a97c
New code (TypeScript):
melvin-bot commentedon Feb 10, 2026
📣 @TALHY50! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
github-actions commentedon Feb 10, 2026
TALHY50 commentedon Feb 10, 2026
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
25 remaining items
s77rt commentedon Feb 26, 2026
I was not able to reproduce. Is this still reproducible?
Screen.Recording.2026-02-26.at.10.04.09.PM.mov
jayeshmangwani commentedon Feb 27, 2026
Yes, I’m able to reproduce this issue right now.
@s77rt , could you please try to reproduce it with a new user? Create a new workspace, enable taxes, and then follow the steps above.
new-user.mov
s77rt commentedon Mar 2, 2026
I was able to reproduce and I think this is expected, when moving an unreported transaction we apply the default tax, and the default reimbursable state to match policy. cc @laurenreidexpensify Can we close?
zhangxue1985122219 commentedon Mar 2, 2026
Hi! I'm interested in working on this tax rate bug. I'm looking into the issue and plan to submit a PR shortly. Thanks!
melvin-bot commentedon Mar 2, 2026
📣 @zhangxue1985122219! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
zhangxue1985122219 commentedon Mar 2, 2026
Contributor details:
Your Expensify account email: zhangxue1985122219@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~5175da01e2562d6b
Hi! I'm ready to start working on this issue. I've reviewed the requirements and I'm confident I can deliver a clean, well-tested solution quickly.
Looking forward to receiving the Upwork contract invitation. Thanks!
zhangxue1985122219 commentedon Mar 2, 2026
Contributor details:
Your Expensify account email: zhangxue1985122219@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~5175da01e2562d6b
Hi! I'm ready to start working on this issue. I've reviewed the requirements and I'm confident I can deliver a clean, well-tested solution quickly.
Looking forward to receiving the Upwork contract invitation. Thanks!
zhangxue1985122219 commentedon Mar 2, 2026
Contributor details:
Your Expensify account email: zhangxue1985122219@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01c3dbb5ac9f904d88
Hi! I'm ready to start working on this issue. I've reviewed the requirements and I'm confident I can deliver a clean, well-tested solution quickly.
Looking forward to receiving the Upwork contract invitation. Thanks!