Skip to content

Subscription - Semi transparent loading page appears when opening Subscription size page #82096

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.17-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80620
Email or phone of affected tester (no customers): josindjosjdnosdinjdos@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: User Settings

Action Performed:

Precondition:

  • Have a Control workspace.
  1. Go to staging.new.expensify.com
  2. Go to Account > Subscription.
  3. Click Subscription settings.
  4. Click Subscription size.

Expected Result:

No semi transparent loading page will appear when opening Subscription size page.

Actual Result:

Semi transparent loading page appears when opening Subscription size page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 11, 2026
  2. melvin-bot commented on Feb 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #80620

  3. melvin-bot commented on Feb 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Feb 11, 2026

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Feb 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Feb 11, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #80620 - "Refactor subscription size page to use useSubPage hook" by @bernhardoj (High confidence)
    Related Issues: Part of #79043

    Recommendation: ROLL FORWARD

    The loading indicator is intentional behavior of the useSubPage hook refactor, but creates poor UX. Reverting would undo the architectural improvement to URL-based navigation. A quick fix to eliminate the loading delay would be simpler than reverting.

    The fix should either:

    1. Remove the 20-frame delay in useSubPage when redirecting, or
    2. Add logic to skip showing the loading indicator during the brief redirect window

    Labels: No changes needed. Keeping DeployBlockerCash as this is a frontend bug caused by an App PR that needs fixing before the App deploy can proceed.

    📋 Detailed Analysis

    Evidence

    PR #80620 refactored SubscriptionSize/index.tsx from using useSubStep (state-based) to useSubPage (URL-based navigation with subPage parameters).

    Key changes:

    • Switched from useSubStep to useSubPage hook
    • Added route parameter: settings/subscription/subscription-size/:subPage?
    • Added conditional loading indicator: if (isRedirecting || !privateSubscription) { return <FullScreenLoadingIndicator />; }

    Verification

    Files affected by the bug:

    • /home/runner/_work/App/App/src/pages/settings/Subscription/SubscriptionSize/index.tsx (main file changed in PR)
    • /home/runner/_work/App/App/src/hooks/useSubPage/index.tsx (hook that introduces the redirect behavior)

    Confirmed the PR modifies these files:

    src/pages/settings/Subscription/SubscriptionSize/index.tsx
    src/ROUTES.ts
    src/libs/Navigation/types.ts
    src/CONST/index.ts
    

    Timeline alignment:

    • PR merged: 2026-02-10 at 14:46:11Z
    • Bug reported: 2026-02-11 at 09:58:24Z
    • Reproducible on staging: Yes
    • Reproducible on production: No

    This confirms the bug appeared immediately after PR #80620 was deployed to staging.

    Root Cause

    The useSubPage hook (lines 24-46 in /home/runner/_work/App/App/src/hooks/useSubPage/index.tsx) implements a redirect mechanism:

    1. When navigating to the base route without a subPage parameter, it detects this condition:

      const isRedirecting = !urlPageName && !!startPageName;
    2. When isRedirecting is true, it waits 20 animation frames (~333ms at 60fps) before redirecting:

      const AMOUNT_OF_FRAMES_TO_WAIT_FOR = 20;
      // ... waits frames then calls:
      Navigation.navigate(buildRoute(startPageName), {forceReplace: true});
    3. During this wait, the SubscriptionSize page shows the loading indicator:

      if (isRedirecting || !privateSubscription) {
          return <FullScreenLoadingIndicator />;
      }

    Why the old code didn't have this issue:
    The previous useSubStep hook was entirely state-based with no URL parameters, so there was no redirect delay or need for a loading indicator.

  7. lakchote commented on Feb 11, 2026

    @lakchote
    Contributor

    coming from #80620 cc @bernhardoj

  8. arosiclair commented on Feb 11, 2026

    @arosiclair
    Contributor

    I reproduced in staging v9.3.17-1 and not in prod v9.3.16-9

  9. arosiclair commented on Feb 11, 2026

    @arosiclair
    Contributor

    @bernhardoj @dukenv0307 are you online to take a look? I'll prep a revert in the meantime if that's needed.

  10. arosiclair commented on Feb 11, 2026

    @arosiclair
    Contributor

    We're CPing the revert

  11. arosiclair commented on Feb 11, 2026

    @arosiclair
    Contributor

    Fixed in v9.3.17-5

  12. m-natarajan commented on Feb 11, 2026

    @m-natarajan

    Not reproduce, Chrome / 9.3.17-5

    Screen.Recording.2026-02-11.at.18.06.48.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions