You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reports - Filters are still applied after being cleared and returning to the same section. #82101
Version Number: 9.3.17.0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/test-runs/TR-4999/folder/13176922/41237512/1183038400 Email or phone of affected tester (no customers):ibellicotest+2250@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Search
Action Performed:
Open the staging.new.expensify.com website.
Open any DM. (For example: Self DM)
Send a message.
Tap on the search icon and select the option to search within the chat.
Search for the sent message.
Once redirected to results, use device´s back button to return to chat,
Navigate to "Reports"
Note that you land on "Chats" with the search still applied.
Tap on "Filters" > "Reset Filters" > "View Results"
Note that filters are cleared and you land on "Expenses"
Return to "Chats"
Note that cleared filters are still applied despite being cleared.
Expected Result:
After clearing filters, it shouldn´t be reapplied when returning to the same section.
Actual Result:
After clearing filters and returning to the same section, filters are still applied.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #80247 - "Fix/79139 - Add sticky filters to the reports page" by @dmkt9 (High confidence) Related Issues: #79139
Recommendation: REVERT
PR #80247 introduces a sticky filters feature that persists filter values across different search types (Expenses/Reports/Chats). However, it uses module-level state that is not properly synchronized with the Onyx store when filters are reset.
The root cause is that useStickySearchFilters maintains persistent state in module-level variables (allSearchAdvancedFilters and prevSearchAdvancedFiltersFormsByType) that survive component unmounts and are not cleared when clearAdvancedFilters() resets the Onyx data. When users navigate between search types after clearing filters, the stale cached values are reapplied.
Labels: Keeping DeployBlockerCash (blocks App deploy). Removing DeployBlocker as this is a frontend-only bug that requires changes to the App repository.
However, the module-level cache in useStickySearchFilters is never cleared. On the next navigation between search types (step 11 in reproduction: "Return to Chats"), the hook reads from its stale cache and reapplies the supposedly-cleared filters via updateQueryStringOnSearchTypeChange().
The bug manifests because:
User applies filters on "Chats"
Module-level cache stores these filters
User clicks "Reset Filters" - only Onyx is updated, cache remains
User navigates to "Expenses" then back to "Chats"
Hook reads from stale cache and reapplies cleared filters
Not repro,Windows 11 / Chrome, v9.3.17-5 and Not repro, Samsung A52 / Android 14 v9.3.17-5, but in step 7 when navigating to "Reports", the filter is auto reset.
Activity
melvin-bot commentedon Feb 11, 2026
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Feb 11, 2026
Triggered auto assignment to @srikarparsi (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Feb 11, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Feb 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
joekaufmanexpensify commentedon Feb 11, 2026
Hm, yeah this is only happening on staging. Not a huge issue, but we should definitely fix it.
OSBotify commentedon Feb 11, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #80247 - "Fix/79139 - Add sticky filters to the reports page" by @dmkt9 (High confidence)
Related Issues: #79139
Recommendation: REVERT
PR #80247 introduces a sticky filters feature that persists filter values across different search types (Expenses/Reports/Chats). However, it uses module-level state that is not properly synchronized with the Onyx store when filters are reset.
The root cause is that
useStickySearchFiltersmaintains persistent state in module-level variables (allSearchAdvancedFiltersandprevSearchAdvancedFiltersFormsByType) that survive component unmounts and are not cleared whenclearAdvancedFilters()resets the Onyx data. When users navigate between search types after clearing filters, the stale cached values are reapplied.Labels: Keeping
DeployBlockerCash(blocks App deploy). RemovingDeployBlockeras this is a frontend-only bug that requires changes to the App repository.Detailed Analysis
Evidence
Verification
The PR modifies the following files related to the bug:
/home/runner/_work/App/App/src/hooks/useStickySearchFilters.ts(NEW) - Introduces module-level state for sticky filters/home/runner/_work/App/App/src/libs/SearchUIUtils.ts- AddsupdateQueryStringOnSearchTypeChange()function/home/runner/_work/App/App/src/pages/Search/SearchTypeMenu.tsx- Applies sticky filters on navigation/home/runner/_work/App/App/src/hooks/useSearchTypeMenu.tsx- Integrates sticky filters hookRoot Cause
The
useStickySearchFiltershook uses module-level variables to cache filter state:When
clearAdvancedFilters()is called in/home/runner/_work/App/App/src/libs/actions/Search.ts, it updates the Onyx store via:However, the module-level cache in
useStickySearchFiltersis never cleared. On the next navigation between search types (step 11 in reproduction: "Return to Chats"), the hook reads from its stale cache and reapplies the supposedly-cleared filters viaupdateQueryStringOnSearchTypeChange().The bug manifests because:
lakchote commentedon Feb 11, 2026
cc @dmkt9 seems to be coming from #80247
m-natarajan commentedon Feb 11, 2026
Not repro,Windows 11 / Chrome, v9.3.17-5 and Not repro, Samsung A52 / Android 14 v9.3.17-5, but in step 7 when navigating to "Reports", the filter is auto reset.
filter.andro.mp4
filter.mp4