You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Distance - "Please fix the distance rate error" is shown when new rate is selected for splits #82122
Version Number: 9.3.17-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#79099 Email or phone of affected tester (no customers):sjoidnjsidjnosnjisjio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Workspace has at least two distance rates.
Go to staging.new.expensify.com
Go to workspace chat.
Create a distance expense.
Go to workspace settings > Distance rates.
Delete the rate used in Step 3.
Open the distance expense.
Click More > Split.
Open any split > click Rate > select the available rate > click Save.
Repeat Step 8 for the other split.
Click Save.
Expected Result:
User should be able to split the distance expense because new rate is selected for each split.
Actual Result:
"Please fix the distance rate error" is shown when new rate is selected for each split.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #79099 - "Handle the Distance and Rate fields for splits" by @ZhenjaHorbach (High confidence) Related Issues: None
Recommendation: REVERT
PR #79099 introduced the ability to edit distance and rate fields for split expenses, but has a critical bug in the validation logic that blocks users from saving splits even after selecting valid rates.
Labels: Removed DeployBlocker (backend label not applicable). Kept DeployBlockerCash (App deploy is blocked).
📋 Detailed Analysis
Evidence
PR #79099 was merged on 2026-02-10 and added distance/rate editing functionality for split expenses. The issue reproduction steps directly involve the new feature (editing distance rate on splits), and the error message splitExpenseDistanceErrorModalDescription was added in this PR.
Verification
The bug occurs in the split expense flow added by PR #79099:
The error condition hasCustomUnitOutOfPolicyViolation is checked in SplitExpensePage.tsx:140-141
Root Cause
When a user selects a new valid rate for each split expense, the individual split items in the splitExpenses array get updated with the new customUnitRateID. However, the parent transaction still retains the old (deleted) rate ID in its customUnit.customUnitRateID field.
The violation check in SplitExpensePage.tsx line 140 checks violations on the parent transaction:
The CUSTOM_UNIT_OUT_OF_POLICY violation is set in ViolationsUtils.ts when a transaction has a customUnitRateID that doesnt exist in the policys distance rates (line 371-383). Since the parent transaction still has the deleted rate ID, the violation persists even though all child splits have been updated with valid rates.
Expected behavior: When all split expenses have valid rates, the save should succeed. Actual behavior: The validation checks the parent transactions rate (which is deleted) instead of checking if all splits have valid rates.
This is a logic error introduced by PR #79099 where the validation was not updated to account for the new split-level distance rate editing feature.
Activity
melvin-bot commentedon Feb 11, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #79099
melvin-bot commentedon Feb 11, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 11, 2026
Triggered auto assignment to @heyjennahay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 11, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #79099 - "Handle the Distance and Rate fields for splits" by @ZhenjaHorbach (High confidence)
Related Issues: None
Recommendation: REVERT
PR #79099 introduced the ability to edit distance and rate fields for split expenses, but has a critical bug in the validation logic that blocks users from saving splits even after selecting valid rates.
Labels: Removed
DeployBlocker(backend label not applicable). KeptDeployBlockerCash(App deploy is blocked).📋 Detailed Analysis
Evidence
PR #79099 was merged on 2026-02-10 and added distance/rate editing functionality for split expenses. The issue reproduction steps directly involve the new feature (editing distance rate on splits), and the error message
splitExpenseDistanceErrorModalDescriptionwas added in this PR.Verification
The bug occurs in the split expense flow added by PR #79099:
src/pages/iou/SplitExpensePage.tsx,src/libs/actions/IOU/Split.ts,src/pages/iou/SplitExpenseEditPage.tsxhasCustomUnitOutOfPolicyViolationis checked inSplitExpensePage.tsx:140-141Root Cause
When a user selects a new valid rate for each split expense, the individual split items in the
splitExpensesarray get updated with the newcustomUnitRateID. However, the parent transaction still retains the old (deleted) rate ID in itscustomUnit.customUnitRateIDfield.The violation check in
SplitExpensePage.tsxline 140 checks violations on the parent transaction:The
CUSTOM_UNIT_OUT_OF_POLICYviolation is set inViolationsUtils.tswhen a transaction has acustomUnitRateIDthat doesnt exist in the policys distance rates (line 371-383). Since the parent transaction still has the deleted rate ID, the violation persists even though all child splits have been updated with valid rates.Expected behavior: When all split expenses have valid rates, the save should succeed.
Actual behavior: The validation checks the parent transactions rate (which is deleted) instead of checking if all splits have valid rates.
This is a logic error introduced by PR #79099 where the validation was not updated to account for the new split-level distance rate editing feature.
lakchote commentedon Feb 11, 2026
coming from #79099 cc @ZhenjaHorbach
IuliiaHerets commentedon Feb 11, 2026
@lakchote Chrome / v9.3.17-6
Impossible to split the expense if the rate was deleted. Need to choose a new rate before the split
Screen.Recording.2026-02-11.at.21.26.20.mp4
lakchote commentedon Feb 11, 2026
This is expected with the revert of #79099
Krishna2323 commentedon Feb 12, 2026
@lakchote could you please re-open one of the blockers for payments? I reviewed the revert PR. Thanks!