Repository navigation
[HOLD for payment 2022-11-16] [$250] [Image] Cant Share attachments between 40-49 mb - reported by @Tushu17 #8235
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to chat
- Select Actions -> Add attachment
- Add an around 45 mb video/file (file in tread)
Expected Result:
Error should be shown immediately since the limit of the file we can at the moment process is 25MB. Let's not have the user wait for the upload if we know it cannot succeed.
Actual Result:
Attachment kept loading until you refresh the page, attachment disappears after refreshing.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.1.43-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
VID_374491118_125842_369.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644521208448039
Activity
melvin-bot commentedon Mar 19, 2022
Triggered auto assignment to @mallenexpensify (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.mallenexpensify commentedon Mar 21, 2022
Well... that is a weird one, nice catch @Tushu17
I was able to reproduce, got this is logs
The pdf file @Tushu17 was using is here in slack
If/when we fix this, it'd be great to know why it's happening and to make sure we fix it for all file sizes.
melvin-bot commentedon Mar 21, 2022
Triggered auto assignment to @marcochavezf (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.marcochavezf commentedon Mar 22, 2022
Marking this issue as internal, because the logs show that there's a size issue on backend:
141 remaining items
trjExpensify commentedon Nov 15, 2022
As in, that explains why it was likely done incorrectly, but nevertheless it's the "offending" PR?
Awesome, thanks for adding this!
mountiny commentedon Nov 16, 2022
It is technically, yes.
flodnv commentedon Nov 16, 2022
Hm? This PR did not introduce the 50MB...
mountiny commentedon Nov 16, 2022
:ohnothing:
Colours were never my strength
mountiny commentedon Nov 16, 2022
This is the PR which introduced it https://github.com/Expensify/App/pull/4269/files, back in bronze age I believe, judging based off the number of annual rings.
trjExpensify commentedon Nov 16, 2022
Cool, taken care of all the items on the checklist including paying everyone out. Discussion posted here. Will reopen if something comes of that. Thanks everyone! 🎉
trjExpensify commentedon Nov 17, 2022
@Santhosh-Sellavel reminded me that this PR was raised after Nov 4th and was merged on Nov 7th, so we owe @Tushu17 & @Santhosh-Sellavel a $125 bonus each. Offers have been sent here: https://www.upwork.com/jobs/~010f6b384191b40d0c
michaelhaxhiu commentedon Nov 17, 2022
Nice work on getting this one finalized everyone!
trjExpensify commentedon Nov 17, 2022
Cool, done!