Skip to content

[Due for payment 2026-03-16] [Due for payment 2026-03-11] [$250] [Performance] Optimize ExpenseReportListItemRow (~1.2ms × 50 = 60ms total) #82428

Closed

Description

@luacmartins

Problem

ExpenseReportListItemRow takes ~1.2ms per render and with ~50 rows totals ~60ms, contributing to slow Reports list rendering.

Solution

Optimize the component (e.g. memoization, virtualized list tuning, or reducing work per row). Use React Profiler / Chrome DevTools to validate improvements.

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022026125717306599670
  • Upwork Job ID: 2026125717306599670
  • Last Price Increase: 2026-02-24

Activity

  1. self-assigned this
    on Feb 13, 2026
  2. jmusial commented on Feb 18, 2026

    @jmusial
    Contributor

    I'll look into this one.

  3. luacmartins commented on Feb 18, 2026

    @luacmartins
    ContributorAuthor

    Nice! This is a big one! Let me know if you need any help. From what I could tell, ActionCell seems like a heavy component. Maybe one thing we can explore is to move all logic in the cell components to the getSections function and compute everything there instead of in each row. Not sure how feasible/performant that is though, just a thought

  4. jmusial commented on Feb 19, 2026

    @jmusial
    Contributor

    Yeah, was looking mostly into getting logic out of each row & Action Cell. It produces really small (-2-3 % for the SearchList component render time) improvements so digging deeper.
    Also trying to find a reliable & cost effective way of evaluating the changes. Getting a full trace every time makes the process super slow and it's prone to fluctuations 😢

  5. luacmartins commented on Feb 19, 2026

    @luacmartins
    ContributorAuthor

    Nice, seems like you're on to something. Yea, the traces are slow. I'm using the React profiler locally to compare results, but in a smaller account since the large one constantly freezes/crashes my tabs.

  6. jmusial commented on Feb 20, 2026

    @jmusial
    Contributor

    Yup, I started using Profiler component for initial measurements, it speeds things up

  7. jmusial commented on Feb 20, 2026

    @jmusial
    Contributor

    @luacmartins added a draft PR with a small improvement let me know what do you think.

  8. jmusial commented on Feb 23, 2026

    @jmusial
    Contributor

    PR published. Added performance results for applausetester@applause.expensifail.com account.

  9. 62 remaining items

  10. CortneyOfstad commented on Mar 16, 2026

    @CortneyOfstad
    Contributor

    Bump @eVoloshchak to complete the checklist today so there is not a delay in issuing payment. Thank you!

  11. eVoloshchak commented on Mar 16, 2026

    @eVoloshchak
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A, this is a feature request

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: regression wasn't critical

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    This was a performance optimisation, so there is no bug to test. We could include the test steps we used to test the PR's, but they simply check normal scenarios, which should already be covered in existing regression tests

    Do we agree 👍 or 👎

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Do we agree 👍 or 👎

  12. melvin-bot commented on Mar 16, 2026

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  13. melvin-bot commented on Mar 16, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @eVoloshchak owed $250 via NewDot
    • Contributor: @jmusial does not require payment (Contractor)

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/2026125717306599670/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. mallenexpensify commented on Mar 18, 2026

    @mallenexpensify
    Contributor
  15. eVoloshchak commented on Mar 18, 2026

    @eVoloshchak
    Contributor
  16. mallenexpensify commented on Mar 19, 2026

    @mallenexpensify
    Contributor

    @luacmartins can you confirm the above for payment? I'm assuming they're all the standard $250 ($125 for the regression), looks like tests were done on 'em. Thx

  17. luacmartins commented on Mar 19, 2026

    @luacmartins
    ContributorAuthor

    That's correct!

  18. mallenexpensify commented on Mar 23, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @eVoloshchak due $875 via NewDot

    Thx!

  19. trjExpensify commented on Mar 26, 2026

    @trjExpensify
    Contributor

    approved $875 for @eVoloshchak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions