You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-16] [Due for payment 2026-03-11] [$250] [Performance] Optimize ExpenseReportListItemRow (~1.2ms × 50 = 60ms total) #82428
ExpenseReportListItemRow takes ~1.2ms per render and with ~50 rows totals ~60ms, contributing to slow Reports list rendering.
Solution
Optimize the component (e.g. memoization, virtualized list tuning, or reducing work per row). Use React Profiler / Chrome DevTools to validate improvements.
Issue OwnerCurrent Issue Owner: @mallenexpensifyUpwork Automation - Do Not Edit
Nice! This is a big one! Let me know if you need any help. From what I could tell, ActionCell seems like a heavy component. Maybe one thing we can explore is to move all logic in the cell components to the getSections function and compute everything there instead of in each row. Not sure how feasible/performant that is though, just a thought
Yeah, was looking mostly into getting logic out of each row & Action Cell. It produces really small (-2-3 % for the SearchList component render time) improvements so digging deeper.
Also trying to find a reliable & cost effective way of evaluating the changes. Getting a full trace every time makes the process super slow and it's prone to fluctuations 😢
Nice, seems like you're on to something. Yea, the traces are slow. I'm using the React profiler locally to compare results, but in a smaller account since the large one constantly freezes/crashes my tabs.
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A, this is a feature request
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: regression wasn't critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
This was a performance optimisation, so there is no bug to test. We could include the test steps we used to test the PR's, but they simply check normal scenarios, which should already be covered in existing regression tests
Do we agree 👍 or 👎
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
@luacmartins can you confirm the above for payment? I'm assuming they're all the standard $250 ($125 for the regression), looks like tests were done on 'em. Thx
Activity
jmusial commentedon Feb 18, 2026
I'll look into this one.
luacmartins commentedon Feb 18, 2026
Nice! This is a big one! Let me know if you need any help. From what I could tell,
ActionCellseems like a heavy component. Maybe one thing we can explore is to move all logic in the cell components to thegetSectionsfunction and compute everything there instead of in each row. Not sure how feasible/performant that is though, just a thoughtjmusial commentedon Feb 19, 2026
Yeah, was looking mostly into getting logic out of each row & Action Cell. It produces
really small(-2-3 % for the SearchList component render time) improvements so digging deeper.Also trying to find a reliable & cost effective way of evaluating the changes. Getting a full trace every time makes the process super slow and it's prone to fluctuations 😢
luacmartins commentedon Feb 19, 2026
Nice, seems like you're on to something. Yea, the traces are slow. I'm using the React profiler locally to compare results, but in a smaller account since the large one constantly freezes/crashes my tabs.
jmusial commentedon Feb 20, 2026
Yup, I started using Profiler component for initial measurements, it speeds things up
jmusial commentedon Feb 20, 2026
@luacmartins added a draft PR with a small improvement let me know what do you think.
jmusial commentedon Feb 23, 2026
PR published. Added performance results for
applausetester@applause.expensifail.comaccount.62 remaining items
CortneyOfstad commentedon Mar 16, 2026
Bump @eVoloshchak to complete the checklist today so there is not a delay in issuing payment. Thank you!
eVoloshchak commentedon Mar 16, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A, this is a feature request
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: regression wasn't critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
This was a performance optimisation, so there is no bug to test. We could include the test steps we used to test the PR's, but they simply check normal scenarios, which should already be covered in existing regression tests
Do we agree 👍 or 👎
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Do we agree 👍 or 👎
melvin-bot commentedon Mar 16, 2026
Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Mar 16, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Mar 18, 2026
@eVoloshchak please confirm there is/isn't a regression
eVoloshchak commentedon Mar 18, 2026
It is a regression, my bad, incorrectly expected the "deploy blocker" messages to be cross-posted from PR's to this issue automatically
This has consisted of 4 PR's in total
mallenexpensify commentedon Mar 19, 2026
@luacmartins can you confirm the above for payment? I'm assuming they're all the standard $250 ($125 for the regression), looks like tests were done on 'em. Thx
luacmartins commentedon Mar 19, 2026
That's correct!
mallenexpensify commentedon Mar 23, 2026
Payment Summary
Contributor+: @eVoloshchak due $875 via NewDot
Thx!
trjExpensify commentedon Mar 26, 2026
approved $875 for @eVoloshchak