Skip to content

[Due for payment 2026-03-04] [Domain control] [Release 3.1] - Bug: 2FA code validation errors on domain settings show RBR instead of error message only under the form input #82445

Closed

Description

@rayane-d

Part of #76750, #80126


Slack discussion: https://expensify.slack.com/archives/C0A1VKRKEE9/p1770300407332069

Problem

When a domain admin with 2FA enabled attempts to disable the "Force two-factor authentication" domain setting and enters an invalid 2FA code, the error (e.g., "Invalid code") is displayed both under the 2FA code form input and as a Red Brick Road (RBR) indicator in the domain members settings.

The expected behavior is:

  • 2FA code form errors should only appear under the 2FA code form input as a form validation error without RBR in the domain settings
  • Domain-level 2FA settings errors should appear as RBR in the domain settings

This happens because all errors from ToggleTwoFactorAuthRequiredForDomain are currently routed to a single Onyx key (domainErrors_<domainAccountID>.setTwoFactorAuthRequiredError), which is read by both the 2FA toggle settings page and the 2FA form page.

Solution

The fix requires splitting the error routing so that 2FA code validation errors go to a new Onyx key, and updating the frontend form page to read from it. The same split applies to SetTwoFactorAuthExemptEmailForDomain command.

Issue OwnerCurrent Issue Owner: @rayane-d

Activity

  1. rayane-d commented on Feb 13, 2026

    @rayane-d
    Author
  2. rayane-d commented on Feb 17, 2026

    @rayane-d
    ContributorAuthor

    Web-E PR is merged. pending deploy.

  3. rayane-d commented on Feb 19, 2026

    @rayane-d
    ContributorAuthor

    Update:

    • Web-E PR on production
    • App PR is no longer on hold and is ready for review
  4. rayane-d commented on Feb 23, 2026

    @rayane-d
    ContributorAuthor

    Updated: App PR merged, pending deploy

  5. rayane-d commented on Feb 24, 2026

    @rayane-d
    ContributorAuthor

    closing for now

  6. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 25, 2026
  7. changed the title [-][Domain control] [Release 3.1] - Bug: 2FA code validation errors on domain settings show RBR instead of error message only under the form input[/-] [+][Due for payment 2026-03-04] [Domain control] [Release 3.1] - Bug: 2FA code validation errors on domain settings show RBR instead of error message only under the form input[/+] on Feb 25, 2026
  8. melvin-bot commented on Feb 25, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Feb 25, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.25-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-04. 🎊

    For reference, here are some details about the assignees on this issue:

    • @war-in does not require payment (Contractor)
    • @ZhenjaHorbach requires payment through NewDot Manual Requests
    • @rayane-d does not require payment (Contractor)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions