Skip to content

Wallet-Character limit error is not shown for sanskrit characters in personal card name field #82487

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.3.18-7
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #81899 (comment)
Email or phone of affected tester (no customers): Applausetester+bw@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Redminote 10S Android 13
App Component: User Settings

Action Performed:

Pre-condition: Login with an expensifail account with an Expensify card added (virtual)

  1. Launch app
  2. Go to workspace settings
  3. Tap Expensify card
  4. Note blank issue card state is shown briefly before displaying cards added
  5. Tap on a card added
  6. Tap edit card name -महामन्त्रस्य, वशिन्यादि वाग्देवता ऋषयः, अनुष्टुप् छन्दः, श्री ललिता पराभट्टारिका महा त्रिपुर सुन्दर
  7. Tap save
  8. Note error for character is shown for 100 character limit
  9. Go to wallet
  10. Tap import transaction
  11. Tap card name
  12. Enter name used in step 6 and save
  13. Note no character limit error is shown
  14. Now enter any alphabets more than 100 to trigger error
    applausetester+vsca@applause.expensifail.comapplausetester+vsca@applause.expensapplausetester+vsca@applause.expensifail.comifail.com
    and save
  15. Note 100 character limit error

Expected Result:

Character limit error must be shown for sanskrit characters in personal card name field.

Blank issue card state must not be shown briefly before displaying cards added.

Actual Result:

Character limit error is not shown for sanskrit characters in personal card name field.

Blank issue card state is shown briefly before displaying cards added.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7077014_1770998411293.Screenrecorder-2026-02-13-21-20-57-789.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 14, 2026
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 14, 2026
  3. melvin-bot commented on Feb 14, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  4. melvin-bot commented on Feb 14, 2026

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot commented on Feb 14, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  6. truph01 commented on Feb 14, 2026

    @truph01
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2026-02-14 13:08:38 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • Character limit error is not shown for sanskrit characters in personal card name field.

    What is the root cause of that problem?

    1. Blank issue card state is shown briefly before displaying cards added.
    • In here we don't have logic to show the loading indicator when the card data is loading while the cardsList is empty.
    1. Character limit error is not shown for sanskrit characters in personal card name field.

    What changes do you think we should make in order to solve the problem?

    1. Blank issue card state is shown briefly before displaying cards added.
    • We should show the loading indicator in here if the data is loading and the cardsList is empty isLoading && isEmptyObject(cardsList). isLoading comes from here.
    1. Character limit error is not shown for sanskrit characters in personal card name field.
                const {isValid, byteLength} = isValidInputLength(name, CONST.TITLE_CHARACTER_LIMIT);
    
                if (!isValid) {
                    addErrorMessage(errors, 'cardDisplayName', translate('common.error.characterLimitExceedCounter', byteLength, CONST.TITLE_CHARACTER_LIMIT));
                }
    

    What alternative solutions did you explore? (Optional)

  7. lorretheboy commented on Feb 16, 2026

    @lorretheboy
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2026-02-16 09:37:53 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Wallet-Character limit error is not shown for sanskrit characters in personal card name field

    What is the root cause of that problem?

    Bug 1: No character limit error for Sanskrit characters in import transaction card name

    We use Unicode code point counting via spread syntax here. Sanskrit/Devanagari characters are 3 bytes each in UTF-8. So the test string महामन्त्रस्य, वशिन्यादि वाग्देवता... has fewer than limit

    if ([...name].length > CONST.TITLE_CHARACTER_LIMIT) {
    addErrorMessage(errors, 'cardDisplayName', translate('common.error.characterLimitExceedCounter', [...name].length, CONST.TITLE_CHARACTER_LIMIT));
    }

    Bug 2: Blank issue card state flashes briefly

    The loading indicator here is only shown when there's no paymentBankAccountID, even if card data is still being fetched

    const renderContent = () => {
    if (!!isLoading && !paymentBankAccountID) {
    return (

    What changes do you think we should make in order to solve the problem?

    Bug 1: We need to replace code-point-based validation with byte-length validation to match all other card name pages

                if (name) {
                    const {isValid, byteLength} = isValidInputLength(name, CONST.STANDARD_LENGTH_LIMIT);
                    if (!isValid) {
                        addErrorMessage(errors, 'cardDisplayName', translate('common.error.characterLimitExceedCounter', byteLength, CONST.STANDARD_LENGTH_LIMIT));
                    }
                }

    Bug 2: Update condition to this to ensure the loading indicator is shown when card settings are cached (so paymentBankAccountID is truthy) but cardsList hasn't been fetched yet

            if (isLoading && (!paymentBankAccountID || !cardsList)) {

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  8. github-actions commented on Feb 16, 2026

    @github-actions
    Contributor

    ⚠️ @lorretheboy Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  9. self-assigned this
    on Feb 16, 2026
  10. hoangzinh commented on Feb 17, 2026

    @hoangzinh
    Contributor

    After reviewing the proposals, I believe @truph01 and @lorretheboy have almost identical approaches. Since @truph01 submitted his proposal first, I think we should proceed with his proposal.

    Link to @truph01's proposal #82487 (comment)

    🎀👀🎀 C+ reviewed

  11. 8 remaining items

  12. hoangzinh commented on Mar 24, 2026

    @hoangzinh
    Contributor

    @CortneyOfstad This issue is ready for payment

    cc @carlosmiceli

  13. melvin-bot commented on Apr 16, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @carlosmiceli, @hoangzinh, @CortneyOfstad, @truph01 eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  14. hoangzinh commented on Apr 16, 2026

    @hoangzinh
    Contributor

    @CortneyOfstad @mallenexpensify, this issue is ready for payment

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Apr 20, 2026
  16. melvin-bot commented on Apr 20, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  17. mallenexpensify commented on Apr 20, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @truph01 due $250 via NewDot
    Contributor+: @hoangzinh due $250 via NewDot

    ^ Test case created

    Apologies for the delay, we're hoping to have the bug fixes soon.

  18. laurenreidexpensify commented on Apr 21, 2026

    @laurenreidexpensify
    Contributor

    New Expensify $250 approved for @hoangzinh

  19. garrettmknight commented on May 22, 2026

    @garrettmknight
    Contributor

    $250 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions