Skip to content

[Due for payment 2026-06-01] [$250] Expense-When User A sends a manual and scan expense to User B, IOU avatar is combined #82488

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.19-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13177029/test-cases/41237792
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: MacBook Air 15.7.3 Chrome, iPhone 15 iOS 26.2.1
App Component: Money Requests

Action Performed:

  1. Sign in to ND as User A
  2. Create a chat with User B
  3. Send a manual expense to User B, observe the IOU creator avatar it correctly shows User A's avatar
  4. Send a scan expense in the same chat, observe the avatar

Expected Result:

IOU avatar should show only the expenses creator - User A

Actual Result:

When IOU in 1:1 chat contains manual and scan expense, both creator and receiver avatars are displayed above the report, as if both users created the expenses

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7077408_1771021460453.Avatar_for_3_expenses.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022049638152650238722
  • Upwork Job ID: 2049638152650238722
  • Last Price Increase: 2026-04-29
  • Automatic offers:
    • aimane-chnaif | Reviewer | 111277517

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 14, 2026
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 14, 2026
  3. melvin-bot commented on Feb 14, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

  4. melvin-bot commented on Feb 14, 2026

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot commented on Feb 14, 2026

    @melvin-bot

    Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

  6. added and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 14, 2026
  7. 109 remaining items

  8. MelvinBot commented on May 27, 2026

    @MelvinBot
    Contributor

    The offending PR is #64802 by JakubKorytko (merged 2025-07-09). It introduced the areAmountsSignsTheSame logic using Math.sign(tr.amount) which doesn't account for scan expenses having amount = 0 (Math.sign(0) = 0 is distinct from Math.sign(positive) = 1).

    The fix was deployed via #87961.

  9. aimane-chnaif commented on May 27, 2026

    @aimane-chnaif
    Contributor

    BugZero Checklist:

    Regression Test Proposal

    Test:

    Case 1: OP

    1. Sign in to ND as User A
    2. Create a chat with User B
    3. Send a manual expense to User B, observe the IOU creator avatar; it correctly shows User A's avatar
    4. Send a scan expense in the same chat, and observe the avatar.
    5. Verify that the IOU avatar shows only the expenses creator - User A

    Case 2: Zero Amount Request

    1. Sign in as User A.
    2. Open a 1:1 chat with User B.
    3. Send a manual expense to User B.
    4. Verify the IOU preview shows only User A’s avatar.
    5. In the same chat, send a scan expense to User B.
    6. Make sure the scan is still unresolved, so its amount remains 0.
    7. Verify the IOU preview still shows only User A’s avatar and does not switch to combined avatars.

    Case 3: Clear Cache / iouActions Unavailable

    1. Sign in as User A.
    2. Open a 1:1 chat with User B.
    3. Send a manual expense to User B.
    4. Switch to User B.
    5. In the same chat, send a scan expense to User A.
    6. Make sure the scan is still unresolved so its amount remains 0.
    7. Clear the cache or reload the app.
    8. Reopen the same 1:1 report before all report actions finish loading.
    9. Verify the avatar preview does not incorrectly collapse to a single avatar for this mixed-actor report.

    Case 4: Two Devices

    1. Sign in as User A (web)
    2. Open a 1:1 chat with User B (mobile)
    3. Send a scan expense and wait till the amount updates.
    4. Verify that one single avatar displays
    5. Switch to User B (mobile)
    6. On the same chat, create a scan expense
    7. Wait for the amount updates
    8. Verify the avatar preview does not incorrectly collapse to a single avatar for this mixed-actor report.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-1716-abe0-551b-7f88283d9f24
  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 27, 2026
  11. melvin-bot commented on May 31, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. mallenexpensify commented on Jun 1, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @marufsharifi paid $250 via Upwork
    Contributor+: @aimane-chnaif paid $250 via Upwork

    @marufsharifi can you please accept the job below? Please reply here and tag me once you have.
    If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
    https://www.upwork.com/jobs/~022061586744261678112

    ^ Test case created. Thx

  13. marufsharifi commented on Jun 2, 2026

    @marufsharifi

    @mallenexpensify, I've accepted the offer. thanks.

  14. mallenexpensify commented on Jun 2, 2026

    @mallenexpensify
    Contributor

    @marufsharifi paid, summary updated above. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions