You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[No Payment] Expense - In expensifail account, opening report deleted in offline is loading infinitely #82622
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #79761 - "fix: Deleting a draft report from search deletes the expenses as well." by @daledah (High confidence) Related Issues: #79756
Recommendation: REVERT
The causing PR should be reverted. PR #79761 introduced a critical bug in the offline deletion flow by not passing the hash parameter to deleteAppReport, which prevents the search snapshot from being updated with the pending delete action. This causes reports deleted while offline to load infinitely when opened.
Labels: No label changes made. This is a frontend bug that requires an App PR fix/revert, so DeployBlockerCash correctly remains on this issue.
📋 Detailed Analysis
Evidence
PR #79761 changed the deletion logic for expense reports in the search results page. When deleting expense reports from search results, it now calls deleteAppReport in a loop instead of using bulkDeleteReports.
The Problem: Line 504-512 in src/pages/Search/SearchPage.tsx calls deleteAppReport without passing the hash parameter:
deleteAppReport(report,selfDMReport,currentUserPersonalDetails?.email??,currentUserPersonalDetails?.accountID,validTransactions,allTransactionViolations,bankAccountList,// Missing: hash parameter should be passed here);
In contrast, the else branch (line 518-529) correctly passes hash to bulkDeleteReports.
Verification
The deleteAppReport function in src/libs/actions/Report/index.ts (line 5053-5077) has this critical code:
functiondeleteAppReport(report: OnyxEntry<Report>,selfDMReport: OnyxEntry<Report>,currentUserEmailParam: string,currentUserAccountIDParam: number,reportTransactions: Record<string,Transaction>,allTransactionViolations: OnyxCollection<TransactionViolations>,bankAccountList: OnyxEntry<BankAccountList>,hash?: number,// This parameter is optional but critical for search){// ...// Update search results to mark report as deleted when called from searchif(hash){Onyx.merge(`${ONYXKEYS.COLLECTION.SNAPSHOT}${hash}`,{data: {[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`]: {pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE},},});}// ...}
Without the hash parameter, the search snapshot is never updated to show the report has a pending delete action.
Root Cause
When a user deletes a report while offline:
The report is optimistically marked for deletion in local state
BUT the search snapshot (SNAPSHOT collection in Onyx) is NOT updated because hash was not passed
When the user opens the deleted report, the app tries to load it
The report is in an inconsistent state (marked for deletion locally but not in the search snapshot)
This causes infinite loading because the app cannot reconcile the conflicting states
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
changed the title [-]Expense - In expensifail account, opening report deleted in offline is loading infinitely[/-][+][Due for payment 2026-03-09] Expense - In expensifail account, opening report deleted in offline is loading infinitely[/+]on Mar 16, 2026
changed the title [-][Due for payment 2026-03-09] Expense - In expensifail account, opening report deleted in offline is loading infinitely[/-][+][No Payment] Expense - In expensifail account, opening report deleted in offline is loading infinitely[/+]on Mar 17, 2026
Activity
melvin-bot commentedon Feb 17, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #79761
melvin-bot commentedon Feb 17, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 17, 2026
Triggered auto assignment to @brianlee-expensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 17, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 17, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #79761 - "fix: Deleting a draft report from search deletes the expenses as well." by @daledah (High confidence)
Related Issues: #79756
Recommendation: REVERT
The causing PR should be reverted. PR #79761 introduced a critical bug in the offline deletion flow by not passing the
hashparameter todeleteAppReport, which prevents the search snapshot from being updated with the pending delete action. This causes reports deleted while offline to load infinitely when opened.Labels: No label changes made. This is a frontend bug that requires an App PR fix/revert, so
DeployBlockerCashcorrectly remains on this issue.📋 Detailed Analysis
Evidence
PR #79761 changed the deletion logic for expense reports in the search results page. When deleting expense reports from search results, it now calls
deleteAppReportin a loop instead of usingbulkDeleteReports.The Problem: Line 504-512 in
src/pages/Search/SearchPage.tsxcallsdeleteAppReportwithout passing thehashparameter:In contrast, the else branch (line 518-529) correctly passes
hashtobulkDeleteReports.Verification
The
deleteAppReportfunction insrc/libs/actions/Report/index.ts(line 5053-5077) has this critical code:Without the
hashparameter, the search snapshot is never updated to show the report has a pending delete action.Root Cause
When a user deletes a report while offline:
hashwas not passedImpact
13 remaining items
daledah commentedon Feb 18, 2026
@mountiny @ShridharGoel we have the follow up PR here
melvin-bot commentedon Mar 13, 2026
This issue has not been updated in over 15 days. @chuckdries, @ShridharGoel, @brianlee-expensify eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
chuckdries commentedon Mar 16, 2026
This should be due for payment
brianlee-expensify commentedon Mar 16, 2026
@mountiny based on your previous comment, is this considered a regression?
@ShridharGoel can you fill out the bugzero checklist and confirm whether a regression test is needed for this one?
brianlee-expensify commentedon Mar 16, 2026
deployed to prod on March 2, 2026 (see here) - updating title for payment date of March 9, 2026
[-]Expense - In expensifail account, opening report deleted in offline is loading infinitely[/-][+][Due for payment 2026-03-09] Expense - In expensifail account, opening report deleted in offline is loading infinitely[/+]mountiny commentedon Mar 16, 2026
Yeah seems like it was a follow up to #79761 so no payment?
[-][Due for payment 2026-03-09] Expense - In expensifail account, opening report deleted in offline is loading infinitely[/-][+][No Payment] Expense - In expensifail account, opening report deleted in offline is loading infinitely[/+]