Repository navigation
[HOLD for payment 2022-04-13] [$250] When Spanish is selected as the main language, show translation for Onfido's policy and release page - reported by @thesahindia #8284
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to Preferences and change the language to Español
- Go to workspace > Connect Bank Account
- Connect manually and fill the details
- Fill the company information form and save
- See the footer at Personal Information page
Expected Result:
Links should be in Spanish
Actual Result:
Links are not in Spanish
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.1.43-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1647014935103819
Activity
melvin-bot commentedon Mar 24, 2022
Triggered auto assignment to @miljakljajic (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.thesahindia commentedon Mar 24, 2022
Proposal
We can use
onfidoStep.facialScaninstead ofrequestorStep.onFidoFacialScanApp/src/pages/ReimbursementAccount/RequestorStep.js
Line 239 in 116398b
or we can add the correct translation here -
App/src/languages/es.js
Line 700 in 116398b
I think we should just remove the
onfidoFacialScankey as we already have the same copy with spanish translation atonfidoStep.facialScanmelvin-bot commentedon Mar 24, 2022
Triggered auto assignment to @PauloGasparSv (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.melvin-bot commentedon Mar 25, 2022
Triggered auto assignment to @stephanieelliott (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.25 remaining items
melvin-bot commentedon Apr 6, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.51-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-04-13. 🎊
[-][$250] When Spanish is selected as the main language, show translation for Onfido's policy and release page - reported by @thesahindia[/-][+][HOLD for payment 2022-04-13] [$250] When Spanish is selected as the main language, show translation for Onfido's policy and release page - reported by @thesahindia[/+]stephanieelliott commentedon Apr 14, 2022
Hey @thesahindia @rushatgabhane, please accept the job in Upwork so I can issue payment! https://www.upwork.com/jobs/~0111faeed333d9825d
thesahindia commentedon Apr 15, 2022
Applied ✅
melvin-bot commentedon Apr 18, 2022
@rushatgabhane, @stephanieelliott, @Luke9389 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Luke9389 commentedon Apr 18, 2022
Just looping back around to this. Where are we exactly? Just waiting on payment?
rushatgabhane commentedon Apr 19, 2022
@Luke9389 just waiting on payment
stephanieelliott commentedon Apr 20, 2022
All paid up!