Skip to content

[Due for payment 2026-02-27] Room - Yes and No button show in whisper message different shape #82867

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.22-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-5661/folder/13176685/41236621/1198786884
Email or phone of affected tester (no customers): sdiojnsdjsoidsjod@gmail.co
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Type #hey and send it.

Expected Result:

Yes and No button should show the same shape.

Actual Result:

Yes and No button show different shape, which looks weird.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image https://github.com/user-attachments/assets/e26a670b-4a57-4b44-83fa-e2de9bade1e2

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 18, 2026
  2. melvin-bot commented on Feb 18, 2026

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Feb 18, 2026

    @melvin-bot

    Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Feb 18, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Feb 18, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Feb 18, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: Unable to determine with high confidence
    Related Issues: None identified

    Recommendation: NEEDS INVESTIGATION

    Unable to identify the specific causing PR from the current staging deploy checklist. The issue involves Yes/No buttons showing different shapes in a whisper message when typing "#hey" in a workspace chat. This is clearly a UI rendering issue affecting button styling/border-radius.

    Next Steps:

    1. Need design/frontend engineer to investigate DecisionModal component and Button component styling
    2. Check for any recent changes to button border-radius, padding, or shape properties
    3. Investigate if there are conditional styles being applied differently to the two buttons

    Labels: KEEP both DeployBlockerCash and DeployBlocker labels until the causing PR is identified (this is staging-only and not reproducible on production, so we should be conservative about label removal)

    Detailed Analysis

    Evidence

    • Issue is reproducible on staging (v9.3.22-0) but NOT on production
    • Symptoms: Yes and No buttons in a whisper message display different border shapes
    • Trigger: Typing "#hey" in a workspace chat
    • Platform: MacOS Chrome/Safari
    • Component likely: DecisionModal using Button components

    Investigation Attempts

    Root Cause

    Unable to determine without further investigation. The bug appears to be a styling inconsistency where two Button components rendered in the same modal have different border-radius values applied.

    Why Investigation Failed

    The causing PR may be:

    1. A PR that indirectly affected button styles through theme or StyleUtils changes
    2. A PR with subtle conditional logic affecting button rendering
    3. Part of a larger refactoring that wasnt obvious from PR titles/files
  7. 17 remaining items

  8. Julesssss commented on Feb 19, 2026

    @Julesssss
  9. MelvinBot commented on Feb 19, 2026

    @MelvinBot
  10. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 20, 2026
  11. changed the title [-]Room - Yes and No button show in whisper message different shape[/-] [+][Due for payment 2026-02-27] Room - Yes and No button show in whisper message different shape[/+] on Feb 20, 2026
  12. melvin-bot commented on Feb 20, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Feb 20, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-02-27. 🎊

  14. melvin-bot commented on Feb 20, 2026

    @melvin-bot

    @Julesssss @joekaufmanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. abzokhattab commented on Apr 7, 2026

    @abzokhattab
    Contributor

    Can we open this issue for payment ... i worked on the PR review #83048

    nvm i just found out that its a deployment blocker and the main issue was paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions