You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-02-27] Rules - Unable to save "Description" field by clicking enter as in the rest of the fields. #82891
Version Number: 9.3.22.0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#82438 Email or phone of affected tester (no customers):ibellicotest+2250@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Windows 11 / Chrome App Component: Workspace Settings
Action Performed:
Prerequisite: Account has at least one workspace.
Prerequisite 2: Rules enabled.
Open the staging.new.expensify.com website.
Navigate to "Workspace" > "Rules" > "Add Merchant Rule"
Open "Description" field.
Add any description and click on "Enter" on keyboard to save the changes.
Note that a new line is added instead of the editions being saved.
Expected Result:
Clicking on "Enter" on keyboard after editing "Description" field when creating new merchant rule, should save the editions.
Actual Result:
Clicking on "Enter" on keyboard after editing "Description" field when creating new merchant rule, adds a new line instead of saving the changes. Behaviour is different on other text fields, where clicking enter automatically saves editions.
Behaviour is also different on "Description" field while creating or editing an expense.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
When editing the "Description" field in Rules (Add Merchant Rule), pressing Enter inserts a newline instead of saving/submitting the form, unlike all other text fields in Rules which correctly submit on Enter.
What is the root cause of that problem?
The root cause is in src/components/Rule/TextBase.tsx at lines 86–99. The InputWrapper component is rendered without the shouldSubmitForm prop when isMarkdownEnabled is true.
In src/components/Form/InputWrapper.tsx (lines 31–52), the form submission logic evaluates: when autoGrowHeight={true} (set via autoGrowHeight={isMarkdownEnabled}), the input is treated as effectively multiline (isEffectivelyMultiline=true). For multiline inputs, Enter only submits if shouldSubmitForm && canUseHardwareKeyboard — but since shouldSubmitForm is never passed, this evaluates to false, and Enter inserts a newline instead.
This makes the Description field behave consistently with other description fields in the app. On hardware keyboard devices, Enter will submit the form; on touch-only devices, Enter will still insert a newline (by design, since canUseHardwareKeyboard would be false).
What alternative solutions did you explore? (Optional)
An alternative would be to always pass shouldSubmitForm={true} unconditionally, but tying it to isMarkdownEnabled is semantically cleaner — it ensures the prop is only set when the multiline markdown behavior is active, matching the exact pattern used in the two other description pages.
changed the title [-]Rules - Unable to save "Description" field by clicking enter as in the rest of the fields.[/-][+][Due for payment 2026-02-27] Rules - Unable to save "Description" field by clicking enter as in the rest of the fields.[/+]on Feb 20, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins@NicMendonca The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Feb 19, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #82438
melvin-bot commentedon Feb 19, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 19, 2026
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 19, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
twilight2294 commentedon Feb 19, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When editing the "Description" field in Rules (Add Merchant Rule), pressing Enter inserts a newline instead of saving/submitting the form, unlike all other text fields in Rules which correctly submit on Enter.
What is the root cause of that problem?
The root cause is in
src/components/Rule/TextBase.tsxat lines 86–99. TheInputWrappercomponent is rendered without theshouldSubmitFormprop whenisMarkdownEnabledistrue.In
src/components/Form/InputWrapper.tsx(lines 31–52), the form submission logic evaluates: whenautoGrowHeight={true}(set viaautoGrowHeight={isMarkdownEnabled}), the input is treated as effectively multiline (isEffectivelyMultiline=true). For multiline inputs, Enter only submits ifshouldSubmitForm && canUseHardwareKeyboard— but sinceshouldSubmitFormis never passed, this evaluates tofalse, and Enter inserts a newline instead.Other fields in Rules (Merchant, RenameMerchant, etc.) don't pass
isMarkdownEnabled, so they aren't treated as multiline and submit correctly by default. Two other description fields in the app —src/pages/iou/request/step/IOURequestStepDescription.tsx(line 216) andsrc/pages/Search/SearchEditMultiple/SearchEditMultipleDescriptionPage.tsx(line 78) — already explicitly passshouldSubmitFormalongsideautoGrowHeightand work correctly, confirming this is an oversight.What changes do you think we should make in order to solve the problem?
Add
shouldSubmitForm={isMarkdownEnabled}to theInputWrapperinsrc/components/Rule/TextBase.tsx:This makes the Description field behave consistently with other description fields in the app. On hardware keyboard devices, Enter will submit the form; on touch-only devices, Enter will still insert a newline (by design, since
canUseHardwareKeyboardwould befalse).What alternative solutions did you explore? (Optional)
An alternative would be to always pass
shouldSubmitForm={true}unconditionally, but tying it toisMarkdownEnabledis semantically cleaner — it ensures the prop is only set when the multiline markdown behavior is active, matching the exact pattern used in the two other description pages.4 remaining items
luacmartins commentedon Feb 19, 2026
We reverted the offending PR so this is NAB. PR to fix the issue is in review
[-]Rules - Unable to save "Description" field by clicking enter as in the rest of the fields.[/-][+][Due for payment 2026-02-27] Rules - Unable to save "Description" field by clicking enter as in the rest of the fields.[/+]melvin-bot commentedon Feb 20, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 20, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-02-27. 🎊
melvin-bot commentedon Feb 20, 2026
@luacmartins @NicMendonca The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]