Skip to content

Web - Inbox - User has to click "Continue setup" CTA twice in olddot to display "Connect bank account" page in the right sidebar #8295

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #8257

Action Performed:

  1. Go to OldDot and sign up for a new account with an @gmail.com address
  2. Click on the "Get started" on the inbox task that says "Would you like to get started with our free plan?".
  3. Sign out of NewDot
  4. Go back to the OldDot inbox and refresh the page
  5. Click "Continue setup" on the inbox task that says "Finish setting up your bank account".

Expected Result:

The Connect bank account page should open in the right sidebar

Actual Result:

The Connect bank account page opens only on second click and refresh page.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: v1.1.44-5

Reproducible in staging?: Y

Reproducible in production?: Y

Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Bug5504272_Screen_Shot_2022-03-24_at_10 00 35_AM

Bug5504272_continue2.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub
Issue was found when executing #8257

Activity

  1. melvin-bot commented on Mar 24, 2022

    @melvin-bot

    Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. changed the title [-]Web - Inbox - User has to click "Continue setup" CTA in olddot to display "Connect bank account" page in the right sidebar[/-] [+]Web - Inbox - User has to click "Continue setup" CTA twice in olddot to display "Connect bank account" page in the right sidebar[/+] on Mar 27, 2022
  3. MariaHCD commented on Mar 28, 2022

    @MariaHCD
    Contributor

    From the logs, the call to GetShortLivedAuthToken here succeeded.

    However, looks like the first few attempts to navigate to the bank account page didn't work (logs):

    Not showing new bank account page because user is not on free plan beta
    

    Which is why we redirected back to OldDot. But it looks like the test account is on the free plan beta. Not sure what went wrong here.

    cc: @TomatoToaster @madmax330 any ideas?

  4. MariaHCD commented on Mar 31, 2022

    @MariaHCD
    Contributor

    Unable to reproduce the issue locally but I am able to reproduce on production with a gmail account (logs). With the following steps:

    1. Go to OldDot and sign up for a new account or use an existing account with an @gmail.com address
    2. Click on the "Get started" on the inbox task that says "Would you like to get started with our free plan?".
    3. Sign out of NewDot
    4. Go back to the OldDot inbox and refresh the page
    5. Click "Continue setup" on the inbox task that says "Finish setting up your bank account".
    6. Observe that the transition to NewDot does not work

    It should be noted that if signed into both OldDot and NewDot, the transition works as expected.

  5. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 31, 2022
  6. melvin-bot commented on Mar 31, 2022

    @melvin-bot

    Current assignee @MariaHCD is eligible for the Demolition assigner, not assigning anyone new.

  7. removed their assignment
    on Mar 31, 2022
  8. 15 remaining items

  9. melvin-bot commented on Apr 18, 2022

    @melvin-bot

    @neil-marcellini Whoops! This issue is 2 days overdue. Let's get this updated quick!

  10. neil-marcellini commented on Apr 18, 2022

    @neil-marcellini
    Contributor

    I'm updating the PR for this issue to merge into the feature branch neil-transition-flows. Once all of the transition flows are working I will put up a PR to merge the feature branch into main.

  11. melvin-bot commented on Apr 26, 2022

    @melvin-bot

    @neil-marcellini Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  12. melvin-bot commented on Apr 28, 2022

    @melvin-bot

    @neil-marcellini Huh... This is 4 days overdue. Who can take care of this?

  13. neil-marcellini commented on Apr 28, 2022

    @neil-marcellini
    Contributor

    Under review and working on the transitions.

  14. melvin-bot commented on May 6, 2022

    @melvin-bot

    @neil-marcellini Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. neil-marcellini commented on May 6, 2022

    @neil-marcellini
    Contributor

    Still under review for this Onyx PR Set default key states when clearing the cache.

  16. melvin-bot commented on May 16, 2022

    @melvin-bot

    @neil-marcellini Eep! 4 days overdue now. Issues have feelings too...

  17. neil-marcellini commented on May 16, 2022

    @neil-marcellini
    Contributor

    I'm still working on this, trying to get this new Onyx PR merged in.

  18. mvtglobally commented on May 17, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  19. mvtglobally commented on May 24, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (Second week)

  20. melvin-bot commented on May 24, 2022

    @melvin-bot

    @neil-marcellini Whoops! This issue is 2 days overdue. Let's get this updated quick!

  21. neil-marcellini commented on May 24, 2022

    @neil-marcellini
    Contributor

    Sounds like this is currently not reproducible and I believe the previous PRs linked here have fixed it. I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions