You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-07] [ECUK In-App 3DS] [App] Clean up REASON handling in MultifactorAuthentication module #83036
In PR #82704, @rafecolton requested improvements to REASON and BACKEND_MESSAGE in VALUES.ts. These were deferred because the refactor touches all MFA files and would have blown up an already large PR.
feat: map backend error messages to MFA REASON codes
refactor: replace numeric HTTP status keys with HTTP_STATUS categories
The rest was not included due to complexity. Full review discussion and closing rationale are in that PR.
Problem
REASON combines too many responsibilities: screen selection, error recovery flow, expo-secure-store exception mapping, and observability. It's passed through dozens of functions via {success: boolean, reason: REASON}, making the code verbose and tightly coupled. Many REASON values have no custom handling and just fall through to the default failure screen.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
changed the title [-][ECUK In-App 3DS] [App] Clean up `REASON` handling in `MultifactorAuthentication` module[/-][+][Due for payment 2026-05-07] [ECUK In-App 3DS] [App] Clean up `REASON` handling in `MultifactorAuthentication` module[/+]on Apr 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
rafecolton commentedon Mar 19, 2026
Note to revisit
isServerErrorchanges from this thread once this issue gets prioritizedmelvin-bot commentedon Mar 23, 2026
This issue has not been updated in over 15 days. @rafecolton, @chuckdries, @dariusz-biela eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
dariusz-biela commentedon Apr 8, 2026
I'm starting to work on this today.
The solution to this issue isn't obvious, so for now I'll start by researching what we can do about it without breaking the current implementation.
[-][ECUK In-App 3DS] [App] Clean up `REASON` handling in `MultifactorAuthentication` module[/-][+][Due for payment 2026-05-07] [ECUK In-App 3DS] [App] Clean up `REASON` handling in `MultifactorAuthentication` module[/+]melvin-bot commentedon Apr 30, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-07. 🎊
For reference, here are some details about the assignees on this issue:
rafecolton commentedon May 1, 2026
This one is all set