Skip to content

[Due for payment 2026-03-31] [$250] Expense - Change workspace option is shown in paid expense in 1:1 chat for employee #83091

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.24-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176725/test-cases/41237073
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: MacBook air 15.7.3 Chrome
App Component: Money Requests

Action Performed:

Preconditions: User A is a member of User C's workspace. User A is not an admin of any workspace

  1. Sign in to ND as User A and User B
  2. As User A, send an expense in 1:1 chat with User B
  3. As User B, mark the expense as paid
  4. As User A, open expense details, click More - Change workspace

Expected Result:

"Change workspace" option is not presented in paid expense for User B, because when clicking on it, it does not show any workspaces

Actual Result:

"Change workspace" option is shown in paid expense in 1:1 chat for employee, when clicking on it, blank RHP is opened

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7083697_1771608634651.Change_workspace.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022027555653443622748
  • Upwork Job ID: 2027555653443622748
  • Last Price Increase: 2026-02-28
  • Automatic offers:
    • FitseTLT | Reviewer | 110716862

Activity

  1. truph01 commented on Feb 23, 2026

    @truph01
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    • "Change workspace" option is shown in paid expense in 1:1 chat for employee, when clicking on it, blank RHP is opened

    What is the root cause of that problem?

    • There is a inconsistency between how we filter the valid policy to change to in here and here.

    What changes do you think we should make in order to solve the problem?

    • We should sync the logic between them. In here, we should check whether the report is settled and whether the current user is not an admin of the policy. If both conditions are true, we should skip that policy.

    What alternative solutions did you explore? (Optional)

  2. self-assigned this
    on Feb 28, 2026
  3. marcaaron commented on Feb 28, 2026

    @marcaaron
    Contributor

    Seems like pretty low hanging fruit. Let's implement this?

  4. added
    BugSomething is broken. Auto assigns a BugZero manager.
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Feb 28, 2026
  5. melvin-bot commented on Feb 28, 2026

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 28, 2026
  7. 42 remaining items

  8. mallenexpensify commented on Apr 1, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @truph01 due $250 via NewDot
    Contributor+: @FitseTLT paid $250 via Upwork

    @FitseTLT plz complete the BZ checklist and tag me in a post once you have. Thx

  9. FitseTLT commented on Apr 2, 2026

    @FitseTLT
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/60872/changes#r3028269841

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • User A is a member of User C's workspace. User A is not an admin of any workspace

    Test:

    1. Sign in to ND as User A and User B
    2. As User A, send an expense in 1:1 chat with User B
    3. As User B, mark the expense as paid
    4. As User A, open expense details
    5. Verify there is no "Change workspace" option

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-cedb-ae3c-3df4-f5f4c566cdb4
  10. FitseTLT commented on Apr 2, 2026

    @FitseTLT
    Contributor
  11. mallenexpensify commented on Apr 6, 2026

    @mallenexpensify
    Contributor

    ^ Test case created
    Thx

  12. garrettmknight commented on May 10, 2026

    @garrettmknight
    Contributor

    $250 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions