You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Workflows - Blank row appears after deselecting submitter #83251
Version Number: 9.3.25-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#82841 Email or phone of affected tester (no customers):jsodjsodnjoisjdosij@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Invite user A to the workspace.
Create a new workflow when user A submits to user A.
Go to staging.new.expensify.com
Go to workspace settings > Workflows.
Click on the custom workflow where user A submits to user A.
Click Expenses from.
Deselect user A.
Expected Result:
No blank row will appear after deselecting the submitter.
Actual Result:
Blank row appears after deselecting the submitter.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This PR changed how availableMembers are built in WorkflowUtils.ts, switching from deriving members from workflows to including ALL workspace members. While this fixed the original issue (members in custom workflows not appearing), it introduced a new bug where blank rows appear after deselecting submitters. Reverting this PR will allow time to implement a proper fix that handles all edge cases.
Labels: No label changes needed - this is a Frontend bug affecting App deploy, so DeployBlockerCash should remain.
The PR changed the logic in convertPolicyEmployeesToApprovalWorkflows() to build availableMembers from all employees in the loop, rather than deriving it from workflow members
The affected page (WorkspaceWorkflowsApprovalsExpensesFromPage.tsx) uses approvalWorkflow.availableMembers to populate the member selection list
Root Cause
The PR changed availableMembers from being derived from workflow members to including ALL workspace members. The new logic builds availableMembers in the employee loop:
for(constemployeeofObject.values(employees)){const{email, submitsTo, pendingAction}=employee;if(!email){continue;}constmember=buildMemberFromEmployee(employee,personalDetailsByEmail,email);if(pendingAction!==CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE){availableMembers.push(member);}// ... rest of workflow assignment logic}
When a user deselects a submitter (especially in self-approval scenarios like "user A submits to user A"), the filtering/mapping logic in WorkspaceWorkflowsApprovalsExpensesFromPage.tsx appears to create entries with missing or undefined properties, resulting in blank rows. This suggests an edge case was not handled when expanding availableMembers to include all workspace members.
The specific edge case likely involves:
Members with self-approval configurations (submitsTo equals own email)
The interaction between selectedMembers state and availableMembers filtering when toggling selections
Potential data mapping issues when personal details are missing for certain members
Please re-state the problem that we are trying to solve in this issue.
after deselecting a submitter in Workflows > Expenses from, a blank row appears in the list.
What is the root cause of that problem?
PR #82841 changed convertPolicyEmployeesToApprovalWorkflows in WorkflowUtils.ts so that availableMembers now contains ALL workspace employees (previously it was just the first workflow's members). this was correct — it fixed members in custom workflows not appearing in the picker.
but in WorkspaceWorkflowsApprovalsEditPage.tsx (line ~120), the useEffect sets:
since defaultWorkflowMembers (which is result.availableMembers) now includes ALL employees, and currentApprovalWorkflow.members is a subset of that, every current workflow member appears twice. while a member is selected, both duplicates get filtered out and replaced by the selected entry — looks fine. when you deselect, both duplicates pass the filter and get pushed into the list. duplicate keyForList values cause React/FlashList to render one as a blank row.
What changes do you think we should make in order to solve the problem?
in src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsEditPage.tsx, deduplicate when building availableMembers:
// before (creates duplicates):availableMembers: [...currentApprovalWorkflow.members, ...defaultWorkflowMembers],// after:availableMembers: [
...currentApprovalWorkflow.members,
...defaultWorkflowMembers.filter((m)=>!currentApprovalWorkflow.members.some((wm)=>wm.email===m.email)),],
this preserves the PR #82841 fix (all workspace members in the picker) while preventing the duplicate entries that cause the blank row. one-line change, fixes it at the source rather than downstream in ExpensesFromPage.
Activity
melvin-bot commentedon Feb 23, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #82841
melvin-bot commentedon Feb 23, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 23, 2026
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 23, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #82841 - "Fix approval workflow member selection to include all workspace members" by @Beamanator (High confidence)
Related Issues: https://github.com/Expensify/Expensify/issues/598876
Recommendation: REVERT
This PR changed how availableMembers are built in WorkflowUtils.ts, switching from deriving members from workflows to including ALL workspace members. While this fixed the original issue (members in custom workflows not appearing), it introduced a new bug where blank rows appear after deselecting submitters. Reverting this PR will allow time to implement a proper fix that handles all edge cases.
Labels: No label changes needed - this is a Frontend bug affecting App deploy, so
DeployBlockerCashshould remain.📋 Detailed Analysis
Evidence
availableMembersarray that PR Fix approval workflow member selection to include all workspace members #82841 modifiedVerification
src/libs/WorkflowUtils.ts- the file responsible for building approval workflows and available membersconvertPolicyEmployeesToApprovalWorkflows()to buildavailableMembersfrom all employees in the loop, rather than deriving it from workflow membersWorkspaceWorkflowsApprovalsExpensesFromPage.tsx) usesapprovalWorkflow.availableMembersto populate the member selection listRoot Cause
The PR changed availableMembers from being derived from workflow members to including ALL workspace members. The new logic builds availableMembers in the employee loop:
When a user deselects a submitter (especially in self-approval scenarios like "user A submits to user A"), the filtering/mapping logic in
WorkspaceWorkflowsApprovalsExpensesFromPage.tsxappears to create entries with missing or undefined properties, resulting in blank rows. This suggests an edge case was not handled when expanding availableMembers to include all workspace members.The specific edge case likely involves:
selectedMembersstate andavailableMembersfiltering when toggling selections8 remaining items
melvin-bot commentedon Feb 23, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022026061231398885256
shubham1206agra commentedon Feb 24, 2026
@Beamanator Can you please take over this issue?
yuvrajangadsingh commentedon Feb 24, 2026
Please re-state the problem that we are trying to solve in this issue.
after deselecting a submitter in Workflows > Expenses from, a blank row appears in the list.
What is the root cause of that problem?
PR #82841 changed
convertPolicyEmployeesToApprovalWorkflowsinWorkflowUtils.tsso thatavailableMembersnow contains ALL workspace employees (previously it was just the first workflow's members). this was correct — it fixed members in custom workflows not appearing in the picker.but in
WorkspaceWorkflowsApprovalsEditPage.tsx(line ~120), the useEffect sets:since
defaultWorkflowMembers(which isresult.availableMembers) now includes ALL employees, andcurrentApprovalWorkflow.membersis a subset of that, every current workflow member appears twice. while a member is selected, both duplicates get filtered out and replaced by the selected entry — looks fine. when you deselect, both duplicates pass the filter and get pushed into the list. duplicatekeyForListvalues cause React/FlashList to render one as a blank row.What changes do you think we should make in order to solve the problem?
in
src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsEditPage.tsx, deduplicate when buildingavailableMembers:this preserves the PR #82841 fix (all workspace members in the picker) while preventing the duplicate entries that cause the blank row. one-line change, fixes it at the source rather than downstream in ExpensesFromPage.
Beamanator commentedon Feb 24, 2026
Looking!!
Beamanator commentedon Feb 24, 2026
Fixed merged and CP'd, getting retested
m-natarajan commentedon Feb 24, 2026
Passed, Chrome / v9.3.25-9
Screen.Recording.2026-02-24.at.20.58.17.1.mp4
Beamanator commentedon Feb 24, 2026
Nice! closing time!