You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Expense - RHP back button reopens confirm page after creating workspace via Rate field #83265
Version Number: 9.3.25-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#82987 Email or phone of affected tester (no customers):sdoisjndoisdjnosjdioj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Disable Submissions in Workflows settings in default workspace.
Go to staging.new.expensify.com
Open FAB > Track distance > Manual.
Enter amount > Next.
On confirm page, click Rate.
Click Upgrade > Got it, thanks.
Enter a rate and save it.
On confirm page, click RHP back button.
Expected Result:
RHP back button will return to the initial page.
Actual Result:
RHP back button reopens confirm page after creating workspace via Rate field.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #82987 - "IOU - Rate field disabled if destination is self DM and no workspace during manual track distance" by @lorretheboy (High confidence) Related Issues: #82594 (original issue that PR #82987 fixed)
Recommendation: REVERT
PR #82987 fixed an issue where the Rate field was not clickable during manual distance tracking when no workspace exists. However, the fix exposed a pre-existing navigation bug in the upgrade flow that causes the RHP back button to malfunction after creating a workspace via the Rate field.
Reverting PR #82987 will restore the previous behavior where the Rate field is disabled when no workspace exists, preventing users from encountering this navigation issue.
Labels: This is a Frontend bug. Both DeployBlockerCash and DeployBlocker labels should remain until the issue is resolved, as this affects the track distance flow which is a core feature.
📋 Detailed Analysis
Evidence
PR #82987 modified src/components/MoneyRequestConfirmationListFooter.tsx to change the isRateInteractive condition from:
This change allows the Rate field to be clickable when isTrackExpense is true, even when isUnreported is true (meaning no workspace exists). This enables users to click Rate > Upgrade > create a workspace > set a rate.
Verification
The bug reproduction steps exactly match the new functionality introduced by PR #82987:
User has no workspace (isUnreported = true)
User creates track distance expense (isTrackExpense = true)
The changes directly affect the interactive state of the Rate field
The PR was merged on 2026-02-23T16:02:25Z, which aligns with when this bug appeared in staging
Root Cause
The bug is caused by a navigation issue in src/pages/iou/request/step/IOURequestStepUpgrade.tsx in the afterUpgradeAcknowledged function. When the user completes the distance rate upgrade flow, the code:
Calls Navigation.goBack(backToRoute) where backToRoute is the confirmation page
Then immediately calls navigateWithMicrotask(ROUTES.WORKSPACE_CREATE_DISTANCE_RATE_UPGRADE.getRoute(...)) to navigate to the rate selection page
This navigation sequence creates a malformed navigation stack where the back button behavior is broken. The issue existed in the codebase before PR #82987, but was not exposed because the Rate field was previously disabled when no workspace existed, preventing users from entering the upgrade flow in this scenario.
📣 @lorretheboy You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖
@MelvinBot will your suggestion of adding {compareParams: false} cause any new regressions in other flows that go through the upgrade distance rates path?
Good question. I investigated all callers and the fix is safe — here's why:
There is exactly one caller that triggers the DISTANCE_RATES upgrade path: MoneyRequestConfirmationListFooter.tsx:608-621 (the Rate field onPress). It always passes shouldSubmitExpense: true. No other code in the codebase uses UPGRADE_PATHS.DISTANCE_RATES.
compareParams: false is already used downstream in the same flow.CreateDistanceRatePage.tsx:71 — after the user sets a rate, it navigates back to STEP_CONFIRMATION with CONST.IOU.TYPE.SUBMIT and compareParams: false:
This is the exact same pattern proposed for the fix, and it already works correctly in production.
The shouldSubmitExpense: false path is unaffected. When backToRoute is undefined, goBack() does a regular pop without calling goUp at all. The fix only affects the truthy backToRoute path.
What compareParams: false does here: Instead of REPLACE (which creates a duplicate), goUp dispatches POP_TO — this pops the upgrade screen and replaces the existing confirmation's params in-place (updating iouType from track to submit). The transactionID and reportID remain the same, so no data loss.
It's a well-established pattern — compareParams: false is used in 20+ other call sites across the IOU flow, including IOURequestStepParticipants.tsx:206, IOURequestStepReport.tsx:139, IOURequestStepConfirmation.tsx:445, and IOUUtils.ts:24-45.
I just tried this on staging and prod and am not getting this behavior on either. I think we can close this, and we'll just be sure to double check these repro steps when we re-raise the solution to #82594
Activity
melvin-bot commentedon Feb 23, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #82987
melvin-bot commentedon Feb 23, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 23, 2026
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Feb 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 23, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #82987 - "IOU - Rate field disabled if destination is self DM and no workspace during manual track distance" by @lorretheboy (High confidence)
Related Issues: #82594 (original issue that PR #82987 fixed)
Recommendation: REVERT
PR #82987 fixed an issue where the Rate field was not clickable during manual distance tracking when no workspace exists. However, the fix exposed a pre-existing navigation bug in the upgrade flow that causes the RHP back button to malfunction after creating a workspace via the Rate field.
Reverting PR #82987 will restore the previous behavior where the Rate field is disabled when no workspace exists, preventing users from encountering this navigation issue.
Labels: This is a Frontend bug. Both
DeployBlockerCashandDeployBlockerlabels should remain until the issue is resolved, as this affects the track distance flow which is a core feature.📋 Detailed Analysis
Evidence
PR #82987 modified
src/components/MoneyRequestConfirmationListFooter.tsxto change theisRateInteractivecondition from:to:
This change allows the Rate field to be clickable when
isTrackExpenseis true, even whenisUnreportedis true (meaning no workspace exists). This enables users to click Rate > Upgrade > create a workspace > set a rate.Verification
The bug reproduction steps exactly match the new functionality introduced by PR #82987:
I verified that:
src/components/MoneyRequestConfirmationListFooter.tsxwhich contains the Rate field logicRoot Cause
The bug is caused by a navigation issue in
src/pages/iou/request/step/IOURequestStepUpgrade.tsxin theafterUpgradeAcknowledgedfunction. When the user completes the distance rate upgrade flow, the code:Navigation.goBack(backToRoute)where backToRoute is the confirmation pagenavigateWithMicrotask(ROUTES.WORKSPACE_CREATE_DISTANCE_RATE_UPGRADE.getRoute(...))to navigate to the rate selection pageThis navigation sequence creates a malformed navigation stack where the back button behavior is broken. The issue existed in the codebase before PR #82987, but was not exposed because the Rate field was previously disabled when no workspace existed, preventing users from entering the upgrade flow in this scenario.
12 remaining items
suneox commentedon Feb 24, 2026
@lorretheboy Could you take another look at this issue with the current change set?
We can reproduce this issue when there's at least one workspace.
lorretheboy commentedon Feb 24, 2026
Sure, I will take a look asap
melvin-bot commentedon Feb 24, 2026
📣 @lorretheboy You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖
dangrous commentedon Feb 24, 2026
@MelvinBot will your suggestion of adding {compareParams: false} cause any new regressions in other flows that go through the upgrade distance rates path?
MelvinBot commentedon Feb 24, 2026
Good question. I investigated all callers and the fix is safe — here's why:
There is exactly one caller that triggers the
DISTANCE_RATESupgrade path:MoneyRequestConfirmationListFooter.tsx:608-621(the Rate fieldonPress). It always passesshouldSubmitExpense: true. No other code in the codebase usesUPGRADE_PATHS.DISTANCE_RATES.compareParams: falseis already used downstream in the same flow.CreateDistanceRatePage.tsx:71— after the user sets a rate, it navigates back toSTEP_CONFIRMATIONwithCONST.IOU.TYPE.SUBMITandcompareParams: false:This is the exact same pattern proposed for the fix, and it already works correctly in production.
The
shouldSubmitExpense: falsepath is unaffected. WhenbackToRouteisundefined,goBack()does a regular pop without callinggoUpat all. The fix only affects the truthybackToRoutepath.What
compareParams: falsedoes here: Instead of REPLACE (which creates a duplicate),goUpdispatchesPOP_TO— this pops the upgrade screen and replaces the existing confirmation's params in-place (updatingiouTypefromtracktosubmit). ThetransactionIDandreportIDremain the same, so no data loss.It's a well-established pattern —
compareParams: falseis used in 20+ other call sites across the IOU flow, includingIOURequestStepParticipants.tsx:206,IOURequestStepReport.tsx:139,IOURequestStepConfirmation.tsx:445, andIOUUtils.ts:24-45.So no, it should not cause regressions.
m-natarajan commentedon Feb 25, 2026
Issue repro if Track distance clicked from Global +, Not repro if clicked from self DM, Win 11, Chrome, 9.3.25-13
Recording.2426.mp4
dangrous commentedon Feb 25, 2026
I just tried this on staging and prod and am not getting this behavior on either. I think we can close this, and we'll just be sure to double check these repro steps when we re-raise the solution to #82594