Skip to content

[Release 3.3] [Domain Control] Bug: Missing lock account and vacation delegate Onyx data when re-adding a closed domain member account #83303

Closed

Description

@rayane-d

Bug found in this PR:

Bug reproduction steps

Actions performed

  1. Add a user to a domain
  2. Add a vacation delegate for that domain member
  3. Lock the account for that domain member
  4. Close the account for that domain member
  5. Re-add the same user as a domain member

Expected result

The member immediately displays as locked with the correct vacation delegate in the domain members list

Actual result

The member appears unlocked with no vacation delegate. Only after resetting the cache does the correct state appear.

Screen.Recording.2026-02-24.at.10.36.16.AM.mov

Problem

When a domain member is re-added after being deleted, the AddDomainMember response does not include private_lockAccountDetails_${accountID} or private_vacationDelegate_${accountID} in the domain Onyx data.
Example response:

{
    "jsonCode": 200,
    "requestID": "9d053b956a253bc5-LAX",
    "onyxData": [
        {
            "key": "personalDetailsList",
            "onyxMethod": "merge",
            "value": {
                "21336190": {
                    "accountID": 21336190,
                    "avatar": "https:\/\/d2k5nsl2zxldvw.cloudfront.net\/images\/avatars\/default-avatar_9.png",
                    "displayName": "x12@jmusial.dev",
                    "firstName": "",
                    "lastName": "",
                    "login": "x12@jmusial.dev",
                    "phoneNumber": "",
                    "pronouns": "",
                    "status": null,
                    "timezone": {
                        "automatic": true,
                        "selected": "America\/Los_Angeles"
                    },
                    "validated": false
                }
            }
        },
        {
            "key": "domain_20618785",
            "onyxMethod": "merge",
            "value": {
                "domain_securityGroup_931976": {
                    "shared": {
                        "21336190": "read"
                    }
                }
            }
        }
    ],
    "previousUpdateID": 11313252172,
    "lastUpdateID": 11313253355
}

Solution

When reopening a previously closed account, queue a domain-level Onyx merge update to domain admins containing the current private_lockAccountDetails and private_vacationDelegate state for the re-added member.

Issue OwnerCurrent Issue Owner: @rayane-d

Activity

  1. self-assigned this
    on Feb 24, 2026
  2. added
    InternalRequires API changes or must be handled by Expensify staff
    on Feb 24, 2026
  3. rayane-d commented on Feb 24, 2026

    @rayane-d
    ContributorAuthor
  4. moved this from Todo to In Progress in Bring Domain Control to NewDoton Feb 24, 2026
  5. mountiny commented on Feb 26, 2026

    @mountiny
    Contributor

    we done here @rayane-d ?

  6. rayane-d commented on Feb 26, 2026

    @rayane-d
    ContributorAuthor

    Yes, this is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions