Skip to content

[Due for payment 2026-03-13] Add reasonAttributes to AccountSwitcherSkeletonView usage sites #83401

Closed

Description

@MelvinBot

Problem

As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.

Solution

Add reasonAttributes to all usage sites of AccountSwitcherSkeletonView (src/components/AccountSwitcherSkeletonView/index.tsx).

At each usage site:

  1. Pass a reasonAttributes prop with a context string identifying the parent component (e.g. 'ParentComponent.ChildComponent')
  2. Include relevant boolean state variables that determine the loading state (e.g. isLoading, isDataReady)

Example

const reasonAttributes: SkeletonSpanReasonAttributes = {
    context: 'ParentComponent',
    isLoading,
    isDataReady,
};

<AccountSwitcherSkeletonView reasonAttributes={reasonAttributes} />

Reference

Scope

  • Component path: src/components/AccountSwitcherSkeletonView/index.tsx
  • Usage sites to update: ~2 files
Issue OwnerCurrent Issue Owner: @abzokhattab

Activity

  1. sosek108 commented on Feb 27, 2026

    @sosek108
    Contributor

    PR ready for review

  2. abzokhattab commented on Mar 3, 2026

    @abzokhattab
    Contributor

    Can you please assign me to the issue.

  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 6, 2026
  4. changed the title [-]Add reasonAttributes to AccountSwitcherSkeletonView usage sites[/-] [+][Due for payment 2026-03-13] Add reasonAttributes to AccountSwitcherSkeletonView usage sites[/+] on Mar 6, 2026
  5. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  6. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-13. 🎊

  7. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Awaiting Payment)

  8. trjExpensify commented on Mar 13, 2026

    @trjExpensify
    Contributor

    @abzokhattab can I get your Upwork handle, please?

  9. abzokhattab commented on Mar 13, 2026

    @abzokhattab
    Contributor

    thanks @trjExpensify I am paid with newdot

  10. trjExpensify commented on Mar 13, 2026

    @trjExpensify
    Contributor

    Ohhh okay. Payment summary as follows:

    Go ahead and request!

  11. twisterdotcom commented on Mar 14, 2026

    @twisterdotcom
    Contributor

    @abzokhattab has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-bf10-a13b-6529-15daad6c39b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions