Skip to content

[$75] [Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites #83410

Closed

Description

@MelvinBot

Problem

As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.

Solution

Add reasonAttributes to all usage sites of TabNavigatorSkeleton (src/components/Skeletons/TabNavigatorSkeleton.tsx).

At each usage site:

  1. Pass a reasonAttributes prop with a context string identifying the parent component (e.g. 'ParentComponent.ChildComponent')
  2. Include relevant boolean state variables that determine the loading state (e.g. isLoading, isDataReady)

Example

const reasonAttributes: SkeletonSpanReasonAttributes = {
    context: 'ParentComponent',
    isLoading,
    isDataReady,
};

<TabNavigatorSkeleton reasonAttributes={reasonAttributes} />

Reference

Scope

  • Component path: src/components/Skeletons/TabNavigatorSkeleton.tsx
  • Usage sites to update: ~1 file
Issue OwnerCurrent Issue Owner: @linhvovan29546
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022032523219976058869
  • Upwork Job ID: 2032523219976058869
  • Last Price Increase: 2026-03-14
  • Automatic offers:
    • linhvovan29546 | Contributor | 110764985

Activity

  1. sosek108 commented on Feb 27, 2026

    @sosek108
    Contributor

    PR ready for review #83676

  2. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 6, 2026
  3. changed the title [-]Add reasonAttributes to TabNavigatorSkeleton usage sites[/-] [+][Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/+] on Mar 6, 2026
  4. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  5. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-13. 🎊

  6. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Awaiting Payment)

  7. 18 remaining items

  8. melvin-bot commented on Mar 13, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

  9. melvin-bot commented on Mar 13, 2026

    @melvin-bot
  10. changed the title [-][Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/-] [+][$250] [Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/+] on Mar 13, 2026
  11. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 13, 2026
  12. melvin-bot commented on Mar 13, 2026

    @melvin-bot

    📣 @linhvovan29546 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  13. laurenreidexpensify commented on Mar 13, 2026

    @laurenreidexpensify
    Contributor

    Payment Summary

  14. firaolgelana commented on Mar 14, 2026

    @firaolgelana

    Problem

    The issue requires adding reasonAttributes to all usage sites of TabNavigatorSkeleton. Currently, some skeleton components are rendered without passing this metadata, which means the Sentry span created by useSkeletonSpan lacks structured information explaining why the loading indicator is visible. This makes it difficult for engineers to diagnose cases where skeleton loaders remain visible indefinitely.

    Root Cause

    The TabNavigatorSkeleton component already supports the reasonAttributes prop and forwards it to useSkeletonSpan for telemetry. However, the components that render TabNavigatorSkeleton do not always pass this prop. As a result, Sentry spans generated for this skeleton loader do not include contextual information such as the parent component or the state variables controlling the loading condition.

    Proposed Solution

    To resolve this issue, I will update every usage site of TabNavigatorSkeleton to pass a reasonAttributes object containing structured metadata.

    My approach will be:

    1. Search the repository for all occurrences of TabNavigatorSkeleton to identify every usage site.

    2. At each usage location, define a reasonAttributes object that includes:

      • a context string describing the parent component (e.g., "ParentComponent.ChildComponent"),
      • relevant boolean state variables that determine when the skeleton should appear (e.g., isLoading, isDataReady, or similar flags).
    3. Pass this object to the component via the reasonAttributes prop.

    Example implementation:

    const reasonAttributes = {
        context: 'ParentComponent',
        isLoading,
        isDataReady,
    };
    
    <TabNavigatorSkeleton reasonAttributes={reasonAttributes} />

    Validation

    After implementing the changes, I will:

    • run lint and type checks to ensure there are no TypeScript or formatting issues,
    • verify that the skeleton loader behavior remains unchanged,
    • confirm that the reasonAttributes metadata is properly passed to useSkeletonSpan so that Sentry spans contain the necessary debugging information.
  15. melvin-bot commented on Mar 14, 2026

    @melvin-bot

    📣 @firaolgelana! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  16. changed the title [-][$250] [Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/-] [+][$75] [Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/+] on Mar 14, 2026
  17. melvin-bot commented on Mar 14, 2026

    @melvin-bot

    Upwork job price has been updated to $75

  18. linhvovan29546 commented on Mar 14, 2026

    @linhvovan29546
    Contributor

    I didn't review the PR, so I don't feel a payment is justified in this situation. We can close this

  19. firaolgelana commented on Mar 14, 2026

    @firaolgelana

    Contributor Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions