You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$75] [Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites #83410
As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.
Solution
Add reasonAttributes to all usage sites of TabNavigatorSkeleton (src/components/Skeletons/TabNavigatorSkeleton.tsx).
At each usage site:
Pass a reasonAttributes prop with a context string identifying the parent component (e.g. 'ParentComponent.ChildComponent')
Include relevant boolean state variables that determine the loading state (e.g. isLoading, isDataReady)
changed the title [-]Add reasonAttributes to TabNavigatorSkeleton usage sites[/-][+][Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/+]on Mar 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/-][+][$250] [Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/+]on Mar 13, 2026
📣 @linhvovan29546 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
The issue requires adding reasonAttributes to all usage sites of TabNavigatorSkeleton. Currently, some skeleton components are rendered without passing this metadata, which means the Sentry span created by useSkeletonSpan lacks structured information explaining why the loading indicator is visible. This makes it difficult for engineers to diagnose cases where skeleton loaders remain visible indefinitely.
Root Cause
The TabNavigatorSkeleton component already supports the reasonAttributes prop and forwards it to useSkeletonSpan for telemetry. However, the components that render TabNavigatorSkeleton do not always pass this prop. As a result, Sentry spans generated for this skeleton loader do not include contextual information such as the parent component or the state variables controlling the loading condition.
Proposed Solution
To resolve this issue, I will update every usage site of TabNavigatorSkeleton to pass a reasonAttributes object containing structured metadata.
My approach will be:
Search the repository for all occurrences of TabNavigatorSkeleton to identify every usage site.
At each usage location, define a reasonAttributes object that includes:
a context string describing the parent component (e.g., "ParentComponent.ChildComponent"),
relevant boolean state variables that determine when the skeleton should appear (e.g., isLoading, isDataReady, or similar flags).
Pass this object to the component via the reasonAttributes prop.
📣 @firaolgelana! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
changed the title [-][$250] [Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/-][+][$75] [Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/+]on Mar 14, 2026
Activity
sosek108 commentedon Feb 27, 2026
PR ready for review #83676
[-]Add reasonAttributes to TabNavigatorSkeleton usage sites[/-][+][Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/+]melvin-bot commentedon Mar 6, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-13. 🎊
melvin-bot commentedon Mar 6, 2026
Triggered auto assignment to @laurenreidexpensify (
Awaiting Payment)18 remaining items
melvin-bot commentedon Mar 13, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)melvin-bot commentedon Mar 13, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022032523219976058869
[-][Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/-][+][$250] [Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/+]melvin-bot commentedon Mar 13, 2026
📣 @linhvovan29546 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
laurenreidexpensify commentedon Mar 13, 2026
Payment Summary
firaolgelana commentedon Mar 14, 2026
Problem
The issue requires adding
reasonAttributesto all usage sites ofTabNavigatorSkeleton. Currently, some skeleton components are rendered without passing this metadata, which means the Sentry span created byuseSkeletonSpanlacks structured information explaining why the loading indicator is visible. This makes it difficult for engineers to diagnose cases where skeleton loaders remain visible indefinitely.Root Cause
The
TabNavigatorSkeletoncomponent already supports thereasonAttributesprop and forwards it touseSkeletonSpanfor telemetry. However, the components that renderTabNavigatorSkeletondo not always pass this prop. As a result, Sentry spans generated for this skeleton loader do not include contextual information such as the parent component or the state variables controlling the loading condition.Proposed Solution
To resolve this issue, I will update every usage site of
TabNavigatorSkeletonto pass areasonAttributesobject containing structured metadata.My approach will be:
Search the repository for all occurrences of
TabNavigatorSkeletonto identify every usage site.At each usage location, define a
reasonAttributesobject that includes:contextstring describing the parent component (e.g.,"ParentComponent.ChildComponent"),isLoading,isDataReady, or similar flags).Pass this object to the component via the
reasonAttributesprop.Example implementation:
Validation
After implementing the changes, I will:
reasonAttributesmetadata is properly passed touseSkeletonSpanso that Sentry spans contain the necessary debugging information.melvin-bot commentedon Mar 14, 2026
📣 @firaolgelana! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
[-][$250] [Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/-][+][$75] [Due for payment 2026-03-13] Add reasonAttributes to TabNavigatorSkeleton usage sites[/+]melvin-bot commentedon Mar 14, 2026
Upwork job price has been updated to $75
linhvovan29546 commentedon Mar 14, 2026
I didn't review the PR, so I don't feel a payment is justified in this situation. We can close this
firaolgelana commentedon Mar 14, 2026
Contributor Details