Skip to content

[$75] [Due for payment 2026-03-18] Add reasonAttributes to UnreportedExpensesSkeleton usage sites #83411

Closed

Description

@MelvinBot

Problem

As part of #81683, we need to add reasonAttributes to all skeleton components so that Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.

Solution

Add reasonAttributes to all usage sites of UnreportedExpensesSkeleton (src/components/Skeletons/UnreportedExpensesSkeleton.tsx).

At each usage site:

  1. Pass a reasonAttributes prop with a context string identifying the parent component (e.g. 'ParentComponent.ChildComponent')
  2. Include relevant boolean state variables that determine the loading state (e.g. isLoading, isDataReady)

Example

const reasonAttributes: SkeletonSpanReasonAttributes = {
    context: 'ParentComponent',
    isLoading,
    isDataReady,
};

<UnreportedExpensesSkeleton reasonAttributes={reasonAttributes} />

Reference

Scope

  • Component path: src/components/Skeletons/UnreportedExpensesSkeleton.tsx
  • Usage sites to update: ~1 file
Issue OwnerCurrent Issue Owner: @abdulrahuman5196

Activity

  1. sosek108 commented on Feb 27, 2026

    @sosek108
    Contributor

    PR ready for review #83677

  2. abdulrahuman5196 commented on Mar 5, 2026

    @abdulrahuman5196
    Contributor

    @youssef-lr Could you kindly add me as C+ here since I have reviewed the PR?

  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 11, 2026
  4. changed the title [-]Add reasonAttributes to UnreportedExpensesSkeleton usage sites[/-] [+][Due for payment 2026-03-18] Add reasonAttributes to UnreportedExpensesSkeleton usage sites[/+] on Mar 11, 2026
  5. melvin-bot commented on Mar 11, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  6. melvin-bot commented on Mar 11, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.35-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-18. 🎊

  7. melvin-bot commented on Mar 11, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  8. youssef-lr commented on Mar 14, 2026

    @youssef-lr
    Contributor

    No payment needed.

  9. abdulrahuman5196 commented on Mar 15, 2026

    @abdulrahuman5196
    Contributor

    @youssef-lr Could you kindly add me as C+ here since I have reviewed the PR?

    @youssef-lr Could kindly check on this?

  10. abdulrahuman5196 commented on Apr 25, 2026

    @abdulrahuman5196
    Contributor

    @youssef-lr Could you kindly add me as C+ here since I have reviewed the PR?

    @youssef-lr Could kindly check on this?

    Gentle ping on this? Pinged in slack as well

  11. changed the title [-][Due for payment 2026-03-18] Add reasonAttributes to UnreportedExpensesSkeleton usage sites[/-] [+][$75] [Due for payment 2026-03-18] Add reasonAttributes to UnreportedExpensesSkeleton usage sites[/+] on Apr 27, 2026
  12. melvin-bot commented on Apr 27, 2026

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  13. abdulrahuman5196 commented on Apr 27, 2026

    @abdulrahuman5196
    Contributor

    @mallenexpensify Could you kindly add the payment summary here? I don't think this issue needs a BZ checklist.

  14. mallenexpensify commented on Apr 27, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @abdulrahuman5196 due $75 via NewDot

    Thanks for being persistent, sorry it took a while. You can always post in #contributor-plus and tag me when this happens (where issues are closed or when Reviewing label is stuck).

  15. abdulrahuman5196 commented on May 5, 2026

    @abdulrahuman5196
    Contributor

    @mallenexpensify I think the payment summary is higher than the current issue price

  16. mallenexpensify commented on May 6, 2026

    @mallenexpensify
    Contributor

    @abdulrahuman5196 thx, updated! (textexpander shortcuts help and hurt!)

  17. laurenreidexpensify commented on May 19, 2026

    @laurenreidexpensify
    Contributor

    $75 approved for @abdulrahuman5196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions