Repository navigation
[Ready for payment via newdot][$16000] Android - Copy / Paste / Cut menu is not displayed when selecting text in compose box - Reported by: @parasharrajat #8349
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Navigate to a conversation
- Type anything in compose box
- Select it
Expected Result:
Native menu to cut / copy / paste should be displayed
Actual Result:
Native menu to cut / copy / paste is not displayed or displayed for a second and then hidden
Workaround:
User is unable to cut / copy / paste text in the compose box.
Selecting a word/text and then long tapping on another word seems to bring the context menu with copy/cut/paste actions
Additional details
This comment from the previous ticket summarizes what we have found out and tried so far.
We've identified using the selection prop works as expected in iOS, but does not work as expected on Android, resulting in the reported bug.
We're looking for identifying the problem in react-native and proposing a fix
Once a proposal is approved a contributor would be hired to submit a PR against our react-native fork: https://github.com/Expensify/react-native
We're not looking for a workaround solution that
- uses platform specific code e.g. handling
selectiondifferently inComposer/index.android|ios|web.jsfiles - uses
setTimeout,setImmediateorrequestAnimationFrame
Platform:
Where is this issue occurring?
- Android
Version Number: v1.1.46-3
Reproducible in staging?: yes
Reproducible in production?: yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
WhatsApp.Video.2021-12-22.at.11.37.59.AM.mp4
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640179428463500
Previous ticket: #6876
Activity
melvin-bot commentedon Mar 29, 2022
Triggered auto assignment to @greg-schroeder (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.kidroca commentedon Mar 29, 2022
Created as continuation for: #6876 (comment)
cc @mallenexpensify @parasharrajat @rushatgabhane @stitesExpensify
melvin-bot commentedon Mar 30, 2022
Triggered auto assignment to @Julesssss (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.greg-schroeder commentedon Mar 30, 2022
I reproduced this one so sending to my friends in Eng
203 remaining items
[-][HOLD 🗡️ RN fork #18444][$16000] Android - Copy / Paste / Cut menu is not displayed when selecting text in compose box - Reported by: @parasharrajat[/-][+][Ready for payment][$16000] Android - Copy / Paste / Cut menu is not displayed when selecting text in compose box - Reported by: @parasharrajat[/+]parasharrajat commentedon Aug 10, 2023
Sure @kadiealexander.
Here is the summary.
Reporting: @parasharrajat
C+: @parasharrajat This does involve C+ payment as there have been 2 issues and about 3 lengthy PRs for this issue before we found a purely native solution. This issue is a continuation of old issues which we closed to change the perspective.
Contributor: @hannojg & @janicduplessis [Ready for payment via newdot][$16000] Android - Copy / Paste / Cut menu is not displayed when selecting text in compose box - Reported by: @parasharrajat #8349 (comment)
Apart from it, I think @kidroca also presented conclusive evidence of the solution and was involved in research a long time back around August 2022. Not sure if they are already paid as they were being paid hourly earlier.
Both Contributors were involved. I don't know if both are linked to the same agency or different. As Agency payments are handled separately, I think it is already managed.
kadiealexander commentedon Aug 10, 2023
@parasharrajat could you please link all the related PRs and issues here? This is a big payment and it's not a simple 1 PR = 1 payment issue like usual, so I really want to ensure I understand what happened.
parasharrajat commentedon Aug 10, 2023
Sure.
Related issues and PR.
This issue, Main PR perf: fix (comment) input performance #11684
Issue [$1000] Android - Copy / Paste / Cut menu is not displayed when selecting text in compose box - Reported by: @parasharrajat #6876 PR Fix android copy paste menu doens't show up in compose box #7717 , PR Fix Android text selection context menu (copy, paste) #7815
Issue [HOLD for payment 2022-09-07] [$2000] IOU - User is unable to modify the IOU amount - Reported by: @Santhosh-Sellavel #6154, PR Added ability to modify IOU Amount #7433
PR Composer: Control selection using setSelection #17687, We closed this in favor of this issue.
PR fix(android): selection menu missing controlled textinput react-native#50
PR Fix and simplify controlled text selection on Android react-native#55
This issue, Main PR perf: fix (comment) input performance #11684
Slack discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1645191589301989. I might be missing a few.
Now, the Agency team has been working on upgrading many libs internally to upgrade the RN version to the latest and enable new architecture. Those all issues are handled separately but required before we could merge the final solution in our app.
These are the main issues and PR which I remember but I think there have been more in the past which we closed.
I have been involved directly or indirectly in all of these PRs where I have run tests from time to time and tracked them.
hannojg commentedon Aug 10, 2023
There is also this issue which should be fixed now:
kadiealexander commentedon Aug 11, 2023
Payouts due:
Eligible for 50% #urgency bonus? No
All payments to be paid via Newdot.
Julesssss commentedon Aug 11, 2023
Hi @kadiealexander, that seems reasonable to me but maybe we should just check in with @kidroca to confirm?
kidroca commentedon Aug 11, 2023
Hey @Julesssss, @kadiealexander,
Thanks for reaching out and considering my contributions. While I did invest time in research and provided insights, I wasn't tracking my hours as I was aiming for the fixed price job. I remember highlighting that the issue might naturally resolve with our migration to the new architecture. However, I'm aware that the solution wasn't as straightforward and there were overlaps with other issues.
Ultimately, the main work was carried out by another contributor. I genuinely appreciate the acknowledgment, but I'm not seeking any compensation for this. It's challenging to measure the exact impact of my input, and I'm just glad I could assist in some way.
Best,
@kidroca
kadiealexander commentedon Aug 13, 2023
Thank you @kidroca!! That's very generous of you to be willing to share your expertise with us like that.
In that case @parasharrajat if you could please request your portion via newdot we should be good here. Thanks to everyone who worked on this!
[-][Ready for payment][$16000] Android - Copy / Paste / Cut menu is not displayed when selecting text in compose box - Reported by: @parasharrajat[/-][+][Ready for payment via newdot][$16000] Android - Copy / Paste / Cut menu is not displayed when selecting text in compose box - Reported by: @parasharrajat[/+]parasharrajat commentedon Aug 14, 2023
Payment requested.
JmillsExpensify commentedon Aug 16, 2023
Reviewed the details for @parasharrajat. Approved for payment in NewDot based on the BZ summary above.