Skip to content

[$250] Expense - “To” field is not tappable on confirm page with Expensifail account #83534

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.26-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #81284
Email or phone of affected tester (no customers): applausetester+nowe@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Samsung Galaxy S21 Ultra/Android 15, Macbook/macOS 13.7.8/Chrome. iPhone 13/18.6.2
App Component: Other

Action Performed:

Precondition: Log in to Expensifail account.

Launch Expensify app.
Open FAB > Create expense > Manual.
Enter amount > Next.
On confirm page, tap To field.

Expected Result:

Contact list will always auto load when scrolled to the bottom.

Actual Result:

The “To” field cannot be tapped or selected on the Confirm page and user is unable to access to contact list

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @heyjennahay
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022026893792994641346
  • Upwork Job ID: 2026893792994641346
  • Last Price Increase: 2026-02-26

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 26, 2026
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 26, 2026
  3. melvin-bot commented on Feb 26, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

  4. melvin-bot commented on Feb 26, 2026

    @melvin-bot

    Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot commented on Feb 26, 2026

    @melvin-bot
  6. changed the title [-]Expense - “To” field is not tappable on confirm page with Expensifail account[/-] [+][$250] Expense - “To” field is not tappable on confirm page with Expensifail account[/+] on Feb 26, 2026
  7. daledah commented on Feb 26, 2026

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The "To" field cannot be tapped or selected on the Confirm page and user is unable to access to contact list.

    What is the root cause of that problem?

    In MoneyRequestConfirmationList.tsx, the isInteractive and shouldShowRightCaret properties for the "To" field participant row include a (!isRestrictedToPreferredPolicy || isTypeInvoice) condition. When the user's domain has a security group with enableRestrictedPrimaryPolicy set to true and a valid restrictedPrimaryPolicyID, isRestrictedToPreferredPolicy becomes true, which causes isInteractive to evaluate to false for non-invoice expense types. This makes the "To" field row completely non-tappable on the confirmation page.

    isInteractive: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice),
    shouldShowRightCaret: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice),

    However, this restriction is unnecessary here because the MoneyRequestParticipantsSelector already passes isRestrictedToPreferredPolicy and preferredPolicyID to the options filtering logic, which correctly limits the participant choices to only those within the preferred policy. So the participant selection page itself already enforces the restriction — there is no need to also block navigation to it from the confirmation page.

    isRestrictedToPreferredPolicy,
    preferredPolicyID,

    What changes do you think we should make in order to solve the problem?

    Remove the (!isRestrictedToPreferredPolicy || isTypeInvoice) condition from isInteractive and shouldShowRightCaret in MoneyRequestConfirmationList.tsx, since the participant selector already handles the policy restriction by filtering the available options.

    --- a/src/components/MoneyRequestConfirmationList.tsx
    +++ b/src/components/MoneyRequestConfirmationList.tsx
    @@ -840,8 +840,8 @@ function MoneyRequestConfirmationList({
                     ...participant,
                     isSelected: false,
                     keyForList: `${participant.keyForList ?? participant.accountID ?? participant.reportID}`,
    -                isInteractive: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice),
    -                shouldShowRightCaret: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice),
    +                isInteractive: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt,
    +                shouldShowRightCaret: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt,
                 }));

    After this change, isRestrictedToPreferredPolicy and isTypeInvoice can also be removed from the useMemo dependency array of sections.

    Optional: we can keep the isTypeInvoice in the condition

    What alternative solutions did you explore? (Optional)

    An alternative would be to add a separate check inside navigateToParticipantPage to handle the restricted policy case differently (e.g., navigate to a filtered participant page). However, since the participant selector already filters options based on isRestrictedToPreferredPolicy, this would be redundant. The simplest and most correct fix is to remove the overly restrictive condition on the confirmation page.

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  8. MelvinBot commented on Feb 26, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The "To" field on the expense confirmation page (Create expense > Manual > Enter amount > Next) cannot be tapped or selected when using an Expensifail account. This prevents users from accessing the contact list to change the expense recipient.

    What is the root cause of that problem?

    The "To" field's interactivity is controlled by the following expression in MoneyRequestConfirmationList.tsx (line 843):

    isInteractive: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice)
    

    For Expensifail accounts, the domain's security group has enableRestrictedPrimaryPolicy set to true with a valid restrictedPrimaryPolicyID. This causes usePreferredPolicy() (hook source) to return isRestrictedToPreferredPolicy: true.

    When isRestrictedToPreferredPolicy is true and the expense type is not an invoice, the condition (!isRestrictedToPreferredPolicy || isTypeInvoice) evaluates to false, which makes isInteractive = false. This flows through BaseListItem → PressableWithFeedback → BaseGenericPressable, where the press handler returns early when interactive is false (line 112).

    This restriction is overly broad. The MoneyRequestParticipantsSelector already passes isRestrictedToPreferredPolicy and preferredPolicyID into the options filtering logic (lines 192-193), which correctly limits the visible contacts to the preferred policy. Blocking access to the participant selector page entirely from the confirmation page is redundant and breaks the UX.

    What changes do you think we should make in order to solve the problem?

    Remove the (!isRestrictedToPreferredPolicy || isTypeInvoice) sub-condition from both the isInteractive and shouldShowRightCaret expressions in MoneyRequestConfirmationList.tsx (around line 843-844). The updated expressions should be:

    isInteractive: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt,
    shouldShowRightCaret: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt,
    

    This is safe because the participant selector page already enforces the preferred policy restriction by filtering which contacts are shown. Users will be able to tap the "To" field and see a filtered contact list, but they will only see contacts within their restricted policy.

    What alternative solutions did you explore? (Optional)

    An alternative would be to modify usePreferredPolicy to not return isRestrictedToPreferredPolicy: true for certain account types, but this would be incorrect as the restriction should still apply at the participant filtering level — just not at the "To" field tappability level.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

  9. marufsharifi commented on Feb 26, 2026

    @marufsharifi

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On the Expense confirmation step, the “To” row is not tappable for Expensifail users, so they cannot open the participant selector and cannot continue with recipient selection/editing.

    What is the root cause of that problem?

    The “To” row interactivity is gated by a condition that disables the row when the account is restricted to a preferred policy:

    • Root-cause condition in MoneyRequestConfirmationList :
      isInteractive: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice),
      shouldShowRightCaret: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice),

    For Expensifail accounts, usePreferredPolicy() returns isRestrictedToPreferredPolicy: true :

    return {
    isRestrictedToPreferredPolicy: isRestrictionEnabled && hasValidPolicyID,
    preferredPolicyID: restrictedPolicyID,

    That makes the row non-interactive, which blocks tapping entirely.
    This is over-restrictive because participant restriction is already enforced inside the selector options filtering :

    isRestrictedToPreferredPolicy,
    preferredPolicyID,

    What changes do you think we should make in order to solve the problem?

    I implemented a stronger fix by centralizing participant editability into one reusable rule and using it in both UI interactivity and navigation gating.

    1) Add a single source of truth helper in IOUUtils

    diff --git a/src/libs/IOUUtils.ts b/src/libs/IOUUtils.ts
    index b889a27dff2..62fc15d1ee1 100644
    --- a/src/libs/IOUUtils.ts
    +++ b/src/libs/IOUUtils.ts
    @@ -60,6 +60,20 @@ function navigateToParticipantPage(iouType: ValueOf<typeof CONST.IOU.TYPE>, tran
         }
     }
     
    +function canEditMoneyRequestParticipant({
    +    isFromGlobalCreate,
    +    isPerDiemRequest,
    +    isTimeRequest,
    +    isTestReceipt,
    +}: {
    +    isFromGlobalCreate: boolean;
    +    isPerDiemRequest: boolean;
    +    isTimeRequest: boolean;
    +    isTestReceipt: boolean;
    +}) {
    +    return isFromGlobalCreate && !isPerDiemRequest && !isTimeRequest && !isTestReceipt;
    +}
    +
     /**
      * Calculates the amount per split.
      *
    @@ -389,6 +403,7 @@ export {
         updateIOUOwnerAndTotal,
         formatCurrentUserToAttendee,
         navigateToParticipantPage,
    +    canEditMoneyRequestParticipant,
         shouldShowReceiptEmptyState,
         navigateToConfirmationPage,
         calculateDefaultReimbursable,

    2) Use the helper in MoneyRequestConfirmationList for both row behavior and navigation

    diff --git a/src/components/MoneyRequestConfirmationList.tsx b/src/components/MoneyRequestConfirmationList.tsx
    index 13eb788d7e9..d2cb1657803 100755
    --- a/src/components/MoneyRequestConfirmationList.tsx
    +++ b/src/components/MoneyRequestConfirmationList.tsx
    @@ -12,7 +12,6 @@ import useOnyx from '@hooks/useOnyx';
     import usePermissions from '@hooks/usePermissions';
     import usePolicyForMovingExpenses from '@hooks/usePolicyForMovingExpenses';
     import usePolicyForTransaction from '@hooks/usePolicyForTransaction';
    -import usePreferredPolicy from '@hooks/usePreferredPolicy';
     import usePrevious from '@hooks/usePrevious';
     import useThemeStyles from '@hooks/useThemeStyles';
     import blurActiveElement from '@libs/Accessibility/blurActiveElement';
    @@ -33,7 +32,12 @@ import {getIsMissingAttendeesViolation} from '@libs/AttendeeUtils';
     import {isCategoryDescriptionRequired} from '@libs/CategoryUtils';
     import {convertToBackendAmount, convertToDisplayString, convertToDisplayStringWithoutCurrency} from '@libs/CurrencyUtils';
     import DistanceRequestUtils from '@libs/DistanceRequestUtils';
    -import {calculateAmount, insertTagIntoTransactionTagsString, isMovingTransactionFromTrackExpense as isMovingTransactionFromTrackExpenseUtil} from '@libs/IOUUtils';
    +import {
    +    calculateAmount,
    +    canEditMoneyRequestParticipant,
    +    insertTagIntoTransactionTagsString,
    +    isMovingTransactionFromTrackExpense as isMovingTransactionFromTrackExpenseUtil,
    +} from '@libs/IOUUtils';
     import Log from '@libs/Log';
     import {validateAmount} from '@libs/MoneyRequestUtils';
     import Navigation from '@libs/Navigation/Navigation';
    @@ -318,7 +322,6 @@ function MoneyRequestConfirmationList({
         const styles = useThemeStyles();
         const {translate, toLocaleDigit} = useLocalize();
         const currentUserPersonalDetails = useCurrentUserPersonalDetails();
    -    const {isRestrictedToPreferredPolicy} = usePreferredPolicy();
     
         const isTypeRequest = iouType === CONST.IOU.TYPE.SUBMIT;
         const isTypeSplit = iouType === CONST.IOU.TYPE.SPLIT;
    @@ -326,7 +329,12 @@ function MoneyRequestConfirmationList({
         const isTypeTrackExpense = iouType === CONST.IOU.TYPE.TRACK;
         const isTypeInvoice = iouType === CONST.IOU.TYPE.INVOICE;
         const isScanRequest = useMemo(() => isScanRequestUtil(transaction), [transaction]);
    -    const isFromGlobalCreateAndCanEditParticipant = !!transaction?.isFromGlobalCreate && !isPerDiemRequest && !isTimeRequest;
    +    const canEditParticipant = canEditMoneyRequestParticipant({
    +        isFromGlobalCreate: !!transaction?.isFromGlobalCreate,
    +        isPerDiemRequest,
    +        isTimeRequest,
    +        isTestReceipt,
    +    });
     
         const transactionID = transaction?.transactionID;
         const customUnitRateID = getRateID(transaction);
    @@ -840,8 +848,8 @@ function MoneyRequestConfirmationList({
                     ...participant,
                     isSelected: false,
                     keyForList: `${participant.keyForList ?? participant.accountID ?? participant.reportID}`,
    -                isInteractive: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice),
    -                shouldShowRightCaret: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice),
    +                isInteractive: canEditParticipant,
    +                shouldShowRightCaret: canEditParticipant,
                 }));
     
                 options.push({
    @@ -852,18 +860,7 @@ function MoneyRequestConfirmationList({
             }
     
             return options;
    -    }, [
    -        isTypeSplit,
    -        translate,
    -        payeePersonalDetails,
    -        getSplitSectionHeader,
    -        splitParticipants,
    -        selectedParticipants,
    -        isFromGlobalCreateAndCanEditParticipant,
    -        isTestReceipt,
    -        isRestrictedToPreferredPolicy,
    -        isTypeInvoice,
    -    ]);
    +    }, [isTypeSplit, translate, payeePersonalDetails, getSplitSectionHeader, splitParticipants, selectedParticipants, canEditParticipant]);
     
         useEffect(() => {
             if (!isDistanceRequest || (isMovingTransactionFromTrackExpense && !isPolicyExpenseChat) || !transactionID || isReadOnly) {
    @@ -951,7 +948,7 @@ function MoneyRequestConfirmationList({
          * Navigate to the participant step
          */
         const navigateToParticipantPage = () => {
    -        if (!isFromGlobalCreateAndCanEditParticipant) {
    +        if (!canEditParticipant) {
                 return;
             }
    

    This fixes the bug and keeps policy restriction where it belongs: in participant option filtering, not in blocking the tap path.

    What alternative solutions did you explore? (Optional)

    • Minimal patch (remove only (!isRestrictedToPreferredPolicy || isTypeInvoice) inline) was considered.
  10. nkdengineer commented on Feb 26, 2026

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The “To” field cannot be tapped or selected on the Confirm page and user is unable to access to contact list

    What is the root cause of that problem?

    For the account that is in a restricted domain, we block the To field here because isRestrictedToPreferredPolicy is true

    isInteractive: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice),
    shouldShowRightCaret: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice),

    What changes do you think we should make in order to solve the problem?

    For the restricted domain account, we have two participant options to create an expense

    • Restricted workspace chat
    • SelfDM

    So we can allow editing the participant by removing (!isRestrictedToPreferredPolicy || isTypeInvoice) condition from here

    isInteractive: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt,
    

    isInteractive: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice),
    shouldShowRightCaret: isFromGlobalCreateAndCanEditParticipant && !isTestReceipt && (!isRestrictedToPreferredPolicy || isTypeInvoice),

    After fixing this problem, we still have another problem in the participant page: the DM contact appears in the participant list while isRestrictedToPreferredPolicy is true.

    Screen.Recording.2026-02-26.at.13.29.04.mov

    We also need to fix this to prevent submitting the expense to DM when isRestrictedToPreferredPolicy is true. We need to update this condition to not include the DM options when isRestrictedToPreferredPolicy is true

    if (includeP2P && !config.isRestrictedToPreferredPolicy) {
    

    if (includeP2P) {

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  11. 30 remaining items

  12. melvin-bot commented on Mar 24, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  13. melvin-bot commented on Apr 6, 2026

    @melvin-bot

    @heyjennahay Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. melvin-bot commented on Apr 8, 2026

    @melvin-bot

    @heyjennahay Huh... This is 4 days overdue. Who can take care of this?

  15. heyjennahay commented on Apr 8, 2026

    @heyjennahay
    Contributor

    Payment summary

    Thanks everyone

  16. laurenreidexpensify commented on Apr 10, 2026

    @laurenreidexpensify
    Contributor

    Payment Approved for @jjcoffee in New Expensify $125

  17. twisterdotcom commented on Apr 22, 2026

    @twisterdotcom
    Contributor

    @nkdengineer has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-616f-a8f8-adc8-584179b9d454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions