Skip to content

[BT-008] Implement Dynamic Suffix Layering #83551

Closed

Description

@mjasikowski

Description

Current State:

  • The current dynamic route implementation only supports a single suffix level (e.g., /base-path/verify-account)
  • Nested routes like settings/profile/address/country require multiple suffix layers (e.g., /profile + /address/country)
  • This limitation was discovered during BT-102 migration work

Expected State:

  • Support suffix layering so dynamic routes can be nested (e.g., /settings/profile/address/country built from /settings + /profile + /address/country)
  • The createDynamicRoute() helper and getAdaptedStateFromPath interception logic must handle multiple dynamic suffix levels
  • Access control (entryScreens) should validate at each layer
  • Back navigation should correctly strip one suffix layer at a time

Implementation:

  • Extend createDynamicRoute() to support appending suffixes onto paths that already contain dynamic suffixes
  • Update suffix detection in getMatchingFullScreenRoute() to recursively or iteratively resolve layered suffixes
  • Ensure state restoration (page refresh / deep link) correctly rebuilds the full nested navigation state
  • Update unit tests to cover layered suffix scenarios

Context

See discussion: #83361 (comment)

This is a blocker for migrating routes with nested dynamic suffixes across Phase 2.

Scope

Files:

  • App/src/libs/Navigation/Navigation.ts - Extend createDynamicRoute() for layered suffixes
  • App/src/libs/Navigation/helpers/getAdaptedStateFromPath.ts - Handle layered suffix resolution
  • App/src/ROUTES.ts - May need DYNAMIC_ROUTES config updates for nested paths
  • Test files for dynamic routing

Dependencies:

Issue OwnerCurrent Issue Owner: @collectioneur

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Feb 26, 2026
  2. mjasikowski commented on Feb 26, 2026

    @mjasikowski
    ContributorAuthor

    @collectioneur will handle the PR here

  3. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 4, 2026
  4. changed the title [-][BT-008] Implement Dynamic Suffix Layering[/-] [+][Due for payment 2026-03-16] [BT-008] Implement Dynamic Suffix Layering[/+] on Mar 9, 2026
  5. melvin-bot commented on Mar 9, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  6. 12 remaining items

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 17, 2026
  8. changed the title [-][BT-008] Implement Dynamic Suffix Layering[/-] [+][Due for payment 2026-03-30] [BT-008] Implement Dynamic Suffix Layering[/+] on Mar 23, 2026
  9. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-30. 🎊

    For reference, here are some details about the assignees on this issue:

    • @huult requires payment through NewDot Manual Requests
    • @collectioneur does not require payment (Contractor)
  11. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  12. changed the title [-][Due for payment 2026-03-30] [BT-008] Implement Dynamic Suffix Layering[/-] [+][BT-008] Implement Dynamic Suffix Layering[/+] on Mar 26, 2026
  13. mallenexpensify commented on Mar 30, 2026

    @mallenexpensify
    Contributor

    If payment is due for @huult please tag me and make me issue own. (and reopen) thx

  14. huult commented on Mar 31, 2026

    @huult
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions