Repository navigation
[HOLD for payment 2022-05-20] [$250] Cursor pointer is disabled on all members on Manage members page - reported by @Tushu17 #8358
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to setting > Workspace > Manage members
- Invite few members(if you haven't)
- Hover over members.
Expected Result:
It should only be disabled when hover over the administrator.
Actual Result:
Cursor pointer is disabled on all members.
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- Desktop App
Version Number: 1.1.46-3
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Sec-Rec.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1647551574992219
Activity
melvin-bot commentedon Mar 30, 2022
Triggered auto assignment to @Christinadobrzyn (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.Christinadobrzyn commentedon Mar 30, 2022
Hum, I'm not sure I understand the issue. Testing this on my mobile, I tap on a non-admin and I can
select/Removebut I can'tselect/Removemyself (the admin).@Tushu17 Can you clarify what you expect to see differently?
Tushu17 commentedon Mar 30, 2022
@Christinadobrzyn This issue is about mouse cursor showing disabled even on selectable members.
Tushu17 commentedon Mar 30, 2022
Proposal
We just need to use
isDisabled={!canBeRemoved}at line 218App/src/pages/workspace/WorkspaceMembersPage.js
Lines 215 to 223 in 90e5af4
Christinadobrzyn commentedon Mar 31, 2022
Ah gotcha! This seems to only be affecting the web app. Sorry - missed that.
melvin-bot commentedon Mar 31, 2022
Triggered auto assignment to @alex-mechler (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.alex-mechler commentedon Mar 31, 2022
Looks ready to go external
36 remaining items
[-][$250] Cursor pointer is disabled on all members on Manage members page - reported by @Tushu17[/-][+][HOLD for payment 2022-05-20] [$250] Cursor pointer is disabled on all members on Manage members page - reported by @Tushu17[/+]laurenreidexpensify commentedon May 17, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.57-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-05-20. 🎊
laurenreidexpensify commentedon May 20, 2022
@Santhosh-Sellavel @Tushu17 once you've accepted the job in Upwork I can issue payment thanks
laurenreidexpensify commentedon May 20, 2022
link for me https://www.upwork.com/ab/applicants/1511327598055616512/offers
Tushu17 commentedon May 20, 2022
@laurenreidexpensify hi, The offer you've sent me is set on Hourly basis.
Santhosh-Sellavel commentedon May 20, 2022
Thanks, Accepted @laurenreidexpensify!
laurenreidexpensify commentedon May 20, 2022
@Tushu17 if you accept as it is I will just pay you via the bonus option and override the hours setting. Thanks!
Tushu17 commentedon May 20, 2022
@laurenreidexpensify Okay, Accepted👍
laurenreidexpensify commentedon May 23, 2022
Sorry for delay folks - all paid now