Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: V9.3.26-4
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #82257
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: Money Requests
Action Performed:
- Launch app
- Login with expensifail account
- Create a workspace
- Open workspace chat
- Create a distance map expense
- Open the expense
- Tap more - split
- Tap first expense - distance - add a stop "your location" & save
- Tap split expense
- Open the expense
- Tap receipt and note only 2 waypoints are shown
- Tap distance and note 3 waypoints are shown
Expected Result:
Waypoints added while splitting must be shown in distance receipt.
Actual Result:
Waypoints added while splitting is not shown in distance receipt.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
Screenshots/Videos
Bug7089473_1772130052076.Screenrecorder-2026-02-26-23-37-30-9.mp4
Issue Owner
Current Issue Owner: @ikevin127Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022027097927677363650
- Upwork Job ID: 2027097927677363650
- Last Price Increase: 2026-02-26
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Feb 26, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #82257
melvin-bot commentedon Feb 26, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Feb 26, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (
External)melvin-bot commentedon Feb 26, 2026
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Expense - Waypoints added while splitting is not shown in distance receipt[/-][+][$250] Expense - Waypoints added while splitting is not shown in distance receipt[/+]melvin-bot commentedon Feb 26, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022027097927677363650
github-actions commentedon Feb 26, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Feb 26, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #82257 - feat: handle the Distance and Rate fields for splits by @ZhenjaHorbach (High confidence)
Related Issues: This is a new feature that introduced split distance expenses
Recommendation: REVERT
This PR introduced the ability to handle distance and rate fields for split expenses. The bug affects the split distance expense flow where waypoints added during editing are not properly displayed in the distance receipt.
Labels: DeployBlockerCash label should be kept (this is a frontend App bug that requires an App PR to fix)
Evidence
The bug occurs when editing a split distance expense and adding waypoints - the distance view shows all waypoints correctly but the receipt view only shows the original waypoints, missing newly added ones.
PR #82257 was identified by melvin-bot as the causing PR and introduced comprehensive changes to handle distance fields in split expenses, modifying 25 files including src/libs/actions/IOU/Split.ts (326 additions, 37 deletions).
The PR was merged on 2026-02-24 and the issue was reported on 2026-02-26, confirming it is part of the current staging release.
Root Cause
When editing a split expense and adding waypoints, they are stored in modifiedWaypoints in the draft transaction. However, when the split transaction is finalized, these waypoints from modifiedWaypoints are not being properly transferred to the final transaction comment.waypoints structure. The ConfirmedRoute component reads from transaction.comment.waypoints for displaying the receipt, causing it to show stale waypoint data.
OSBotify commentedon Feb 26, 2026
Label Decision
No label changes are needed. The current labels are correct:
Next Steps
The PR author @ZhenjaHorbach should be engaged to either:
The bug is in /home/runner/_work/App/App/src/libs/actions/IOU/Split.ts where modifiedWaypoints need to be properly transferred to the split expense waypoints when the transaction is finalized.
MelvinBot commentedon Feb 26, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When splitting a distance expense, if the user adds a new waypoint to one of the split items (e.g., adding a 3rd stop), the receipt view only shows the original 2 waypoints while the distance field correctly shows all 3 waypoints.
What is the root cause of that problem?
The root cause is in
getMoneyRequestInformationinsrc/libs/actions/IOU/index.ts. When destructuringtransactionParams(lines 3350-3375), thewaypointsfield is not included in the destructuring, even though:Split.tscorrectly passeswaypoints: splitExpense.waypointsat lines 1186 and 1218RequestMoneyTransactionParamstype includeswaypoints?: WaypointCollection(line 471)Because
waypointsis never extracted, it is never forwarded tobuildOptimisticTransaction(lines 3509-3534). ThebuildOptimisticTransactionfunction inTransactionUtils/index.tswould correctly setcommentJSON.waypoints = waypoints(line 498-499) if it received them — but it doesn't.Subsequently,
fastMerge(existingTransaction, optimisticTransaction)at lines 3555-3572 merges the original parent transaction (with only 2 waypoints) into the child. Since the optimistic child hasundefinedforcomment.waypoints,fastMergepreserves the original parent's stale waypoints. The child transaction is then stored to Onyx with only the original 2 waypoints.The receipt view (
DistanceEReceiptatsrc/components/DistanceEReceipt.tsx:38) reads fromtransaction.comment.waypointson the persisted transaction, showing only 2 waypoints. Meanwhile, the distance edit view (IOURequestStepDistanceatsrc/pages/iou/request/step/IOURequestStepDistance.tsx:88-109) reads fromSPLIT_TRANSACTION_DRAFTwhich has the correct 3 waypoints.What changes do you think we should make in order to solve the problem?
In
getMoneyRequestInformationinsrc/libs/actions/IOU/index.ts:waypointsto the destructuring oftransactionParams(at line 3374, alongsidecustomUnit)waypointsin thetransactionParamsobject passed tobuildOptimisticTransaction(at line 3533, alongsidecustomUnit)This ensures that when
Split.tspasses modified waypoints for a split child, they flow through tobuildOptimisticTransaction, which setscommentJSON.waypointscorrectly. The optimistic child transaction will then have the updated waypoints, andfastMergewill preserve them (since source values take precedence over target values for defined keys).What alternative solutions did you explore? (Optional)
An alternative would be to have
DistanceEReceiptcheckmodifiedWaypointsin addition tocomment.waypoints, similar to howgetUpdatedTransactioninTransactionUtilshandles waypoint changes. However, this would be a workaround rather than fixing the actual data flow issue — the child transaction should have the correct waypoints from the start.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.puneetlath commentedon Feb 26, 2026
Demoting as discussed here: https://expensify.slack.com/archives/C01GTK53T8Q/p1772132775814079
@ZhenjaHorbach says it's a back-end issue @lakchote
lakchote commentedon Mar 16, 2026
We can close this one (see video test here).