Skip to content

[BT-114] Migrate Workspace - Xero #83842

Closed

Description

@mjasikowski

Description

Current State:

  • 5 routes for Xero export and advanced configuration
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
POLICY_ACCOUNTING_XERO_EXPORT_BANK_ACCOUNT_SELECT workspaces/:policyID/accounting/xero/export/bank-account-select
POLICY_ACCOUNTING_XERO_BILL_STATUS_SELECTOR workspaces/:policyID/accounting/xero/export/purchase-bill-status-selector
WORKSPACE_ACCOUNTING_XERO_AUTO_SYNC workspaces/:policyID/accounting/xero/advanced/autosync
WORKSPACE_ACCOUNTING_XERO_ACCOUNTING_METHOD workspaces/:policyID/accounting/xero/advanced/autosync/accounting-method
WORKSPACE_ACCOUNTING_CARD_RECONCILIATION_ACCOUNT workspaces/:policyID/accounting/:connection/card-reconciliation/account

Usages

POLICY_ACCOUNTING_XERO_EXPORT_BANK_ACCOUNT_SELECT:

  • Search for usages in Xero bank account select flow

POLICY_ACCOUNTING_XERO_BILL_STATUS_SELECTOR:

  • Search for usages in Xero bill status flow

WORKSPACE_ACCOUNTING_XERO_AUTO_SYNC:

  • Search for usages in Xero auto sync flow

WORKSPACE_ACCOUNTING_XERO_ACCOUNTING_METHOD:

  • Search for usages in Xero accounting method flow

WORKSPACE_ACCOUNTING_CARD_RECONCILIATION_ACCOUNT:

  • src/pages/workspace/accounting/reconciliation/ReconciliationAccountSettingsPage.tsx

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • POLICY_ACCOUNTING_XERO_EXPORT_BANK_ACCOUNT_SELECT
  • POLICY_ACCOUNTING_XERO_BILL_STATUS_SELECTOR
  • WORKSPACE_ACCOUNTING_XERO_AUTO_SYNC
  • WORKSPACE_ACCOUNTING_XERO_ACCOUNTING_METHOD
  • WORKSPACE_ACCOUNTING_CARD_RECONCILIATION_ACCOUNT
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 2, 2026
  2. 7 remaining items

  3. changed the title [-][Due for payment 2026-04-16] [BT-114] Migrate Workspace - Xero[/-] [+][BT-114] Migrate Workspace - Xero[/+] on Apr 9, 2026
  4. mjasikowski commented on Apr 9, 2026

    @mjasikowski
    ContributorAuthor

    Fixed price project, no payment needed

  5. huult commented on Apr 13, 2026

    @huult
    Contributor

    @mjasikowski #87342 All route paths have been migrated.

  6. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.58-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-20. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @huult requires payment through NewDot Manual Requests
  7. changed the title [-][BT-114] Migrate Workspace - Xero[/-] [+][Due for payment 2026-04-20] [BT-114] Migrate Workspace - Xero[/+] on Apr 13, 2026
  8. mananjadhav commented on Apr 13, 2026

    @mananjadhav
    Collaborator

    We're good to close this one.

  9. changed the title [-][Due for payment 2026-04-20] [BT-114] Migrate Workspace - Xero[/-] [+][BT-114] Migrate Workspace - Xero[/+] on Apr 14, 2026
  10. melvin-bot commented on Apr 29, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions