Skip to content

[BT-119] Migrate Merge Transaction #83847

Closed

Description

@mjasikowski

Description

Current State:

  • 4 routes for transaction merge flow
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (4):

Route Constant Path
MERGE_TRANSACTION_LIST_PAGE merge/:transactionID
MERGE_TRANSACTION_RECEIPT_PAGE merge/:transactionID/receipt
MERGE_TRANSACTION_DETAILS_PAGE merge/:transactionID/details
MERGE_TRANSACTION_CONFIRMATION_PAGE merge/:transactionID/confirmation

Usages

MERGE_TRANSACTION_LIST_PAGE:

  • src/libs/actions/MergeTransaction.ts
  • src/pages/TransactionMerge/ReceiptReviewPage.tsx
  • src/pages/TransactionMerge/DetailsReviewPage.tsx

MERGE_TRANSACTION_RECEIPT_PAGE:

  • Search for usages in merge receipt flow

MERGE_TRANSACTION_DETAILS_PAGE:

  • Search for usages in merge details flow

MERGE_TRANSACTION_CONFIRMATION_PAGE:

  • Search for usages in merge confirmation flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • MERGE_TRANSACTION_LIST_PAGE
  • MERGE_TRANSACTION_RECEIPT_PAGE
  • MERGE_TRANSACTION_DETAILS_PAGE
  • MERGE_TRANSACTION_CONFIRMATION_PAGE
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 2, 2026
  2. melvin-bot commented on May 14, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @mananjadhav, @mjasikowski, @huult eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  3. 18 remaining items

  4. melvin-bot commented on Jul 27, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  5. melvin-bot commented on Jul 29, 2026

    @melvin-bot

    @suneox / @huult

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.45-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-05. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  6. suneox commented on Jul 30, 2026

    @suneox
    Contributor

    Not overdue, the pr has been deployed to prod

  7. melvin-bot commented on Aug 4, 2026

    @melvin-bot

    @suneox Eep! 4 days overdue now. Issues have feelings too...

  8. melvin-bot commented on Aug 6, 2026

    @melvin-bot

    @suneox 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  9. huult commented on Aug 10, 2026

    @huult
    Contributor

    @mjasikowski #96897 (comment) we can close this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions