Skip to content

[BT-121] Migrate Money Request (Part 1) #83849

Closed

Description

@mjasikowski

Description

Current State:

  • 6 routes for new task completion and money request initiation
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (6):

Route Constant Path
NEW_TASK_DESCRIPTION new/task/description
NEW_TASK_SHARE_DESTINATION new/task/share-destination
MONEY_REQUEST_STEP_SEND_FROM create/:iouType/from/:transactionID/:reportID
MONEY_REQUEST_STEP_COMPANY_INFO create/:iouType/company-info/:transactionID/:reportID
MONEY_REQUEST_STEP_CONFIRMATION :action/:iouType/confirmation/:transactionID/:reportID
MONEY_REQUEST_STEP_AMOUNT :action/:iouType/amount/:transactionID/:reportID/:reportActionID?/:pageIndex?

Usages

NEW_TASK_DESCRIPTION:

  • src/pages/tasks/NewTaskDescriptionPage.tsx

NEW_TASK_SHARE_DESTINATION:

  • src/pages/tasks/TaskShareDestinationSelectorModal.tsx:37,117

MONEY_REQUEST_STEP_SEND_FROM:

  • Search for usages in money request flow

MONEY_REQUEST_STEP_COMPANY_INFO:

  • Search for usages in company info flow

MONEY_REQUEST_STEP_CONFIRMATION:

  • src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx:141
  • src/pages/iou/request/step/IOURequestStepScan/index.tsx:340,343,347,570,584
  • src/pages/iou/request/step/IOURequestStepScan/index.native.tsx:284,287,291,514,528
  • src/pages/iou/request/step/IOURequestStepReport.tsx:101
  • src/pages/iou/request/step/IOURequestStepParticipants.tsx:214,357,363
  • src/pages/iou/request/step/IOURequestStepHours.tsx:91
  • src/pages/iou/request/step/IOURequestStepDistanceOdometer.tsx:134,294,297,468
  • src/pages/iou/request/step/IOURequestStepDistanceMap.tsx:301,304,307,428

MONEY_REQUEST_STEP_AMOUNT:

  • Multiple usages in IOU request flow pages

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • NEW_TASK_DESCRIPTION
  • NEW_TASK_SHARE_DESTINATION
  • MONEY_REQUEST_STEP_SEND_FROM
  • MONEY_REQUEST_STEP_COMPANY_INFO
  • MONEY_REQUEST_STEP_CONFIRMATION
  • MONEY_REQUEST_STEP_AMOUNT
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 2, 2026
  2. melvin-bot commented on May 14, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @mananjadhav, @mjasikowski, @huult eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  3. 21 remaining items

  4. melvin-bot commented on Jul 29, 2026

    @melvin-bot

    @suneox / @huult

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.45-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-05. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  5. suneox commented on Jul 30, 2026

    @suneox
    Contributor

    Not overdue, the pr has been deployed to prod

  6. melvin-bot commented on Aug 4, 2026

    @melvin-bot

    @suneox Eep! 4 days overdue now. Issues have feelings too...

  7. melvin-bot commented on Aug 6, 2026

    @melvin-bot

    @suneox Still overdue 6 days?! Let's take care of this!

  8. suneox commented on Aug 10, 2026

    @suneox
    Contributor

    MONEY_REQUEST_STEP_CONFIRMATION is not migratable MONEY_REQUEST_STEP_AMOUNT is not migratable

    These keys were only renamed, but it looks like we aren't migrating them.

    cc: @huult

  9. huult commented on Aug 11, 2026

    @huult
    Contributor

    MONEY_REQUEST_STEP_CONFIRMATION isn't a good candidate for dynamic-route migration because its route params are core wizard state, and back navigation depends on transaction/wizard state rather than simply stripping a suffix.

    MONEY_REQUEST_STEP_AMOUNT isn't a good dynamic-route candidate because its params are core wizard state, and backTo affects both backward navigation and the forward submission flow. It doesn't follow the current path + suffix pattern that dynamic routes are designed for.

    @suneox MONEY_REQUEST_STEP_CONFIRMATION and MONEY_REQUEST_STEP_AMOUNT aren't good candidates for dynamic-route migration, so we can't migrate them.

  10. huult commented on Aug 12, 2026

    @huult
    Contributor

    @mjasikowski #96900 (comment) we can close this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions