Repository navigation
Closed
Labels
DailyKSv2KSv2InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.Skips all the payment process steps for an issue. Use it for fixed-price projects.
Description
Description
Current State:
- 6 routes for new task completion and money request initiation
- These routes use
backToparameter for return navigation
Implementation:
- Replace
getRoute(..., backTo)withcreateDynamicRoute() - Add source screens to
entryScreensarray - Remove
backToparameter from route definitions - Test forward/back navigation
Scope
Routes (6):
| Route Constant | Path |
|---|---|
NEW_TASK_DESCRIPTION |
new/task/description |
NEW_TASK_SHARE_DESTINATION |
new/task/share-destination |
MONEY_REQUEST_STEP_SEND_FROM |
create/:iouType/from/:transactionID/:reportID |
MONEY_REQUEST_STEP_COMPANY_INFO |
create/:iouType/company-info/:transactionID/:reportID |
MONEY_REQUEST_STEP_CONFIRMATION |
:action/:iouType/confirmation/:transactionID/:reportID |
MONEY_REQUEST_STEP_AMOUNT |
:action/:iouType/amount/:transactionID/:reportID/:reportActionID?/:pageIndex? |
Usages
NEW_TASK_DESCRIPTION:
src/pages/tasks/NewTaskDescriptionPage.tsx
NEW_TASK_SHARE_DESTINATION:
src/pages/tasks/TaskShareDestinationSelectorModal.tsx:37,117
MONEY_REQUEST_STEP_SEND_FROM:
- Search for usages in money request flow
MONEY_REQUEST_STEP_COMPANY_INFO:
- Search for usages in company info flow
MONEY_REQUEST_STEP_CONFIRMATION:
src/pages/iou/request/step/IOURequestStepTaxAmountPage.tsx:141src/pages/iou/request/step/IOURequestStepScan/index.tsx:340,343,347,570,584src/pages/iou/request/step/IOURequestStepScan/index.native.tsx:284,287,291,514,528src/pages/iou/request/step/IOURequestStepReport.tsx:101src/pages/iou/request/step/IOURequestStepParticipants.tsx:214,357,363src/pages/iou/request/step/IOURequestStepHours.tsx:91src/pages/iou/request/step/IOURequestStepDistanceOdometer.tsx:134,294,297,468src/pages/iou/request/step/IOURequestStepDistanceMap.tsx:301,304,307,428
MONEY_REQUEST_STEP_AMOUNT:
- Multiple usages in IOU request flow pages
Files to modify:
src/ROUTES.ts- Update route definitionssrc/libs/Navigation/types.ts- RemovebackTofrom params- Components listed above
Migration Progress
-
NEW_TASK_DESCRIPTION -
NEW_TASK_SHARE_DESTINATION -
MONEY_REQUEST_STEP_SEND_FROM -
MONEY_REQUEST_STEP_COMPANY_INFO -
MONEY_REQUEST_STEP_CONFIRMATION -
MONEY_REQUEST_STEP_AMOUNT
Issue Owner
Current Issue Owner: @suneoxMetadata
Metadata
Assignees
Labels
DailyKSv2KSv2InternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.Skips all the payment process steps for an issue. Use it for fixed-price projects.
Activity
melvin-bot commentedon May 14, 2026
This issue has not been updated in over 15 days. @mananjadhav, @mjasikowski, @huult eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
21 remaining items
melvin-bot commentedon Jul 29, 2026
@suneox / @huult
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.45-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-05. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
suneox commentedon Jul 30, 2026
Not overdue, the pr has been deployed to prod
melvin-bot commentedon Aug 4, 2026
@suneox Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Aug 6, 2026
@suneox Still overdue 6 days?! Let's take care of this!
suneox commentedon Aug 10, 2026
These keys were only renamed, but it looks like we aren't migrating them.
cc: @huult
huult commentedon Aug 11, 2026
MONEY_REQUEST_STEP_CONFIRMATION isn't a good candidate for dynamic-route migration because its route params are core wizard state, and back navigation depends on transaction/wizard state rather than simply stripping a suffix.
MONEY_REQUEST_STEP_AMOUNT isn't a good dynamic-route candidate because its params are core wizard state, and backTo affects both backward navigation and the forward submission flow. It doesn't follow the current path + suffix pattern that dynamic routes are designed for.
@suneox
MONEY_REQUEST_STEP_CONFIRMATIONandMONEY_REQUEST_STEP_AMOUNTaren't good candidates for dynamic-route migration, so we can't migrate them.huult commentedon Aug 12, 2026
@mjasikowski #96900 (comment) we can close this ticket