Skip to content

[BT-126] Migrate Travel (Part 1) #83854

Closed

Description

@mjasikowski

Description

Current State:

  • 5 routes for travel terms and domain selection
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
TRAVEL_TCS travel/terms/:domain/accept
TRAVEL_UPGRADE travel/upgrade
TRAVEL_DOMAIN_SELECTOR travel/domain-selector
TRAVEL_DOMAIN_PERMISSION_INFO travel/domain-permission/:domain/info
TRAVEL_PUBLIC_DOMAIN_ERROR travel/public-domain-error

Usages

TRAVEL_TCS:

  • Search for usages in travel terms flow

TRAVEL_UPGRADE:

  • src/components/BookTravelButton.tsx:106
  • src/pages/Travel/TravelUpgrade.tsx

TRAVEL_DOMAIN_SELECTOR:

  • src/components/BookTravelButton.tsx:155
  • src/pages/Travel/DomainSelectorPage.tsx

TRAVEL_DOMAIN_PERMISSION_INFO:

  • Search for usages in domain permission flow

TRAVEL_PUBLIC_DOMAIN_ERROR:

  • Search for usages in public domain error flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • TRAVEL_TCS
  • TRAVEL_UPGRADE
  • TRAVEL_DOMAIN_SELECTOR
  • TRAVEL_DOMAIN_PERMISSION_INFO
  • TRAVEL_PUBLIC_DOMAIN_ERROR
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 2, 2026
  2. melvin-bot commented on Apr 29, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @mananjadhav, @mjasikowski, @huult eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  3. changed the title [-][BT-126] Migrate Travel (Part 1)[/-] [+][Due for payment 2026-05-22] [BT-126] Migrate Travel (Part 1)[/+] on May 15, 2026
  4. melvin-bot commented on May 15, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  5. melvin-bot commented on May 15, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.74-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-22. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @huult requires payment through NewDot Manual Requests
  6. changed the title [-][Due for payment 2026-05-22] [BT-126] Migrate Travel (Part 1)[/-] [+][BT-126] Migrate Travel (Part 1)[/+] on May 27, 2026
  7. mjasikowski commented on May 27, 2026

    @mjasikowski
    ContributorAuthor

    No payment needed, fixed price project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions