Skip to content

[BT-138] Migrate Workspace - Categories Settings + Tags #83860

Closed

Description

@mjasikowski

Description

Current State:

  • 5 routes for category settings and workspace tags
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
SETTINGS_CATEGORY_EDIT settings/:policyID/category/:categoryName/edit
SETTINGS_CATEGORY_SETTINGS settings/:policyID/category/:categoryName
WORKSPACE_TAGS workspaces/:policyID/tags
WORKSPACE_TAGS_SETTINGS workspaces/:policyID/tags/settings
WORKSPACE_TAG_CREATE workspaces/:policyID/tags/new

Usages

SETTINGS_CATEGORY_EDIT:

  • Search for usages in settings category edit flow

SETTINGS_CATEGORY_SETTINGS:

  • Search for usages in settings category settings flow

WORKSPACE_TAGS:

  • src/pages/workspace/tags/ImportMultiLevelTagsSettingsPage.tsx:71
  • src/pages/workspace/rules/IndividualExpenseRulesSection.tsx:59
  • src/libs/ReportUtils.ts:11549
  • src/pages/workspace/tags/ImportedTagsPage.tsx:132
  • src/pages/workspace/tags/ImportedMultiLevelTagsPage.tsx:48
  • src/pages/workspace/rules/RulesBillableDefaultPage.tsx:55

WORKSPACE_TAGS_SETTINGS:

  • Search for usages in tags settings flow

WORKSPACE_TAG_CREATE:

  • Search for usages in tag creation flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • SETTINGS_CATEGORY_EDIT
  • SETTINGS_CATEGORY_SETTINGS
  • WORKSPACE_TAGS
  • WORKSPACE_TAGS_SETTINGS
  • WORKSPACE_TAG_CREATE
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 2, 2026
  2. melvin-bot commented on Apr 27, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @mananjadhav, @mjasikowski, @huult eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  3. 20 remaining items

  4. changed the title [-][BT-138] Migrate Workspace - Categories Settings + Tags[/-] [+][Due for payment 2026-07-02] [BT-138] Migrate Workspace - Categories Settings + Tags[/+] on Jun 25, 2026
  5. melvin-bot commented on Jun 25, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  6. melvin-bot commented on Jun 25, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.19-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-02. 🎊

    For reference, here are some details about the assignees on this issue:

    • @suneox requires payment through NewDot Manual Requests
    • @huult requires payment through NewDot Manual Requests
  7. melvin-bot commented on Jun 30, 2026

    @melvin-bot

    @suneox Eep! 4 days overdue now. Issues have feelings too...

  8. huult commented on Jul 2, 2026

    @huult
    Contributor

    @mjasikowski we can close this ticket

  9. melvin-bot commented on Jul 2, 2026

    @melvin-bot

    @suneox 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  10. melvin-bot commented on Jul 3, 2026

    @melvin-bot

    @suneox 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  11. melvin-bot commented on Jul 3, 2026

    @melvin-bot

    @suneox Still overdue 6 days?! Let's take care of this!

  12. changed the title [-][Due for payment 2026-07-02] [BT-138] Migrate Workspace - Categories Settings + Tags[/-] [+][BT-138] Migrate Workspace - Categories Settings + Tags[/+] on Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions