Skip to content

[BT-139] Migrate Workspace - Tags (Part 3) #83861

Closed

Description

@mjasikowski

Description

Current State:

  • 5 routes for workspace tag list and settings tags
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
WORKSPACE_TAG_LIST_VIEW workspaces/:policyID/tag-list/:orderWeight
WORKSPACE_TAGS_IMPORT workspaces/:policyID/tags/import
WORKSPACE_TAGS_IMPORTED workspaces/:policyID/tags/imported
SETTINGS_TAGS_ROOT settings/:policyID/tags
SETTINGS_TAGS_SETTINGS settings/:policyID/tags/settings

Usages

WORKSPACE_TAG_LIST_VIEW:

  • src/pages/workspace/tags/WorkspaceViewTagsPage.tsx

WORKSPACE_TAGS_IMPORT:

  • src/pages/workspace/tags/ImportTagsOptionsPage.tsx:83

WORKSPACE_TAGS_IMPORTED:

  • Search for usages in imported tags flow

SETTINGS_TAGS_ROOT:

  • src/pages/workspace/tags/ImportTagsOptionsPage.tsx:83,210,248,268
  • src/pages/iou/request/step/IOURequestStepTag.tsx:188
  • src/pages/workspace/tags/WorkspaceViewTagsPage.tsx:113,353
  • src/pages/workspace/tags/ImportedTagsPage.tsx:132

SETTINGS_TAGS_SETTINGS:

  • Search for usages in settings tags settings flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • WORKSPACE_TAG_LIST_VIEW
  • WORKSPACE_TAGS_IMPORT
  • WORKSPACE_TAGS_IMPORTED
  • SETTINGS_TAGS_ROOT
  • SETTINGS_TAGS_SETTINGS
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 2, 2026
  2. melvin-bot commented on May 18, 2026

    @melvin-bot

    @mananjadhav, @mjasikowski, @huult, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  3. huult commented on May 19, 2026

    @huult
    Contributor

    @mjasikowski could you re-open this ticket?

  4. 13 remaining items

  5. melvin-bot commented on Jul 9, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  6. melvin-bot commented on Jul 9, 2026

    @melvin-bot
  7. melvin-bot commented on Jul 14, 2026

    @melvin-bot

    @suneox Eep! 4 days overdue now. Issues have feelings too...

  8. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    @suneox Still overdue 6 days?! Let's take care of this!

  9. huult commented on Jul 20, 2026

    @huult
    Contributor

    @mjasikowski We can close this ticket because all migratable routes have been migrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2InternalRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions