Skip to content

[BT-140] Migrate Workspace - Tags Settings #83862

Closed

Description

@mjasikowski

Description

Current State:

  • 5 routes for settings tags configuration
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
SETTINGS_TAG_CREATE settings/:policyID/tags/new
SETTINGS_TAGS_EDIT settings/:policyID/tags/:orderWeight/edit
SETTINGS_TAG_SETTINGS settings/:policyID/tag/:orderWeight/:tagName
SETTINGS_TAG_EDIT settings/:policyID/tag/:orderWeight/:tagName/edit
SETTINGS_TAG_GL_CODE settings/:policyID/tag/:orderWeight/:tagName/gl-code

Usages

SETTINGS_TAG_CREATE:

  • Search for usages in settings tag creation flow

SETTINGS_TAGS_EDIT:

  • Search for usages in settings tags edit flow

SETTINGS_TAG_SETTINGS:

  • src/pages/workspace/tags/TagGLCodePage.tsx:46

SETTINGS_TAG_EDIT:

  • Search for usages in settings tag edit flow

SETTINGS_TAG_GL_CODE:

  • Search for usages in settings tag GL code flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • SETTINGS_TAG_CREATE
  • SETTINGS_TAGS_EDIT
  • SETTINGS_TAG_SETTINGS
  • SETTINGS_TAG_EDIT
  • SETTINGS_TAG_GL_CODE
Issue OwnerCurrent Issue Owner: @mananjadhav

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 2, 2026
  2. melvin-bot commented on Apr 24, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @mananjadhav, @mjasikowski, @huult eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  3. 21 remaining items

  4. melvin-bot commented on May 22, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  5. melvin-bot commented on May 22, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.79-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-29. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @huult requires payment through NewDot Manual Requests
  6. melvin-bot commented on May 26, 2026

    @melvin-bot

    @mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. changed the title [-][Due for payment 2026-05-29] [BT-140] Migrate Workspace - Tags Settings[/-] [+][BT-140] Migrate Workspace - Tags Settings[/+] on May 27, 2026
  8. mjasikowski commented on May 27, 2026

    @mjasikowski
    ContributorAuthor

    No payment needed, fixed price project.

  9. melvin-bot commented on May 28, 2026

    @melvin-bot

    @mananjadhav Huh... This is 4 days overdue. Who can take care of this?

  10. huult commented on May 29, 2026

    @huult
    Contributor

    #90453 (comment) We can close this ticket

  11. melvin-bot commented on Jun 1, 2026

    @melvin-bot

    @mananjadhav Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  12. huult commented on Jun 2, 2026

    @huult
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions