Skip to content

[BT-143] Migrate Workspace - Workflows + Members #83865

Closed

Description

@mjasikowski

Description

Current State:

  • 5 routes for workspace workflows and owner change
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
WORKSPACE_WORKFLOWS_APPROVALS_EXPENSES_FROM workspaces/:policyID/workflows/approvals/expenses-from
WORKSPACE_PAY_AND_DOWNGRADE workspaces/pay-and-downgrade
WORKSPACE_OWNER_CHANGE_SUCCESS workspaces/:policyID/change-owner/:accountID/success
WORKSPACE_OWNER_CHANGE_ERROR workspaces/:policyID/change-owner/:accountID/failure
WORKSPACE_OWNER_CHANGE_CHECK workspaces/:policyID/change-owner/:accountID/:error

Usages

WORKSPACE_WORKFLOWS_APPROVALS_EXPENSES_FROM:

  • Search for usages in workflow approvals flow

WORKSPACE_PAY_AND_DOWNGRADE:

  • src/hooks/usePayAndDowngrade.ts

WORKSPACE_OWNER_CHANGE_SUCCESS:

  • src/pages/workspace/members/WorkspaceOwnerChangeWrapperPage.tsx:90

WORKSPACE_OWNER_CHANGE_ERROR:

  • Search for usages in owner change error flow

WORKSPACE_OWNER_CHANGE_CHECK:

  • Search for usages in owner change check flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • WORKSPACE_WORKFLOWS_APPROVALS_EXPENSES_FROM
  • WORKSPACE_PAY_AND_DOWNGRADE
  • WORKSPACE_OWNER_CHANGE_SUCCESS
  • WORKSPACE_OWNER_CHANGE_ERROR
  • WORKSPACE_OWNER_CHANGE_CHECK
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 2, 2026
  2. melvin-bot commented on Jun 8, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @mananjadhav, @mjasikowski, @huult eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  3. 11 remaining items

  4. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  5. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.34-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-23. 🎊

    For reference, here are some details about the assignees on this issue:

    • @suneox requires payment through NewDot Manual Requests
    • @huult requires payment through NewDot Manual Requests
  6. huult commented on Jul 20, 2026

    @huult
    Contributor

    @mjasikowski All route paths have been migrated. If there are no regressions over the next 3 days, we can close this ticket.

  7. melvin-bot commented on Jul 21, 2026

    @melvin-bot

    @suneox Huh... This is 4 days overdue. Who can take care of this?

  8. melvin-bot commented on Jul 23, 2026

    @melvin-bot

    @suneox 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  9. huult commented on Jul 24, 2026

    @huult
    Contributor

    @mjasikowski All route paths have been migrated. If there are no regressions over the next 3 days, we can close this ticket.

    @mjasikowski we can close this ticket

  10. huult commented on Jul 27, 2026

    @huult
    Contributor

    @mjasikowski All route paths have been migrated. If there are no regressions over the next 3 days, we can close this ticket.

    @mjasikowski we can close this ticket

    cc @mjasikowski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions