Skip to content

[BT-148] Migrate Onboarding (Part 1) #83870

Closed

Description

@mjasikowski

Description

Current State:

  • 5 routes for onboarding flow start
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
ONBOARDING_ROOT onboarding
ONBOARDING_PERSONAL_DETAILS onboarding/personal-details
ONBOARDING_PRIVATE_DOMAIN onboarding/private-domain
ONBOARDING_EMPLOYEES onboarding/employees
ONBOARDING_ACCOUNTING onboarding/accounting

Usages

ONBOARDING_ROOT:

  • Search for usages in onboarding entry flow

ONBOARDING_PERSONAL_DETAILS:

  • Search for usages in personal details flow

ONBOARDING_PRIVATE_DOMAIN:

  • Search for usages in private domain flow

ONBOARDING_EMPLOYEES:

  • Search for usages in employees selection flow

ONBOARDING_ACCOUNTING:

  • Search for usages in accounting selection flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • ONBOARDING_ROOT
  • ONBOARDING_PERSONAL_DETAILS
  • ONBOARDING_PRIVATE_DOMAIN
  • ONBOARDING_EMPLOYEES
  • ONBOARDING_ACCOUNTING
Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 2, 2026
  2. 36 remaining items

  3. melvin-bot commented on Jul 27, 2026

    @melvin-bot

    This issue has not been updated in over 15 days. @mjasikowski, @suneox, @huult eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  4. huult commented on Jul 29, 2026

    @huult
    Contributor

    Only 3 routes that use backTo need to be migrated: ONBOARDING_PERSONAL_DETAILS, ONBOARDING_PRIVATE_DOMAIN, and ONBOARDING_EMPLOYEES.

  5. huult commented on Aug 14, 2026

    @huult
    Contributor

    Started with 3 onboarding routes, but all three are blocked from migration. ONBOARDING_PERSONAL_DETAILS, ONBOARDING_PRIVATE_DOMAIN, and ONBOARDING_EMPLOYEES are fixed sibling steps in the onboarding wizard, with state-driven navigation and backTo carried across the flow, so their back destinations cannot be derived from the URL. Therefore, they don't fit the current dynamic-route mechanism and would require a separate onboarding navigation refactor.

    @collectioneur Could you advise on this? Can we skip migrating these routes?

  6. collectioneur commented on Aug 14, 2026

    @collectioneur
    Contributor

    Yes, I’ve looked into it a couple of days ago, and I agree that we need a different strategy here, since these routes are built a little differently and don’t quite fit the dynamic routes use case

  7. huult commented on Aug 14, 2026

    @huult
    Contributor

    @mjasikowski Per this comment, I think we can close this ticket since there's nothing we need to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffSkip PaymentSkips all the payment process steps for an issue. Use it for fixed-price projects.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions