You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-14] [Due for payment 2026-03-13] [$250] Distance - "Tax no longer valid" is shown on Tax field after changing distance rate #84006
Version Number: 9.3.28-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#74967 Email or phone of affected tester (no customers):sjiondsjndosijdonijso@gmaal.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Enable Taxes and Distance rates.
Add two tax rates - 5% and 10 %.
Add a new distance rates - 1.00 / mile.
Enable Track tax in Distance rates settings.
Assign 5% tax rate to 0.725 / mile (default rate) with any tax reclaimable amount.
Assign 10% tax rate to 1.00 / mile with any tax reclaimable amount.
Go to staging.new.expensify.com
Go to self DM.
Create a manual distance expense with the default distance rate (0,725 / mile).
Click Submit it to someone.
Select workspace chat.
On confirm page, click Rate.
Select another rate (1.00 / mile).
Click Create expense.
Expected Result:
Expense will be created without issue.
Actual Result:
"Tax no longer valid" is shown on Tax field when it cannot be edited.
User is blocked from submitting the distance expense.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #74967 - "Fix - [Unreported] Add distance rate to the distance expenses tracked in selfDM" by @FitseTLT (High confidence) Related Issues: None
Recommendation: REVERT
PR #74967 introduced distance rate selection for track expenses in selfDM but did not properly handle tax validation when changing rates. The tax validation uses the wrong policy reference, causing valid tax codes to be rejected.
Labels: No label changes made (keeping DeployBlockerCash as this is a frontend issue)
📋 Detailed Analysis
Evidence
The issue occurs specifically when:
User creates a distance track expense in selfDM with the default rate (e.g., 0.725/mile with 5% tax)
On the confirmation page, user changes to a different rate (e.g., 1.00/mile with 10% tax)
The tax code is updated correctly to match the new rate
However, validation fails with "Tax no longer valid" error
When changing the distance rate for a track expense in selfDM:
The new rate is selected from policyForMovingExpenses (the workspace that owns the distance rates)
The transaction's taxCode is correctly updated to match the new rate's tax (from policyForMovingExpenses)
But the validation checks if that taxCode exists in policy variable
For track expenses, policy is determined by usePolicyForTransaction which returns policyForMovingExpenses
However, there's a mismatch: the tax code from the new rate (stored in policyForMovingExpenses.customUnits.rates[rateID].attributes.taxRateExternalID) is being validated against policy.taxRates
The issue is that when policyForMovingExpenses is passed to getRate() for displaying the rate, but the validation still uses just policy to check if the tax is valid. The PR introduced the ability to use workspace distance rates in selfDM track expenses but didn't update the tax validation logic to use the correct policy reference (policyForMovingExpenses instead of policy for track expenses moving to workspace).
Label Decision: Keeping DeployBlockerCash label. This is a frontend bug in App that requires PR #74967 to be reverted. The feature does not exist in production yet, so we must block the App deploy to prevent this broken functionality from shipping.
changed the title [-][$250] Distance - "Tax no longer valid" is shown on Tax field after changing distance rate[/-][+][Due for payment 2026-03-13] [$250] Distance - "Tax no longer valid" is shown on Tax field after changing distance rate[/+]on Mar 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@parasharrajat / @FitseTLT@dylanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-03-13] [$250] Distance - "Tax no longer valid" is shown on Tax field after changing distance rate[/-][+][Due for payment 2026-04-14] [Due for payment 2026-03-13] [$250] Distance - "Tax no longer valid" is shown on Tax field after changing distance rate[/+]on Apr 7, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@parasharrajat / @FitseTLT The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 3, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #74967
melvin-bot commentedon Mar 3, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Mar 3, 2026
Triggered auto assignment to @mallenexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Mar 3, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 3, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #74967 - "Fix - [Unreported] Add distance rate to the distance expenses tracked in selfDM" by @FitseTLT (High confidence)
Related Issues: None
Recommendation: REVERT
PR #74967 introduced distance rate selection for track expenses in selfDM but did not properly handle tax validation when changing rates. The tax validation uses the wrong policy reference, causing valid tax codes to be rejected.
Labels: No label changes made (keeping DeployBlockerCash as this is a frontend issue)
📋 Detailed Analysis
Evidence
The issue occurs specifically when:
Verification
PR #74967 modified several key files:
src/components/MoneyRequestConfirmationList.tsx- Tax validation happens here at line 1035src/libs/DistanceRequestUtils.ts- AddedpolicyForMovingExpensesparameter togetRatefunctionsrc/hooks/usePolicyForTransaction.ts- Modified to returnpolicyForMovingExpensesfor track expensessrc/pages/iou/request/step/IOURequestStepDistanceRate.tsx- Rate selection page where tax is updatedRoot Cause
The bug is in
src/components/MoneyRequestConfirmationList.tsxat line 1035:When changing the distance rate for a track expense in selfDM:
policyForMovingExpenses(the workspace that owns the distance rates)taxCodeis correctly updated to match the new rate's tax (frompolicyForMovingExpenses)taxCodeexists inpolicyvariablepolicyis determined byusePolicyForTransactionwhich returnspolicyForMovingExpensespolicyForMovingExpenses.customUnits.rates[rateID].attributes.taxRateExternalID) is being validated againstpolicy.taxRatesThe issue is that when
policyForMovingExpensesis passed togetRate()for displaying the rate, but the validation still uses justpolicyto check if the tax is valid. The PR introduced the ability to use workspace distance rates in selfDM track expenses but didn't update the tax validation logic to use the correct policy reference (policyForMovingExpensesinstead ofpolicyfor track expenses moving to workspace).OSBotify commentedon Mar 3, 2026
Label Decision: Keeping
DeployBlockerCashlabel. This is a frontend bug in App that requires PR #74967 to be reverted. The feature does not exist in production yet, so we must block the App deploy to prevent this broken functionality from shipping.24 remaining items
[-][$250] Distance - "Tax no longer valid" is shown on Tax field after changing distance rate[/-][+][Due for payment 2026-03-13] [$250] Distance - "Tax no longer valid" is shown on Tax field after changing distance rate[/+]melvin-bot commentedon Mar 6, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 6, 2026
@parasharrajat / @FitseTLT @dylanexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 6, 2026
Current assignee @dylanexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.
melvin-bot commentedon Apr 7, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
jponikarchuk commentedon Apr 7, 2026
Deploy Blocker #87207 was identified to be related to the PR #84136 that attempted to fix this issue.
[-][Due for payment 2026-03-13] [$250] Distance - "Tax no longer valid" is shown on Tax field after changing distance rate[/-][+][Due for payment 2026-04-14] [Due for payment 2026-03-13] [$250] Distance - "Tax no longer valid" is shown on Tax field after changing distance rate[/+]melvin-bot commentedon Apr 7, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.53-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 7, 2026
@parasharrajat / @FitseTLT The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]