Skip to content

[Due for payment 2026-03-13] [$250] Merge - Amount is cutted off while merging expenses with long merchant, tags and category. #84032

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.28.1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #82967
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has a workspace with "Tags" and "Categories" enabled.
Prerequisite 2: At least one "Tag" and one "Category" with long names saved.

  1. Open the staging.new.expensify.com website.
  2. Open any workspace chat.
  3. Create two manual expenses with long merchant names, description, tags and categories. (Text has to be long enough to exceed one line)
  4. Open the report of the just created expenses.
  5. Select one of the expenses and click on dropdown menu.
  6. Select "Merge"
  7. Note that amount of the second expense, is displayed cutted off in elegible expenses list.
  8. Note that "Tag" does not fit the expense preview either and tag icon overlaps the expense category.

Expected Result:

All the expense details should be completelly visible on preview on elegible expenses list, while merging expenses with long merchant names, categories and tags.

Actual Result:

Amount and tag are displayed cutted off on expense preview on elegible expenses list, while merging expenses with long merchant names, categories and tags. Also, tag icon overlaps part of the expense category.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @lydiabarclay
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022028824425378680998
  • Upwork Job ID: 2028824425378680998
  • Last Price Increase: 2026-03-03

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 3, 2026
  2. melvin-bot commented on Mar 3, 2026

    @melvin-bot

    @dangrous recently merged #82967, but they are OOO right now, so I'll auto-assign someone else.

  3. melvin-bot commented on Mar 3, 2026

    @melvin-bot

    Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Mar 3, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Mar 3, 2026

    @melvin-bot

    Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  6. melvin-bot commented on Mar 3, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. OSBotify commented on Mar 3, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #82967 - "feat: [CFI] Allow Multi-Line Row Wrapping in Expense Previews (Classic Parity)" by @TaduJR (High confidence)
    Related Issues: #81419

    Recommendation: REVERT

    PR #82967 should be reverted. While the change was intended to add Classic parity by allowing 2 lines of text for merchant, description, category, and tag fields, it introduced layout issues in the merge expenses flow where the amount and tag fields are cut off due to insufficient space allocation.

    Labels: No label changes needed - keeping DeployBlockerCash since this is a Frontend bug caused by an App PR.

    📋 Detailed Analysis

    Evidence

    Verification

    The merge expenses flow uses MergeTransactionItem component which renders TransactionItemRow with shouldUseNarrowLayout prop set to true. This component was directly modified by PR #82967.

    Files affected by the bug:

    • /home/runner/_work/App/App/src/components/TransactionItemRow/index.tsx
    • /home/runner/_work/App/App/src/components/TransactionItemRow/DataCells/CategoryCell.tsx
    • /home/runner/_work/App/App/src/components/TransactionItemRow/DataCells/TagCell.tsx
    • /home/runner/_work/App/App/src/components/TransactionItemRow/DataCells/MerchantCell.tsx

    Confirmation: PR #82967 modified all of these files, changing:

    1. numberOfLines from 1 to 2 for merchant, category, and tag text
    2. Removed maxHeight5 constraint on line 664
    3. Changed minHeight4 to minHeight6 on the category/tag row (line 727)
    4. Added preWrap styling to allow text wrapping

    Root Cause

    PR #82967 changed expense preview rows to display up to 2 lines of text (instead of 1) for merchant, description, category, and tag fields to achieve Classic parity. However, these changes increased the vertical space requirements for each row.

    In the merge expenses flow, which uses a narrow layout with constrained space, the 2-line text causes:

    1. The amount field to be pushed down and cut off
    2. The tag icon to overlap with the category text
    3. Overall layout overflow where content exceeds the visible area

    The PR did not account for different layout contexts (standard expense list vs. merge flow) where space constraints differ significantly.

  8. 13 remaining items

  9. m-natarajan commented on Mar 3, 2026

    @m-natarajan

    Passed, Chrome / v9.3.28-4

    Screen.Recording.2026-03-03.at.20.24.01.mp4
  10. MonilBhavsar commented on Mar 4, 2026

    @MonilBhavsar
    Contributor

    Thanks, closing!

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 6, 2026
  12. changed the title [-][$250] Merge - Amount is cutted off while merging expenses with long merchant, tags and category.[/-] [+][Due for payment 2026-03-13] [$250] Merge - Amount is cutted off while merging expenses with long merchant, tags and category.[/+] on Mar 6, 2026
  13. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.31-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hoangzinh requires payment through NewDot Manual Requests
    • @TaduJR requires payment (Needs manual offer from BZ)
  15. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    @hoangzinh @lydiabarclay The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. melvin-bot commented on Mar 6, 2026

    @melvin-bot

    Current assignee @lydiabarclay is eligible for the Awaiting Payment assigner, not assigning anyone new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions