You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Domains - Long email overflows on Report suspicious activity RHP #84214
Version Number: 9.3.31-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#78372 Email or phone of affected tester (no customers):applausetester@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Workspace Settings
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This PR introduced a new "Report suspicious activity" feature for domain members. The issue occurs because long email addresses in the confirmation prompt are not properly wrapped, causing content overflow. Since this is a new feature that does not exist in production and reverting will not impact existing functionality, reverting is the safest approach to unblock the deploy.
Labels: Keeping DeployBlockerCash - this is a Frontend bug that requires an App PR fix or revert
Evidence
PR #78372 added the DomainReportSuspiciousActivityPage.tsx file which renders the suspicious activity prompt. The issue is reproducible on staging only (v9.3.31-0) and matches the new feature added by this PR.
Verification
The bug affects the Report suspicious activity RHP for domain members. Key files modified:
src/pages/domain/Members/DomainReportSuspiciousActivityPage.tsx (new file)
The prompt renders via RenderHTML component with email in strong tags.
Root Cause
The RenderHTML component sets contentWidth but the strong style does not include word-wrapping properties like wordBreak or overflowWrap. This causes long email addresses to overflow their container, pushing content below it out of bounds.
Please re-state the problem that we are trying to solve in this issue.
On the "Report suspicious activity" RHP for domain members, long email addresses overflow their container horizontally, causing the content below to also overflow.
What is the root cause of that problem?
The DomainReportSuspiciousActivityPage uses the RenderHTML component to render a prompt that embeds the member's email inside <strong> HTML tags:
// en.ts:8560-8561reportSuspiciousActivityPrompt: (email: string)=>`Are you sure? This will lock <strong>${email}'s</strong> account. <br /><br /> ...`,
The RenderHTML component uses react-native-render-html, and the base text style (webViewStyles.baseFontStyle at src/styles/index.ts:243-250) has no wordBreak property:
The <strong> tag style (src/styles/index.ts:302-305) also has no wordBreak. Without this property, CSS defaults to wordBreak: 'normal', which only breaks text at whitespace. Long email addresses have no whitespace, so they render as a single unbreakable text run that overflows the container.
The container View in LockAccountPageBase.tsx:92 has flex: 1 and mh5 margins but no overflow control for the text child.
Note: The self-lock version (LockAccountPage.tsx) uses plain <Text> components (not RenderHTML), which handle wrapping natively and are not affected.
What changes do you think we should make in order to solve the problem?
Add ...wordBreak.breakWord to webViewStyles.baseFontStyle in src/styles/index.ts. This pattern is already used in 14+ other styles in the same file (e.g., emojiSuggestionsText, chat message text styles). On native, wordBreak.breakWord resolves to an empty object (src/styles/utils/wordBreak/index.native.ts), so this change is a no-op on mobile and only affects web.
This ensures all HTML content rendered via react-native-render-html will break long words to prevent overflow, matching the behavior already applied to most other text elements in the app.
What alternative solutions did you explore? (Optional)
Scoped fix on LockAccountPageBase.tsx container — Adding wordBreak to just the wrapping <View> in LockAccountPageBase.tsx:92. This is more targeted but less robust, as other RenderHTML usages throughout the app could have the same issue with long unbreakable strings.
Replace RenderHTML with plain <Text> components — Similar to how the self-lock version (LockAccountPage.tsx) works. This would require restructuring the translation strings and adding React elements for bold text, which is more invasive and doesn't fix the root cause for other RenderHTML usages.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
Activity
melvin-bot commentedon Mar 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #78372
melvin-bot commentedon Mar 4, 2026
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Mar 4, 2026
Triggered auto assignment to @lydiabarclay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Mar 4, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 4, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #78372 - "[Release 3.3] [Domain Control] Report suspicious activity" by @jmusial (High confidence)
Related Issues: #79568
Recommendation: REVERT
This PR introduced a new "Report suspicious activity" feature for domain members. The issue occurs because long email addresses in the confirmation prompt are not properly wrapped, causing content overflow. Since this is a new feature that does not exist in production and reverting will not impact existing functionality, reverting is the safest approach to unblock the deploy.
Labels: Keeping
DeployBlockerCash- this is a Frontend bug that requires an App PR fix or revertEvidence
PR #78372 added the
DomainReportSuspiciousActivityPage.tsxfile which renders the suspicious activity prompt. The issue is reproducible on staging only (v9.3.31-0) and matches the new feature added by this PR.Verification
The bug affects the Report suspicious activity RHP for domain members. Key files modified:
src/pages/domain/Members/DomainReportSuspiciousActivityPage.tsx(new file)src/pages/settings/Security/LockAccount/LockAccountPageBase.tsxsrc/components/RenderHTML.tsxThe prompt renders via RenderHTML component with email in strong tags.
Root Cause
The RenderHTML component sets contentWidth but the strong style does not include word-wrapping properties like wordBreak or overflowWrap. This causes long email addresses to overflow their container, pushing content below it out of bounds.
OSBotify commentedon Mar 4, 2026
Label Decision
The
DeployBlockerCashlabel is correctly applied and should remain. This is a Frontend bug caused by App PR #78372, which means:MelvinBot commentedon Mar 4, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On the "Report suspicious activity" RHP for domain members, long email addresses overflow their container horizontally, causing the content below to also overflow.
What is the root cause of that problem?
The
DomainReportSuspiciousActivityPageuses theRenderHTMLcomponent to render a prompt that embeds the member's email inside<strong>HTML tags:The
RenderHTMLcomponent usesreact-native-render-html, and the base text style (webViewStyles.baseFontStyleatsrc/styles/index.ts:243-250) has nowordBreakproperty:The
<strong>tag style (src/styles/index.ts:302-305) also has nowordBreak. Without this property, CSS defaults towordBreak: 'normal', which only breaks text at whitespace. Long email addresses have no whitespace, so they render as a single unbreakable text run that overflows the container.The container View in
LockAccountPageBase.tsx:92hasflex: 1andmh5margins but no overflow control for the text child.Note: The self-lock version (
LockAccountPage.tsx) uses plain<Text>components (notRenderHTML), which handle wrapping natively and are not affected.What changes do you think we should make in order to solve the problem?
Add
...wordBreak.breakWordtowebViewStyles.baseFontStyleinsrc/styles/index.ts. This pattern is already used in 14+ other styles in the same file (e.g.,emojiSuggestionsText, chat message text styles). On native,wordBreak.breakWordresolves to an empty object (src/styles/utils/wordBreak/index.native.ts), so this change is a no-op on mobile and only affects web.The change:
This ensures all HTML content rendered via
react-native-render-htmlwill break long words to prevent overflow, matching the behavior already applied to most other text elements in the app.What alternative solutions did you explore? (Optional)
Scoped fix on
LockAccountPageBase.tsxcontainer — AddingwordBreakto just the wrapping<View>inLockAccountPageBase.tsx:92. This is more targeted but less robust, as otherRenderHTMLusages throughout the app could have the same issue with long unbreakable strings.Replace
RenderHTMLwith plain<Text>components — Similar to how the self-lock version (LockAccountPage.tsx) works. This would require restructuring the translation strings and adding React elements for bold text, which is more invasive and doesn't fix the root cause for otherRenderHTMLusages.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.jmusial commentedon Mar 5, 2026
PR with a fix here
m-natarajan commentedon Mar 5, 2026
Passed, Chrome / v9.3.31-11
Screen.Recording.2026-03-06.at.00.47.44.mp4
mountiny commentedon Mar 5, 2026
Perfect, thank you!