Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.3.31-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176687/test-cases/41236712
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: iPhone 15 iOS 26.2, partially repro on MacBook air 15.7.4 Chrome
App Component: Left Hand Navigation (LHN)
Action Performed:
Preconditions:
As workspace owner, invite Account B (Approver), Account C (Vacation delegate) and Account D (Submitter) to the workspace. Set Account B as an approver in Workflows.
As Account B, set Account C as a Vacation delegate in Profile - Status.
As Account D, create an expense in the workspace chat and submit it.
- Sign in to ND on iOS device with account D
- Create an expense in the workspace chat, tap Submit
- Stay in the workspace chat
- As Account C on secondary device, open the expense from step 2
- As Account C, click More - Split, and split the expense into two equal parts
- As Account D on main device, after being navigated to the Concierge chat, go to LHN
Expected Result:
Workspace chat does not disappear from LHN for the expense submitter after Vacation delegate split the expense
Actual Result:
Workspace chat disappears from LHN for the expense submitter after Vacation delegate split the expense.
On Web the workspace chat does not disappear from LHN, but user is navigated to the Concierge
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
Screenshots/Videos
1.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022029464989268362446
- Upwork Job ID: 2029464989268362446
- Last Price Increase: 2026-03-26
Issue Owner
Current Issue Owner: @mallenexpensifyMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Mar 5, 2026
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Mar 5, 2026
🔍 Issue Analysis
Please re-state the problem that we are trying to solve in this issue.
When a vacation delegate splits a submitted expense, the workspace chat disappears from the LHN for the expense submitter on iOS, and the user is navigated to Concierge. On Web, the workspace chat remains in the LHN but the user is still navigated to Concierge.
What is the root cause of that problem?
There are two contributing factors:
1. Server-side Onyx updates from the split modify the workspace chat report in a way that causes it to fail LHN filtering
When the vacation delegate (Account C) performs the split action, the server processes the
SplitTransactioncommand and sends Onyx updates via Pusher to all affected participants, including the submitter (Account D). These updates likely modify the workspace chat report's data — either by overwritingparticipants(which could lose the submitter'snotificationPreference), changing the report structure, or briefly setting it to null.The
getReportNotificationPreferencefunction atsrc/libs/ReportUtils.ts:1896-1902defaults toHIDDENfor any missing or falsynotificationPreference:If the server's Onyx merge overwrites or drops the submitter's participant entry, the report immediately becomes hidden for them. Additionally,
ReportScreenatsrc/pages/inbox/ReportScreen.tsx:711-718detects when a policy expense chat becomes empty and triggers navigation to Concierge.2. Platform difference in
useSidebarOrderedReports— iOS doesn't force-include the focused report in the LHNAt
src/hooks/useSidebarOrderedReports.tsx:296-310, there is explicit logic that only re-generates the LHN list to include the currently-focused report whenshouldUseNarrowLayoutisfalse(Web/wide layout):On iOS (narrow layout), this re-generation is skipped. So if a server Onyx update causes the workspace chat to fail
shouldDisplayReportInLHN, it disappears from the LHN on iOS with no recovery, while on Web it stays because of the force-inclusion.What changes do you think we should make in order to solve the problem?
The fix should address both the server-side root cause and the client-side platform discrepancy:
Primary fix (server-side investigation needed): The server's Onyx updates sent to the submitter during a vacation delegate split should not modify the workspace chat report's
participantsin a way that loses the submitter'snotificationPreference. This requires investigating the Auth backend'sSplitTransactioncommand handler to see what Onyx updates it generates for non-acting participants. The Onyx merge for the workspace chat should preserve existing participant entries.Client-side defense-in-depth: In
src/libs/SidebarUtils.ts:252-260, theshouldOverrideHiddencheck already includesreport.isOwnPolicyExpenseChat && !isReportArchived, which should prevent the submitter's own workspace chat from being filtered out even if it becomes hidden. If the server's Onyx update preservesisOwnPolicyExpenseChat: true, this override should work. The investigation should verify whether the server's update is overwriting this field.Additionally, the navigation-to-Concierge behavior on both platforms (lines 711-768 of
ReportScreen.tsx) should be reviewed to ensure that report modifications from split operations on other devices don't triggerisRemovalExpectedForReportTypefor the workspace chat.What alternative solutions did you explore? (Optional)
useSidebarOrderedReportsforce-inclusion logic to also apply on narrow layouts (iOS) would prevent reports from disappearing from the LHN, but this would be a workaround rather than addressing the root cause. The comment in the code (lines 292-295) explicitly states this was intentionally skipped for mobile, so changing it requires careful consideration of the mobile UX impact.participantsfield is never overwritten with partial data — but this wouldn't help since the problematic Onyx updates come from the server, not from the client's optimistic data.Detailed Investigation
Evidence Chain
LHN Filtering Pipeline:
shouldDisplayReportInLHN(src/libs/SidebarUtils.ts:212-281)isHiddenForCurrentUserchecksnotificationPreference— returns true for any falsy value (src/libs/ReportUtils.ts:2228-2239)Split Transaction Flow:
updateSplitTransactionsinsrc/libs/actions/IOU/Split.ts:1027Onyx.METHOD.MERGEwithvalue: null(Split.ts:1445-1449)buildOnyxDataForMoneyRequestinIOU/index.tsMERGEs the workspace chat with updatediouReportIDandoutstandingChildRequestDelegate System:
notificationPreferenceforcurrentUserAccountID(IOU/index.ts:7859-7861) — this doesn't help the submitterPlatform Difference:
useSidebarOrderedReports(src/hooks/useSidebarOrderedReports.tsx:296-310) force-includes the focused report only on wide layoutsReportScreen(src/pages/inbox/ReportScreen.tsx:701-768) detectsisRemovalExpectedForReportTypewhen a policy expense chat becomes empty, triggering navigation to ConciergeOpen Questions
participantsorisOwnPolicyExpenseChatfields?Onyx.METHOD.SET(which overwrites entirely) instead ofOnyx.METHOD.MERGE(which preserves existing keys) for the workspace chat report update?isOwnPolicyExpenseChatoverride inshouldOverrideHiddenstill apply after the server's Onyx update, or does the update clear this field?Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.melvin-bot commentedon Mar 5, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)[-]Vacation delegate - Submitter is navigated to Concierge chat, WS chat disappears from LHN[/-][+][$250] Vacation delegate - Submitter is navigated to Concierge chat, WS chat disappears from LHN[/+]melvin-bot commentedon Mar 5, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022029464989268362446
chebon254 commentedon Mar 5, 2026
Contributor details
Your Expensify account email: kelvinchebon90@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/codeprolific
melvin-bot commentedon Mar 5, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
chebon254 commentedon Mar 5, 2026
Proposal — Issue #84248
Please re-state the problem that we are trying to solve in this issue.
When a vacation delegate (Account C) splits a submitted expense, the expense submitter (Account D) is unexpectedly navigated to Concierge chat on all platforms, and on mobile (iOS/Android) the workspace chat also disappears from the LHN entirely.
What is the root cause of that problem?
Both symptoms share a single triggering root cause:
ReportScreenincorrectly treats a remote delegate split action as a reason to navigate Account D away from the workspace chat.When Account C performs the split, the server sends Onyx updates to Account D's client that modify or invalidate the IOU report Account D was viewing.
ReportScreen.tsx(around lines 711–768) has logic that detects when the currently-viewed report becomes unavailable or "empty" and callsNavigation.navigateToConciergeChat()as a fallback. This fallback fires even though:Why the LHN disappears on mobile but not Web:
The navigation to Concierge is what causes the LHN regression on mobile. On Web (wide layout), the sidebar is always visible alongside the chat — so the workspace chat stays rendered in the LHN even as the right panel navigates to Concierge. On mobile (narrow layout), navigating to Concierge replaces the entire screen. Once Concierge is the active report, the workspace chat loses its "currently focused" protection in
useSidebarOrderedReports(the force-inclusion guard at lines 296–310 is skipped for narrow layout), so it gets filtered out by the normal LHN rules.In short: fix the navigation destination, and the LHN bug resolves itself.
What changes do you think we should make in order to solve the problem?
In
src/pages/inbox/ReportScreen.tsx, in the logic that triggers navigation away from a report that has become unavailable, add a check: if the report belongs to a workspace (policyIDis set) and the cause of the report becoming unavailable is a remote action (not the current user's own action), navigate to the workspace policy expense chat instead of Concierge.This single change fixes both bugs:
No changes to server-side Onyx data handling or
SidebarUtilsare needed.What alternative solutions did you explore? (Optional)
Option A: Fix the server-side Onyx update (preserve
notificationPreferencein participants during split). This addresses a symptom of the data becoming stale but does not fix the navigation destination — Account D would still be navigated to Concierge even if the workspace chat remains in the LHN.Option B: Extend the
useSidebarOrderedReportsforce-inclusion guard to also apply on narrow (mobile) layouts. This would prevent the LHN disappearance but would not fix the incorrect navigation to Concierge, which is the primary UX problem. The existing code comment also indicates this was intentionally skipped for mobile.Fixing the navigation destination in
ReportScreen.tsxaddresses both bugs at their shared trigger point with a single, targeted change.What is the root cause of that problem?
There are two separate bugs triggered by the same action (delegate splitting the expense):
Bug 1 — Navigation to Concierge chat (all platforms):
When Account C splits the expense,
IOU.splitBillcreates new split reports and the original IOU report that Account D was linked to becomes closed/archived. The app detects that the currently viewed report is no longer accessible and triggers a navigation fallback. The fallback navigates to Concierge chat instead of staying in the workspace policy chat. This is because the "report closed" navigation handler does not check whether the user came from a workspace chat — it just falls back to Concierge unconditionally.Bug 2 — Workspace chat disappears from LHN (mobile only):
The LHN uses
SidebarUtilsto determine which reports to show. On mobile, after the split, the workspace chat temporarily loses its "active" status because the original IOU report it was associated with has been closed and the new split reports have not yet been received/processed by Account D's client. During this window, the LHN filter removes the workspace chat. On Web, the timing is different due to how the browser handles Onyx updates, so the workspace chat does not disappear.What changes do you think we should make in order to solve the problem?
Fix 1 — Navigation (correct fallback after report is closed by a delegate action):
In
src/libs/actions/Report.ts(or wherever the "navigate away from closed report" logic lives), when the current report becomes unavailable due to a split/delegate action, navigate to the workspace policy chat (ROUTES.REPORTfor the policy room) instead of falling back to Concierge. The workspace chatreportIDis accessible from the report'spolicyID.Fix 2 — LHN disappearing on mobile (keep workspace chat visible during split transition):
In
src/libs/SidebarUtils.ts, the workspace policy chat should remain visible while a split is in progress even if its associated IOU reports are temporarily in a transitional state. A guard should be added so the workspace chat is not filtered out when the user has apolicyIDmatch and the split action is pending.What alternative solutions did you explore? (Optional)
For Bug 1: Suppressing the navigation entirely (not navigating away) when the report is closed by a delegate — but this is risky since the report is no longer valid to display. Navigating to the workspace chat is the cleanest UX.
For Bug 2: Adding a debounce or delay before filtering — this is a patch, not a real fix. The correct solution is to retain the workspace chat in LHN when it has a valid policy association, regardless of whether its child IOU reports are in a transitional state.
66 remaining items
suneox commentedon May 6, 2026
@AndrewGable could you please reopen this issue for payment processing? Thanks!
melvin-bot commentedon May 7, 2026
Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.
melvin-bot commentedon May 7, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon May 8, 2026
Payment Summary
Contributor: @neerajbachani paid $250 via Upwork
Contributor+: @suneox due $250 via NewDot
@neerajbachani can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022052560234178095538
neerajbachani commentedon May 8, 2026
Offer Accepted on Upwork @mallenexpensify , thx!
mallenexpensify commentedon May 8, 2026
@neerajbachani paid, summary updated above. Thx.
garrettmknight commentedon May 18, 2026
$250 approved for @suneox