You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-30] Expensify Card - Changing settlement frequency leads to not here tab #84394
Version Number: v9.3.32-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:#84285 Email or phone of affected tester (no customers):applausetester+bp0502fab@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: MacOS Monterey 12.7.4 / Chrome App Component: Other
Action Performed:
Precondition: workspace with added expensify card and travel feture configured.
Open any workspace's Expensify Card page
Open card settings
Settlement frequency display correctly
Open Travel Invoicing page
Change Settlement frequency
Navigate back to Expensify Card page > open Settlement frequency
Change frequency
Expected Result:
User is back to Settings tab with new frequency opened
Please re-state the problem that we are trying to solve in this issue.
After changing the settlement frequency on the Travel Invoicing page, navigating back to the Expensify Card page and opening the Settlement Frequency setting shows the "Hmm... it's not here" blocking view instead of the frequency selection list.
What is the root cause of that problem?
Both Travel Invoicing and Expensify Card store their settlement frequency data (monthlySettlementDate) at the root level of the same Onyx key: private_expensifyCardSettings_{workspaceAccountID}.
Travel Invoicing writes to this key via getTravelInvoicingCardSettingsKey(workspaceAccountID) in TravelInvoicingUtils.ts:139 (which even has a comment: "Uses the same key pattern as Expensify Card (no program suffix)").
When Travel Invoicing changes settlement frequency to "Daily", it writes monthlySettlementDate: null to the root of the shared Onyx key (TravelInvoicing.ts:185). When the user then opens the Expensify Card settlement frequency page, it reads this corrupted value and computes:
This isSettlementFrequencyBlocked = true is passed as shouldBeBlocked to AccessOrNotFoundWrapper (WorkspaceSettlementFrequencyPage.tsx:65-69), which renders the "Hmm... it's not here" FullPageNotFoundView.
What changes do you think we should make in order to solve the problem?
The Travel Invoicing updateTravelInvoiceSettlementFrequency action should write its monthlySettlementDatenested under the TRAVEL_US program key rather than at the root of the shared Onyx entry. The read side already handles this — WorkspaceTravelInvoicingSettlementFrequencyPage calls getCardSettings(cardSettings, CONST.TRAVEL.PROGRAM_TRAVEL_US) which looks for a TRAVEL_US nested object. But the write side in TravelInvoicing.ts writes to the root, which is what causes the conflict.
The fix should be in src/libs/actions/TravelInvoicing.ts in the updateTravelInvoiceSettlementFrequency function: nest the optimistic, success, and failure data under the TRAVEL_US key within the Onyx value, e.g.:
This separates Travel Invoicing's data from the Expensify Card's root-level data in the shared Onyx key.
What alternative solutions did you explore? (Optional)
Use a separate Onyx key for Travel Invoicing — rejected because both features intentionally share PRIVATE_EXPENSIFY_CARD_SETTINGS and the backend returns data under the same key.
Remove the shouldBeBlocked guard on the Card frequency page — rejected because the guard exists for a valid reason (preventing access when there's nothing to change).
Make useDefaultFundID always return a card-specific ID — this would only fix the symptom for workspaces with domain-level cards, not the underlying data collision.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-]Expensify Card - Changing settlement frequency leads to not here tab[/-][+][Due for payment 2026-03-30] Expensify Card - Changing settlement frequency leads to not here tab[/+]on Mar 23, 2026
@parasharrajat / @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 6, 2026
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Mar 6, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
After changing the settlement frequency on the Travel Invoicing page, navigating back to the Expensify Card page and opening the Settlement Frequency setting shows the "Hmm... it's not here" blocking view instead of the frequency selection list.
What is the root cause of that problem?
Both Travel Invoicing and Expensify Card store their settlement frequency data (
monthlySettlementDate) at the root level of the same Onyx key:private_expensifyCardSettings_{workspaceAccountID}.getTravelInvoicingCardSettingsKey(workspaceAccountID)inTravelInvoicingUtils.ts:139(which even has a comment: "Uses the same key pattern as Expensify Card (no program suffix)").useDefaultFundID(policyID)inWorkspaceSettlementFrequencyPage.tsx:29, which falls back toworkspaceAccountIDfor workspaces without legacy domain card programs (useDefaultFundID.ts:48-49).When Travel Invoicing changes settlement frequency to "Daily", it writes
monthlySettlementDate: nullto the root of the shared Onyx key (TravelInvoicing.ts:185). When the user then opens the Expensify Card settlement frequency page, it reads this corrupted value and computes:This
isSettlementFrequencyBlocked = trueis passed asshouldBeBlockedtoAccessOrNotFoundWrapper(WorkspaceSettlementFrequencyPage.tsx:65-69), which renders the "Hmm... it's not here"FullPageNotFoundView.What changes do you think we should make in order to solve the problem?
The Travel Invoicing
updateTravelInvoiceSettlementFrequencyaction should write itsmonthlySettlementDatenested under theTRAVEL_USprogram key rather than at the root of the shared Onyx entry. The read side already handles this —WorkspaceTravelInvoicingSettlementFrequencyPagecallsgetCardSettings(cardSettings, CONST.TRAVEL.PROGRAM_TRAVEL_US)which looks for aTRAVEL_USnested object. But the write side inTravelInvoicing.tswrites to the root, which is what causes the conflict.The fix should be in
src/libs/actions/TravelInvoicing.tsin theupdateTravelInvoiceSettlementFrequencyfunction: nest the optimistic, success, and failure data under theTRAVEL_USkey within the Onyx value, e.g.:This separates Travel Invoicing's data from the Expensify Card's root-level data in the shared Onyx key.
What alternative solutions did you explore? (Optional)
PRIVATE_EXPENSIFY_CARD_SETTINGSand the backend returns data under the same key.shouldBeBlockedguard on the Card frequency page — rejected because the guard exists for a valid reason (preventing access when there's nothing to change).useDefaultFundIDalways return a card-specific ID — this would only fix the symptom for workspaces with domain-level cards, not the underlying data collision.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.melvin-bot commentedon Mar 10, 2026
@allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
8 remaining items
melvin-bot commentedon Mar 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-30. 🎊
For reference, here are some details about the assignees on this issue:
[-]Expensify Card - Changing settlement frequency leads to not here tab[/-][+][Due for payment 2026-03-30] Expensify Card - Changing settlement frequency leads to not here tab[/+]melvin-bot commentedon Mar 23, 2026
@parasharrajat / @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 23, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)mallenexpensify commentedon Mar 30, 2026
I see @ikevin127 and @parasharrajat as reviewers #84501, are they due payment here or are they being paid on a project basis @allgandalf, @blimpich
blimpich commentedon Mar 30, 2026
Project basis